From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH] mt7601u: null check the allocation Date: Wed, 24 Jul 2019 10:16:36 -0700 Message-ID: <20190724101636.4699c30a@cakuba.netronome.com> References: <87d0i00z4t.fsf@kamboji.qca.qualcomm.com> <20190724141736.29994-1-navid.emamdoost@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190724141736.29994-1-navid.emamdoost-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Navid Emamdoost Cc: secalert-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kjlu-OJFnDUYgAso@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, emamd001-OJFnDUYgAso@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, smccaman-OJFnDUYgAso@public.gmane.org, Matthias Brugger , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "David S. Miller" , kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org List-Id: linux-mediatek@lists.infradead.org On Wed, 24 Jul 2019 09:17:36 -0500, Navid Emamdoost wrote: > devm_kzalloc may fail and return NULL. So the null check is needed. > > Signed-off-by: Navid Emamdoost Ah, I replied to the wrong one.. Acked-by: Jakub Kicinski From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD49AC76186 for ; Wed, 24 Jul 2019 17:24:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97AF522387 for ; Wed, 24 Jul 2019 17:24:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=wp.pl header.i=@wp.pl header.b="YeeC3awk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726704AbfGXRYG (ORCPT ); Wed, 24 Jul 2019 13:24:06 -0400 Received: from mx4.wp.pl ([212.77.101.11]:7822 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727541AbfGXRQq (ORCPT ); Wed, 24 Jul 2019 13:16:46 -0400 Received: (wp-smtpd smtp.wp.pl 30481 invoked from network); 24 Jul 2019 19:16:43 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1563988604; bh=z41DzGtUFzaWWcpQAVjI+8rAtK/VXbLYrGHn+dMjo3I=; h=From:To:Cc:Subject; b=YeeC3awkT/FVcvjk+fURFqdyv0r3NGECJaqSruBjt2MEMxHyXyddFZaA64nkaxrka 0lLpbm0O7VZrCjgigBSnZ19v6fCSXRbOMwIZThg3hxH5pulTydVwW1xI4EtrctTXRp wUor382uyQhCqpSoEE8V8sOX195Tb9e+kJQh7ApQ= Received: from 014.152-60-66-biz-static.surewest.net (HELO cakuba.netronome.com) (kubakici@wp.pl@[66.60.152.14]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 24 Jul 2019 19:16:43 +0200 Date: Wed, 24 Jul 2019 10:16:36 -0700 From: Jakub Kicinski To: Navid Emamdoost Cc: kvalo@codeaurora.org, emamd001@umn.edu, kjlu@umn.edu, smccaman@umn.edu, secalert@redhat.com, "David S. Miller" , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mt7601u: null check the allocation Message-ID: <20190724101636.4699c30a@cakuba.netronome.com> In-Reply-To: <20190724141736.29994-1-navid.emamdoost@gmail.com> References: <87d0i00z4t.fsf@kamboji.qca.qualcomm.com> <20190724141736.29994-1-navid.emamdoost@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: fe13a5d9e194338bda75b16965620f67 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [QTPk] Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 24 Jul 2019 09:17:36 -0500, Navid Emamdoost wrote: > devm_kzalloc may fail and return NULL. So the null check is needed. > > Signed-off-by: Navid Emamdoost Ah, I replied to the wrong one.. Acked-by: Jakub Kicinski From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 641ADC41517 for ; Wed, 24 Jul 2019 17:17:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CA0C21951 for ; Wed, 24 Jul 2019 17:17:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XIIcHOqW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=wp.pl header.i=@wp.pl header.b="YeeC3awk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CA0C21951 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=wp.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b+a1Cqrnz/l+8h+CvSPh01KWuWr19QIxnOD9Qb6axkU=; b=XIIcHOqWkkm5Lp rcUWrmgjsHwAA2bcI/jcgEh5WrSKx/GUJaRYMd51dFqJrQemwP6giSY4xTIZwX26lsfqGy/AbHsj5 ZCFNP/N5PEz4qqixXwgQvMIl/tQF2G3s4Ou58TEZK6xc0YaJHpmpAXQH/pyj/GCcGCwlu/y/5fVaW 4ieKt1j0oYWViti29OpZfeDgJuUMGC0U/zDrYcSbZxAFK1QiwtE/FYWODXyWeiO0mfW9LUgXv3lB5 MsvCzncIQNvpEzvs9ZZ+tomIdaW0qZ7nHOH1F8TEalO4d8Lk8X5yjDOiwsOqYITOwZ6DuF2UJNQg8 e2PlBVyY2EKMFolUVm5g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqKt2-00030t-SL; Wed, 24 Jul 2019 17:17:09 +0000 Received: from mx3.wp.pl ([212.77.101.9]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqKsg-0002IL-JW for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2019 17:16:49 +0000 Received: (wp-smtpd smtp.wp.pl 30481 invoked from network); 24 Jul 2019 19:16:43 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1563988604; bh=z41DzGtUFzaWWcpQAVjI+8rAtK/VXbLYrGHn+dMjo3I=; h=From:To:Cc:Subject; b=YeeC3awkT/FVcvjk+fURFqdyv0r3NGECJaqSruBjt2MEMxHyXyddFZaA64nkaxrka 0lLpbm0O7VZrCjgigBSnZ19v6fCSXRbOMwIZThg3hxH5pulTydVwW1xI4EtrctTXRp wUor382uyQhCqpSoEE8V8sOX195Tb9e+kJQh7ApQ= Received: from 014.152-60-66-biz-static.surewest.net (HELO cakuba.netronome.com) (kubakici@wp.pl@[66.60.152.14]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 24 Jul 2019 19:16:43 +0200 Date: Wed, 24 Jul 2019 10:16:36 -0700 From: Jakub Kicinski To: Navid Emamdoost Subject: Re: [PATCH] mt7601u: null check the allocation Message-ID: <20190724101636.4699c30a@cakuba.netronome.com> In-Reply-To: <20190724141736.29994-1-navid.emamdoost@gmail.com> References: <87d0i00z4t.fsf@kamboji.qca.qualcomm.com> <20190724141736.29994-1-navid.emamdoost@gmail.com> MIME-Version: 1.0 X-WP-MailID: fe13a5d9e194338bda75b16965620f67 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [QTPk] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190724_101647_159537_290F41EC X-CRM114-Status: UNSURE ( 4.32 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: secalert@redhat.com, linux-wireless@vger.kernel.org, kjlu@umn.edu, linux-kernel@vger.kernel.org, emamd001@umn.edu, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, smccaman@umn.edu, Matthias Brugger , netdev@vger.kernel.org, "David S. Miller" , kvalo@codeaurora.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 24 Jul 2019 09:17:36 -0500, Navid Emamdoost wrote: > devm_kzalloc may fail and return NULL. So the null check is needed. > > Signed-off-by: Navid Emamdoost Ah, I replied to the wrong one.. Acked-by: Jakub Kicinski _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel