From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH v2 2/2] mwifiex: Make use of the new sdio_trigger_replug() API to reset Date: Wed, 24 Jul 2019 11:35:08 +0000 (UTC) Message-ID: <20190724113508.982836043F@smtp.codeaurora.org> References: <20190722193939.125578-3-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190722193939.125578-3-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Ganapathi Bhat , Ulf Hansson , Brian Norris , Wolfram Sang , Xinming Hu , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andreas Fenkart , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Adrian Hunter , Amitkumar Karwar , Douglas Anderson , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Nishant Sarmukadam , Avri Altman , linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-mmc@vger.kernel.org Douglas Anderson wrote: > As described in the patch ("mmc: core: Add sdio_trigger_replug() > API"), the current mwifiex_sdio_card_reset() is broken in the cases > where we're running Bluetooth on a second SDIO func on the same card > as WiFi. The problem goes away if we just use the > sdio_trigger_replug() API call. > > NOTE: Even though with this new solution there is less of a reason to > do our work from a workqueue (the unplug / plug mechanism we're using > is possible for a human to perform at any time so the stack is > supposed to handle it without it needing to be called from a special > context), we still need a workqueue because the Marvell reset function > could called from a context where sleeping is invalid and thus we > can't claim the host. One example is Marvell's wakeup_timer_fn(). > > Cc: Andreas Fenkart > Cc: Brian Norris > Fixes: b4336a282db8 ("mwifiex: sdio: reset adapter using mmc_hw_reset") > Signed-off-by: Douglas Anderson > Reviewed-by: Brian Norris I assume this is going via some other tree so I'm dropping this from my queue. If I should apply this please resend once the dependency is in wireless-drivers-next. Patch set to Not Applicable. -- https://patchwork.kernel.org/patch/11053351/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches