From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 531FDC7618B for ; Wed, 24 Jul 2019 15:53:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EA85229ED for ; Wed, 24 Jul 2019 15:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563983606; bh=jn2oSrO/9jERyUvQwuwlZYuTEtCtedMvUctisYGwagw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wDSa049XyjYP3PrqFEKKOX0Nxd9jHmTWXcdgnX47inDGhSfCo2Bhw+qHILX6AQlYo 73H3NO+Q82xGKY+zXSTQEHJfoinjzXLRVlKuSo5/wFhECu/CZDmKxFO6jn7hQceMCV ALxq+rrY3rZsK5qdKiRKPueO5tXWbJeMFcIk82zo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725883AbfGXPxZ (ORCPT ); Wed, 24 Jul 2019 11:53:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:56186 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbfGXPxZ (ORCPT ); Wed, 24 Jul 2019 11:53:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C06B21873; Wed, 24 Jul 2019 15:53:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563983604; bh=jn2oSrO/9jERyUvQwuwlZYuTEtCtedMvUctisYGwagw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2GKzG+G3KzdTmHCtSG7BkGwrwUNYMmS41dY4xClObBzRCJYhFd6V4GOFPqzvYB8DZ Uz9I1DmBZ7YtR6Oa7Eer3i0a7zhh0bdwrKnJ5SPOZo9DnocS9XZEenb2K/Y1T52mqj NYASbFC1ar2IS1yEPZthzYINIqUteyzjM/R+SeiU= Date: Wed, 24 Jul 2019 17:53:21 +0200 From: Greg KH To: mathias.nyman@linux.intel.com, m.szyprowski@samsung.com, nsaenzjulienne@suse.de Cc: stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] xhci: Fix immediate data transfer if buffer is already DMA" failed to apply to 5.2-stable tree Message-ID: <20190724155321.GA5571@kroah.com> References: <1563983027111159@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1563983027111159@kroah.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jul 24, 2019 at 05:43:47PM +0200, gregkh@linuxfoundation.org wrote: > > The patch below does not apply to the 5.2-stable tree. > If someone wants it applied there, or to any other stable or longterm > tree, then please email the backport, including the original git commit > id to . > > thanks, > > greg k-h > > ------------------ original commit in Linus's tree ------------------ > > >From 13b82b746310b51b064bc855993a1c84bf862726 Mon Sep 17 00:00:00 2001 > From: Mathias Nyman > Date: Wed, 22 May 2019 14:34:00 +0300 > Subject: [PATCH] xhci: Fix immediate data transfer if buffer is already DMA > mapped > > xhci immediate data transfer (IDT) support in 5.2-rc1 caused regression > on various Samsung Exynos boards with ASIX USB 2.0 ethernet dongle. > > If the transfer buffer in the URB is already DMA mapped then IDT should > not be used. urb->transfer_dma will already contain a valid dma address, > and there is no guarantee the data in urb->transfer_buffer is valid. > > The IDT support patch used urb->transfer_dma as a temporary storage, > copying data from urb->transfer_buffer into it. > > Issue was solved by preventing IDT if transfer buffer is already dma > mapped, and by not using urb->transfer_dma as temporary storage. > > Fixes: 33e39350ebd2 ("usb: xhci: add Immediate Data Transfer support") > Reported-by: Marek Szyprowski > Tested-by: Marek Szyprowski > CC: Nicolas Saenz Julienne > Signed-off-by: Mathias Nyman > Signed-off-by: Greg Kroah-Hartman Oh nevermind, this should be a 5.2-only thing. it shouldn't affect anyone, sorry for the noise. greg k-h