From: Christoph Hellwig <hch@infradead.org>
To: Bharath Vedartham <linux.bhar@gmail.com>
Cc: sivanich@sgi.com, arnd@arndb.de, jhubbard@nvidia.com,
ira.weiny@intel.com, jglisse@redhat.com,
gregkh@linuxfoundation.org, william.kucharski@oracle.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 3/3] sgi-gru: Use __get_user_pages_fast in atomic_pte_lookup
Date: Wed, 24 Jul 2019 09:09:29 -0700 [thread overview]
Message-ID: <20190724160929.GA14052@infradead.org> (raw)
I think the atomic_pte_lookup / non_atomic_pte_lookup helpers
should simply go away. Most of the setup code is common now and should
be in the caller where it can be shared. Then just do a:
if (atomic) {
__get_user_pages_fast()
} else {
get_user_pages_fast();
}
and we actually have an easy to understand piece of code.
next reply other threads:[~2019-07-24 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 16:09 Christoph Hellwig [this message]
2019-07-24 19:34 ` [PATCH v2 3/3] sgi-gru: Use __get_user_pages_fast in atomic_pte_lookup Bharath Vedartham
-- strict thread matches above, loose matches on Subject: below --
2019-07-24 11:41 [PATCH v2 0/3] sgi-gru: get_user_page changes Bharath Vedartham
2019-07-24 11:41 ` [PATCH v2 3/3] sgi-gru: Use __get_user_pages_fast in atomic_pte_lookup Bharath Vedartham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724160929.GA14052@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux.bhar@gmail.com \
--cc=sivanich@sgi.com \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.