From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alyssa Rosenzweig Subject: Re: [PATCH] drm/panfrost: Export all GPU feature registers Date: Wed, 24 Jul 2019 09:40:04 -0700 Message-ID: <20190724164004.GA8255@kevin> References: <20190724105626.53552-1-steven.price@arm.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Steven Price , Daniel Vetter , David Airlie , Tomeu Vizoso , dri-devel , "linux-kernel@vger.kernel.org" , Alyssa Rosenzweig List-Id: dri-devel@lists.freedesktop.org --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable This is definitely helpful! My one concern is, supposing userspace really does need all of this information, is it wasteful to have to do 30+ ioctls just to get this? kbase had a single ioctl to grab all of the properties, whether userspace wanted them or not. I'm not sure if that's better -- the two approaches are rather polar opposites. Granted this would be on driver init so not a critical path. On Wed, Jul 24, 2019 at 10:27:03AM -0600, Rob Herring wrote: > Adding Alyssa's Collabora email. >=20 > On Wed, Jul 24, 2019 at 4:56 AM Steven Price wrote: > > > > Midgard/Bifrost GPUs have a bunch of feature registers providing details > > of what the hardware supports. Panfrost already reads these, this patch > > exports them all to user space so that the jobs created by the user spa= ce > > driver can be tuned for the particular hardware implementation. > > > > Signed-off-by: Steven Price > > --- > > drivers/gpu/drm/panfrost/panfrost_device.h | 1 + > > drivers/gpu/drm/panfrost/panfrost_drv.c | 38 +++++++++++++++++++-- > > drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 ++ > > include/uapi/drm/panfrost_drm.h | 39 ++++++++++++++++++++++ > > 4 files changed, 77 insertions(+), 3 deletions(-) >=20 > LGTM. I'll give it a bit more time to see if there are any comments > before I apply it. >=20 > Rob --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEQ17gm7CvANAdqvY4/v5QWgr1WA0FAl04id4ACgkQ/v5QWgr1 WA0lzRAAi1aJutAUzh1Pr9kmsSkjB1v5aMpdDQPOT7W/hfgODztRyqINqZNWuItB Mmt45PyXLcFV+S+ZT7rzYtwRlm9HOL+N5iXakC8UgfqlF3lCYmosrAJHNjb3Czmk aJ0WAyXZOHpmDQI6p0ATa5H8sNJGy31UbtHVYfT7WO55XW2VH/F+f9nIoOJMA/SF L3ktWjzTg7PNBqSIPde/2xy2czZTXHyMwQV4aP8U7U/V0OViYxhXyO6Nyuy9XBsW OpO1Q6Ka+DO6o/rEAwWREFOfI/NI4ISeyJhW60gBT2uq6oaLh3ohseET4oM0/EkM BI4QcwuB1cwjfUFK7uuCdFR8KNhKRdJeE9iuw6+spU8/BUmBwsJtd6y+k2QVTfOq oiD8ebpNoFXdLncQcVYRz85q2idD0BvhNLoslFPRs/pX/kYPax6uppmXRZ98XOEt wN0Fg29ph8TmDS+fsyljPUd12pgEtb4EDMouJAwROGqSNqw7IjISYHaGH3oojGSt K5+Zx8halrk78aYFh9Wv+0REtrK2bzxPv4vd4pEMnS3oHtc37qNei5WXeL1wvjMa /L/cFSAw2cl3NN8Ex2+CKFstI1I702BOQMI0yoGCgbnFTjiWC5QpO1O4VZuFBhJg 1I6nA8xn4bOUxcrCYKiMmhylTL9BasZ9RDFQKk2ggWvayAR3/l4= =+QFJ -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs--