From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7908C76191 for ; Wed, 24 Jul 2019 19:07:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FA4722387 for ; Wed, 24 Jul 2019 19:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563995271; bh=CHVJh9K7ZQptFPowFVNdpt0/XiL4yyZHMyfptvh0d/E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kTXn4JnJo0wfZNwQHJKS/ea6zQY8h9wOgtKmf0Nlvkt+SUY9K1KHPwmiDdiivNW6G VIxn53HqJMvul17hFlh2DImAJwwV3hLl+yfA5p66/lHAs/wPbWZqhQhno84tWcfegC hO47RTpjhNcAxepbtWCABIk/34J2udXnyew9QNHE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727550AbfGXTHr convert rfc822-to-8bit (ORCPT ); Wed, 24 Jul 2019 15:07:47 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:34958 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726622AbfGXTHq (ORCPT ); Wed, 24 Jul 2019 15:07:46 -0400 Received: by mail-wm1-f66.google.com with SMTP id l2so42561120wmg.0; Wed, 24 Jul 2019 12:07:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=jtQSPuZ1QzMs99js7V9Wo2RTLphiNzuGhsELT//GEEg=; b=q7WyBGiVaCx5zfiZXWWNePnxq2V8kdF+At38cApdo9WIgMtWVzeorGDfmE2mSdqKUS 8slYk5rh5ZcIPEmOSPzdDq/3WjYYoM9cFC1s1ZDZYagfVGQ6Iq7Bdqea5N39Zx/FAsa5 szF0mpUcDM3SWpJEWynYqY1oD1eIHl1BV+wDd063l3gEzuKxTqGUfwILWkSn1iCooBde UqFNTNcXspiAK38An6RJIFkj+1lokybzjm8873pVBsUOKcsVu9mv+5sPChUfsDNnq/i0 cXJdvMEKpmIWz0a9nsPJlAVyOYD9lau589X+Y11kULsSmD5wNWJyEKjF3DKRGRplLCyZ 0Q+Q== X-Gm-Message-State: APjAAAWmzndQIqbCCVKBwMKE0YLxwaYFjj5/EbN28/NNl8Tpek2Z1l1+ I5AeB4Gr5DeLWzuzzrvzG70= X-Google-Smtp-Source: APXvYqzW5J/UxiwCLKihWU+W6v0QY2SUnZdcHCLGNhpwuL3J4T0/WFqdxk7zt2m7BHrB78puwFES8w== X-Received: by 2002:a05:600c:212:: with SMTP id 18mr25939276wmi.88.1563995264126; Wed, 24 Jul 2019 12:07:44 -0700 (PDT) Received: from kozik-lap ([194.230.155.239]) by smtp.googlemail.com with ESMTPSA id w23sm48058527wmi.45.2019.07.24.12.07.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jul 2019 12:07:43 -0700 (PDT) Date: Wed, 24 Jul 2019 21:07:41 +0200 From: Krzysztof Kozlowski To: Artur =?utf-8?B?xZp3aWdvxYQ=?= Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org, cw00.choi@samsung.com, myungjoo.ham@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, georgi.djakov@linaro.org, m.szyprowski@samsung.com Subject: Re: [RFC PATCH 01/11] devfreq: exynos-bus: Extract exynos_bus_profile_init() Message-ID: <20190724190741.GD14346@kozik-lap> References: <20190723122016.30279-1-a.swigon@partner.samsung.com> <20190723122016.30279-2-a.swigon@partner.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20190723122016.30279-2-a.swigon@partner.samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Jul 23, 2019 at 02:20:06PM +0200, Artur Świgoń wrote: > This patch adds a new static function, exynos_bus_profile_init(), extracted > from exynos_bus_probe(). > > Signed-off-by: Artur Świgoń > --- > drivers/devfreq/exynos-bus.c | 106 ++++++++++++++++++++--------------- > 1 file changed, 60 insertions(+), 46 deletions(-) > > diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c > index d9f377912c10..d8f1efaf2d49 100644 > --- a/drivers/devfreq/exynos-bus.c > +++ b/drivers/devfreq/exynos-bus.c > @@ -372,12 +372,69 @@ static int exynos_bus_parse_of(struct device_node *np, > return ret; > } > > +static int exynos_bus_profile_init(struct exynos_bus *bus, > + struct devfreq_dev_profile *profile) > +{ > + struct device *dev = bus->dev; > + struct devfreq_simple_ondemand_data *ondemand_data; > + int ret; > + > + /* Initialize the struct profile and governor data for parent device */ > + profile->polling_ms = 50; > + profile->target = exynos_bus_target; > + profile->get_dev_status = exynos_bus_get_dev_status; > + profile->exit = exynos_bus_exit; > + > + ondemand_data = devm_kzalloc(dev, sizeof(*ondemand_data), GFP_KERNEL); > + if (!ondemand_data) { > + ret = -ENOMEM; > + goto err; Just return proper error code. Less lines, obvious code since you do not have any cleanup in error path. > + } > + ondemand_data->upthreshold = 40; > + ondemand_data->downdifferential = 5; > + > + /* Add devfreq device to monitor and handle the exynos bus */ > + bus->devfreq = devm_devfreq_add_device(dev, profile, > + DEVFREQ_GOV_SIMPLE_ONDEMAND, > + ondemand_data); > + if (IS_ERR(bus->devfreq)) { > + dev_err(dev, "failed to add devfreq device\n"); > + ret = PTR_ERR(bus->devfreq); > + goto err; > + } > + > + /* Register opp_notifier to catch the change of OPP */ > + ret = devm_devfreq_register_opp_notifier(dev, bus->devfreq); > + if (ret < 0) { > + dev_err(dev, "failed to register opp notifier\n"); > + goto err; The same - return err. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91221C76186 for ; Wed, 24 Jul 2019 19:07:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 681E521926 for ; Wed, 24 Jul 2019 19:07:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dey+L0TB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 681E521926 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/305ZhTnYUS4wCFSthukzjEawf96OKQl8Snep7cnIx8=; b=dey+L0TBh6dXXC v8VZOSi+3Ya5h4k1b7t7HCQFZlCm0kixwY/VmMa1+NCesMbhPVxT4tGvyKtR3eGc+ucOUTcChhWvm pL6+4E/Ug/ryxh+8Z1TE0LwZpWzoAbGX2SezuXG8sN1Z6JWKnc5UX4SzS/vLfk65N/eirp15cBbau yKq8tFUAug17L04TfrBTkDw+Y8y7ia8rYj8NjIyFNcm+SI37PlyhwAzjlsxLWpVDRYkV3f+2XDqre EPlDUCxu9P2UULtYTHBhsUnF5k9AN9C9UJkJgmGkiA8YWtaD3KzkJVmVdxVOU/a2+qORnRJRUnJwa 21QMv0Uw71P/nOu3Z7yw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqMc8-0004Au-P4; Wed, 24 Jul 2019 19:07:48 +0000 Received: from mail-wm1-f67.google.com ([209.85.128.67]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqMc5-0004AU-V6 for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2019 19:07:47 +0000 Received: by mail-wm1-f67.google.com with SMTP id a15so42762854wmj.5 for ; Wed, 24 Jul 2019 12:07:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=jtQSPuZ1QzMs99js7V9Wo2RTLphiNzuGhsELT//GEEg=; b=Fo6s7n+0uBM4WICyzEaNHx0f8/bGumbjXNaXIhohNYzQ4KWzJ41Iln7zd6sFsc5pOQ fhMxFwQuuZzu2yLxB8DyHu0BsWtW4wDKdpAAhV9mz/WcO4sFRwxlax/aKfZDeYUAD8BJ Vx7Hi7qxy3l9D25R8qRlsqlXOzz8eCyvYvH/VlDLD8m5NkLT0oUzZTyr7122GrkAS7CM 10XJjKrHFAUSI2CJ/MLufnqb6pHKVR6JiFa2mLjNxJZdjJeOyW7gx1szFeYZaGMSZGEB V8eQaWbl29rQK6DfRLF0YZE4xKfrjMVGoV9yeyvsTvgEB/iR8HKCkLli5Gv0yNc5uudi hCNA== X-Gm-Message-State: APjAAAWlFbj05dS2kLg4nXAGt3pFx25jvaWkZGOELfnMd57jZnkq36/J rppezuU8WcKZ4ne8PusdlgM= X-Google-Smtp-Source: APXvYqzW5J/UxiwCLKihWU+W6v0QY2SUnZdcHCLGNhpwuL3J4T0/WFqdxk7zt2m7BHrB78puwFES8w== X-Received: by 2002:a05:600c:212:: with SMTP id 18mr25939276wmi.88.1563995264126; Wed, 24 Jul 2019 12:07:44 -0700 (PDT) Received: from kozik-lap ([194.230.155.239]) by smtp.googlemail.com with ESMTPSA id w23sm48058527wmi.45.2019.07.24.12.07.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jul 2019 12:07:43 -0700 (PDT) Date: Wed, 24 Jul 2019 21:07:41 +0200 From: Krzysztof Kozlowski To: Artur =?utf-8?B?xZp3aWdvxYQ=?= Subject: Re: [RFC PATCH 01/11] devfreq: exynos-bus: Extract exynos_bus_profile_init() Message-ID: <20190724190741.GD14346@kozik-lap> References: <20190723122016.30279-1-a.swigon@partner.samsung.com> <20190723122016.30279-2-a.swigon@partner.samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190723122016.30279-2-a.swigon@partner.samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190724_120746_004662_15C7A38B X-CRM114-Status: GOOD ( 16.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, sw0312.kim@samsung.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, inki.dae@samsung.com, cw00.choi@samsung.com, myungjoo.ham@samsung.com, georgi.djakov@linaro.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdWwgMjMsIDIwMTkgYXQgMDI6MjA6MDZQTSArMDIwMCwgQXJ0dXIgxZp3aWdvxYQg d3JvdGU6Cj4gVGhpcyBwYXRjaCBhZGRzIGEgbmV3IHN0YXRpYyBmdW5jdGlvbiwgZXh5bm9zX2J1 c19wcm9maWxlX2luaXQoKSwgZXh0cmFjdGVkCj4gZnJvbSBleHlub3NfYnVzX3Byb2JlKCkuCj4g Cj4gU2lnbmVkLW9mZi1ieTogQXJ0dXIgxZp3aWdvxYQgPGEuc3dpZ29uQHBhcnRuZXIuc2Ftc3Vu Zy5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZGV2ZnJlcS9leHlub3MtYnVzLmMgfCAxMDYgKysrKysr KysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDYwIGluc2Vy dGlvbnMoKyksIDQ2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2RldmZy ZXEvZXh5bm9zLWJ1cy5jIGIvZHJpdmVycy9kZXZmcmVxL2V4eW5vcy1idXMuYwo+IGluZGV4IGQ5 ZjM3NzkxMmMxMC4uZDhmMWVmYWYyZDQ5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZGV2ZnJlcS9l eHlub3MtYnVzLmMKPiArKysgYi9kcml2ZXJzL2RldmZyZXEvZXh5bm9zLWJ1cy5jCj4gQEAgLTM3 MiwxMiArMzcyLDY5IEBAIHN0YXRpYyBpbnQgZXh5bm9zX2J1c19wYXJzZV9vZihzdHJ1Y3QgZGV2 aWNlX25vZGUgKm5wLAo+ICAJcmV0dXJuIHJldDsKPiAgfQo+ICAKPiArc3RhdGljIGludCBleHlu b3NfYnVzX3Byb2ZpbGVfaW5pdChzdHJ1Y3QgZXh5bm9zX2J1cyAqYnVzLAo+ICsJCQkJICAgc3Ry dWN0IGRldmZyZXFfZGV2X3Byb2ZpbGUgKnByb2ZpbGUpCj4gK3sKPiArCXN0cnVjdCBkZXZpY2Ug KmRldiA9IGJ1cy0+ZGV2Owo+ICsJc3RydWN0IGRldmZyZXFfc2ltcGxlX29uZGVtYW5kX2RhdGEg Km9uZGVtYW5kX2RhdGE7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCS8qIEluaXRpYWxpemUgdGhlIHN0 cnVjdCBwcm9maWxlIGFuZCBnb3Zlcm5vciBkYXRhIGZvciBwYXJlbnQgZGV2aWNlICovCj4gKwlw cm9maWxlLT5wb2xsaW5nX21zID0gNTA7Cj4gKwlwcm9maWxlLT50YXJnZXQgPSBleHlub3NfYnVz X3RhcmdldDsKPiArCXByb2ZpbGUtPmdldF9kZXZfc3RhdHVzID0gZXh5bm9zX2J1c19nZXRfZGV2 X3N0YXR1czsKPiArCXByb2ZpbGUtPmV4aXQgPSBleHlub3NfYnVzX2V4aXQ7Cj4gKwo+ICsJb25k ZW1hbmRfZGF0YSA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZigqb25kZW1hbmRfZGF0YSksIEdG UF9LRVJORUwpOwo+ICsJaWYgKCFvbmRlbWFuZF9kYXRhKSB7Cj4gKwkJcmV0ID0gLUVOT01FTTsK PiArCQlnb3RvIGVycjsKCkp1c3QgcmV0dXJuIHByb3BlciBlcnJvciBjb2RlLiBMZXNzIGxpbmVz LCBvYnZpb3VzIGNvZGUgc2luY2UgeW91IGRvIG5vdApoYXZlIGFueSBjbGVhbnVwIGluIGVycm9y IHBhdGguCgo+ICsJfQo+ICsJb25kZW1hbmRfZGF0YS0+dXB0aHJlc2hvbGQgPSA0MDsKPiArCW9u ZGVtYW5kX2RhdGEtPmRvd25kaWZmZXJlbnRpYWwgPSA1Owo+ICsKPiArCS8qIEFkZCBkZXZmcmVx IGRldmljZSB0byBtb25pdG9yIGFuZCBoYW5kbGUgdGhlIGV4eW5vcyBidXMgKi8KPiArCWJ1cy0+ ZGV2ZnJlcSA9IGRldm1fZGV2ZnJlcV9hZGRfZGV2aWNlKGRldiwgcHJvZmlsZSwKPiArCQkJCQkJ REVWRlJFUV9HT1ZfU0lNUExFX09OREVNQU5ELAo+ICsJCQkJCQlvbmRlbWFuZF9kYXRhKTsKPiAr CWlmIChJU19FUlIoYnVzLT5kZXZmcmVxKSkgewo+ICsJCWRldl9lcnIoZGV2LCAiZmFpbGVkIHRv IGFkZCBkZXZmcmVxIGRldmljZVxuIik7Cj4gKwkJcmV0ID0gUFRSX0VSUihidXMtPmRldmZyZXEp Owo+ICsJCWdvdG8gZXJyOwo+ICsJfQo+ICsKPiArCS8qIFJlZ2lzdGVyIG9wcF9ub3RpZmllciB0 byBjYXRjaCB0aGUgY2hhbmdlIG9mIE9QUCAgKi8KPiArCXJldCA9IGRldm1fZGV2ZnJlcV9yZWdp c3Rlcl9vcHBfbm90aWZpZXIoZGV2LCBidXMtPmRldmZyZXEpOwo+ICsJaWYgKHJldCA8IDApIHsK PiArCQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byByZWdpc3RlciBvcHAgbm90aWZpZXJcbiIpOwo+ ICsJCWdvdG8gZXJyOwoKVGhlIHNhbWUgLSByZXR1cm4gZXJyLgoKQmVzdCByZWdhcmRzLApLcnp5 c3p0b2YKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==