From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EEC3C76186 for ; Wed, 24 Jul 2019 19:10:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 233D8218F0 for ; Wed, 24 Jul 2019 19:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563995418; bh=esIJq4UKFmo/AFPOxaXUOoVqiee0ziEThR2SsEPoOlY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=J2Vq5vnNftkHqqWg0RhvWU+OIYIJRqmcO3JbufViZETm75bSCKOnwjL+dl0k214Ww oXlQ1eDoGlPV4oOxq/42yBMV/y6JC9yIVOBAMFiGQfkfQE4OhlZt7vY3u8zar7InzG N9poJ+1PknTCIeqIOdJe22Fv9jvbwyrPl8cDSbiY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728393AbfGXTKM convert rfc822-to-8bit (ORCPT ); Wed, 24 Jul 2019 15:10:12 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:33332 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbfGXTKM (ORCPT ); Wed, 24 Jul 2019 15:10:12 -0400 Received: by mail-wr1-f67.google.com with SMTP id n9so48218602wru.0; Wed, 24 Jul 2019 12:10:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=HSdo9ZmudjoY5QfVd80yVoDhymQ27WsVZ3uLmAFSang=; b=UQ6HCb0/f1XrGVWnQ40XkLGhlIU01u9FQrsfKnawPRRbBuY16J/QH2JzBwJAHgL0DO Ug2eMEw8Sb9WnAJs+hOkydXE90YuQlmBKVFxTBpTm58axGPVbTWSIJxdJEQAVxgNG96l ua9+c82futZonjh0nb73t4+vzIdgNyHW7itfIrL12WqogghfrnCgAhq9Dt4FifSCQl7u /Qu5mGwmpiwhcU8/3Ck6uGgL/f4CRRNUDpeiecNnkFff0uLLjbIHTMLRYmBY3uyy39d3 tZ4SIXPMgqZup56+6xH39XYDfRzylaK9Qm5j0+1VPhupoYxwL70XkHGon9OyPAX0l2DW HWUA== X-Gm-Message-State: APjAAAVK6/jarw+YTYNSrNzeAJY0B6Cg3I5c2xLHLgc0ScA9cFa6xDfi VGshgPIgOIKq6cbPmyhO94s= X-Google-Smtp-Source: APXvYqyWQBOON9MCwlXaZ8Eic8a5Grk22K3A0wrcZg+IPuNCk48LkzoWpj7xmqjgI5qwVDbGSZBdAQ== X-Received: by 2002:a5d:4d81:: with SMTP id b1mr6533715wru.27.1563995409586; Wed, 24 Jul 2019 12:10:09 -0700 (PDT) Received: from kozik-lap ([194.230.155.239]) by smtp.googlemail.com with ESMTPSA id v4sm44882540wmg.22.2019.07.24.12.10.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jul 2019 12:10:08 -0700 (PDT) Date: Wed, 24 Jul 2019 21:10:06 +0200 From: Krzysztof Kozlowski To: Artur =?utf-8?B?xZp3aWdvxYQ=?= Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org, cw00.choi@samsung.com, myungjoo.ham@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, georgi.djakov@linaro.org, m.szyprowski@samsung.com Subject: Re: [RFC PATCH 03/11] devfreq: exynos-bus: Change goto-based logic to if-else logic Message-ID: <20190724191006.GF14346@kozik-lap> References: <20190723122016.30279-1-a.swigon@partner.samsung.com> <20190723122016.30279-4-a.swigon@partner.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20190723122016.30279-4-a.swigon@partner.samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Jul 23, 2019 at 02:20:08PM +0200, Artur Świgoń wrote: > This patch improves code readability by changing the following construct: > > > if (cond) > > goto passive; > > foo(); > > goto out; > >passive: > > bar(); > >out: > > into this: > > > if (cond) > > bar(); > > else > > foo(); > > Signed-off-by: Artur Świgoń > --- > drivers/devfreq/exynos-bus.c | 24 +++++++++--------------- > 1 file changed, 9 insertions(+), 15 deletions(-) Code looks much better: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0072FC76186 for ; Wed, 24 Jul 2019 19:10:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBF8F218F0 for ; Wed, 24 Jul 2019 19:10:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mLTgwhMG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBF8F218F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UWzXnMNYXlqTxzvXn2n8oJ29yaxOrdk4nOqZZwugWi8=; b=mLTgwhMGtud5l8 qKhHpV/jCvWm8Syevb9tFJVimrMVBFezurcP3p2CSQjkge3eOYpln7y9cqI8L/bmO7PV56g3hStXi AenhAiEIV1aZMahQql/3aZFZsbx7Bo1PE96YTsZf/J96jR9YHvaK1C7hJFGKKp1IZ1XFQnzhsaJGM vflTHbbyAsOXrQyg15bQY/eqk7+S77zNJRmU8Sogd/ms6ry2lOsYnBcq4i8iU4x4KtOj5xcwBFXr0 f89qV+ZRShMp4I/Kj9y6WMlHnDharAolcEVtxBO/gzg0sUqa3iZc99sdCpVuYLZHj8OGZuAnJSEpf jOC7hotmiqp4PAkzceqQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqMeU-0005zS-7m; Wed, 24 Jul 2019 19:10:14 +0000 Received: from mail-wr1-f68.google.com ([209.85.221.68]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqMeR-0005yr-81 for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2019 19:10:12 +0000 Received: by mail-wr1-f68.google.com with SMTP id r1so48121393wrl.7 for ; Wed, 24 Jul 2019 12:10:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=HSdo9ZmudjoY5QfVd80yVoDhymQ27WsVZ3uLmAFSang=; b=hindbzBLt9vpEvex+iE1OLgHTfsAYOEKDmVfRUId8yqVMp47xylPdPrwAdxGCUVH4a DnIgzRZlgFJbpTBqG6G9gYRH6eZzTzon+ls3pVc6u0zDCIwSVqw3a1Aq88yJcI0KitdV jgmfPvLNPMF3izPVuI8EpdlblS3CQdV8k0yoqhvxfVZ3FYvqJSN+G0LPZ5qNU9hf4u8c 9uzBFwvwgY5yaWY4MfxG4Dmjv1I3OdYkBWo+mm7ZTkz87TrK9zHy0dnev2RIHcl5R/rR uZ6u5bePuSdDp432DlQWNOQmaa8zpx+3TCROFXrq2dMtX8v4LcgHkyfMkUyiCep0fz5C LPmQ== X-Gm-Message-State: APjAAAVCrBhxeJS/ZgTltSjKFsmekpHhsnCmRmjbINzz/RpRpwBh8l1X pEor/7nPKfK4T78OT4JNeuk= X-Google-Smtp-Source: APXvYqyWQBOON9MCwlXaZ8Eic8a5Grk22K3A0wrcZg+IPuNCk48LkzoWpj7xmqjgI5qwVDbGSZBdAQ== X-Received: by 2002:a5d:4d81:: with SMTP id b1mr6533715wru.27.1563995409586; Wed, 24 Jul 2019 12:10:09 -0700 (PDT) Received: from kozik-lap ([194.230.155.239]) by smtp.googlemail.com with ESMTPSA id v4sm44882540wmg.22.2019.07.24.12.10.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jul 2019 12:10:08 -0700 (PDT) Date: Wed, 24 Jul 2019 21:10:06 +0200 From: Krzysztof Kozlowski To: Artur =?utf-8?B?xZp3aWdvxYQ=?= Subject: Re: [RFC PATCH 03/11] devfreq: exynos-bus: Change goto-based logic to if-else logic Message-ID: <20190724191006.GF14346@kozik-lap> References: <20190723122016.30279-1-a.swigon@partner.samsung.com> <20190723122016.30279-4-a.swigon@partner.samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190723122016.30279-4-a.swigon@partner.samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190724_121011_287803_35742708 X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, sw0312.kim@samsung.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, inki.dae@samsung.com, cw00.choi@samsung.com, myungjoo.ham@samsung.com, georgi.djakov@linaro.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdWwgMjMsIDIwMTkgYXQgMDI6MjA6MDhQTSArMDIwMCwgQXJ0dXIgxZp3aWdvxYQg d3JvdGU6Cj4gVGhpcyBwYXRjaCBpbXByb3ZlcyBjb2RlIHJlYWRhYmlsaXR5IGJ5IGNoYW5naW5n IHRoZSBmb2xsb3dpbmcgY29uc3RydWN0Ogo+IAo+ID4gICAgaWYgKGNvbmQpCj4gPiAgICAgICAg Z290byBwYXNzaXZlOwo+ID4gICAgZm9vKCk7Cj4gPiAgICBnb3RvIG91dDsKPiA+cGFzc2l2ZToK PiA+ICAgIGJhcigpOwo+ID5vdXQ6Cj4gCj4gaW50byB0aGlzOgo+IAo+ID4gICAgaWYgKGNvbmQp Cj4gPiAgICAgICAgYmFyKCk7Cj4gPiAgICBlbHNlCj4gPiAgICAgICAgZm9vKCk7Cj4gCj4gU2ln bmVkLW9mZi1ieTogQXJ0dXIgxZp3aWdvxYQgPGEuc3dpZ29uQHBhcnRuZXIuc2Ftc3VuZy5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZGV2ZnJlcS9leHlub3MtYnVzLmMgfCAyNCArKysrKysrKystLS0t LS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRp b25zKC0pCgpDb2RlIGxvb2tzIG11Y2ggYmV0dGVyOgpSZXZpZXdlZC1ieTogS3J6eXN6dG9mIEtv emxvd3NraSA8a3J6a0BrZXJuZWwub3JnPgoKQmVzdCByZWdhcmRzLApLcnp5c3p0b2YKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK