From: Denys Dmytriyenko <denys@ti.com>
To: "Andrew F. Davis" <afd@ti.com>
Cc: meta-ti@yoctoproject.org
Subject: Re: [thud/master][RFC PATCH 3/3] ti-sgx-ddk-um: Drop omap5-sgx-ddk-um-linux package
Date: Wed, 24 Jul 2019 15:14:12 -0400 [thread overview]
Message-ID: <20190724191412.GE5700@beryl> (raw)
In-Reply-To: <20190719210619.18583-3-afd@ti.com>
On Fri, Jul 19, 2019 at 05:06:19PM -0400, Andrew F. Davis wrote:
> No one depends on this and it does not really get built,
> remove this from PROVIDES.
Bah, such a nice commit message. :)
Seriously though, it is there for backward compatibility. That was the name
of this package few years ago. Sure, "it does not get built", but claiming
that "no one depends on this" is really a guess. There might be old recipes
out there depending on this package by its old name...
Anyway, I don't mind dropping this backward compatibility, since it's been
several years already, but I would like to see a better commit message.
Thanks.
--
Denys
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> .../libgles/ti-sgx-ddk-um_1.17.4948957.bb | 20 +++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> index a1e35b52..10c54978 100644
> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> @@ -23,22 +23,22 @@ INITSCRIPT_PARAMS = "defaults 8"
>
> inherit update-rc.d
>
> -PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm omap5-sgx-ddk-um-linux"
> +PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm"
>
> DEPENDS += "libdrm udev wayland libffi expat"
> RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland libffi expat"
>
> -RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
> -RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
> -RPROVIDES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg omap5-sgx-ddk-um-linux-dbg"
> +RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm"
> +RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev"
> +RPROVIDES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg"
>
> -RREPLACES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
> -RREPLACES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
> -RREPLACES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg omap5-sgx-ddk-um-linux-dbg"
> +RREPLACES_${PN} = "libegl libgles1 libgles2 libgbm"
> +RREPLACES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev"
> +RREPLACES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg"
>
> -RCONFLICTS_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
> -RCONFLICTS_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
> -RCONFLICTS_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg omap5-sgx-ddk-um-linux-dbg"
> +RCONFLICTS_${PN} = "libegl libgles1 libgles2 libgbm"
> +RCONFLICTS_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev"
> +RCONFLICTS_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg libgbm-dbg"
>
> # The actual SONAME is libGLESv2.so.2, so need to explicitly specify RPROVIDES for .so.1 here
> RPROVIDES_${PN} += "libGLESv2.so.1"
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-07-24 19:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 21:06 [thud/master][RFC PATCH 1/3] ti-sgx-ddk-um: libgbm is now part of this project Andrew F. Davis
2019-07-19 21:06 ` [thud/master][RFC PATCH 2/3] ti-sgx-ddk-um: Add expat as runtime dependency Andrew F. Davis
2019-07-24 19:24 ` Denys Dmytriyenko
2019-07-24 19:29 ` Andrew F. Davis
2019-07-24 20:27 ` Denys Dmytriyenko
2019-07-24 21:31 ` Andrew F. Davis
2019-07-19 21:06 ` [thud/master][RFC PATCH 3/3] ti-sgx-ddk-um: Drop omap5-sgx-ddk-um-linux package Andrew F. Davis
2019-07-24 19:14 ` Denys Dmytriyenko [this message]
2019-07-24 19:30 ` Andrew F. Davis
2019-07-24 20:08 ` Denys Dmytriyenko
2019-07-24 21:08 ` Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724191412.GE5700@beryl \
--to=denys@ti.com \
--cc=afd@ti.com \
--cc=meta-ti@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.