From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 9037AE00E0E; Wed, 24 Jul 2019 12:24:31 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_MED, URI_HEX autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, * medium trust * [198.47.23.249 listed in list.dnswl.org] * 0.1 URI_HEX URI: URI hostname has long hexadecimal sequence * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 6F177E00DD7 for ; Wed, 24 Jul 2019 12:24:30 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x6OJOT2A089378 for ; Wed, 24 Jul 2019 14:24:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1563996269; bh=ALCLg37UacVHWL74b+X6frfCJVOqZ8FpRhZi9vN3COE=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=lsgDsgiVoUcJxvazjhVD1hXG5gHYm60JMkHM2hU3gNw8ZXTwBX6S4AL7E1Jzzb/Nn rnAhOSa1bwVHTpBqDNQUJs1fcZvTorSa7ouki1O8XXrJpMbsFuh2njqpmSgpZtsyoI YMa++tNgIMMuTZRQvMNK8wvt6a3tBUa1JbeEka/0= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x6OJOTds114306 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 24 Jul 2019 14:24:29 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 24 Jul 2019 14:24:29 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 24 Jul 2019 14:24:29 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x6OJOTNU071140; Wed, 24 Jul 2019 14:24:29 -0500 Date: Wed, 24 Jul 2019 15:24:29 -0400 From: Denys Dmytriyenko To: "Andrew F. Davis" Message-ID: <20190724192429.GF5700@beryl> References: <20190719210619.18583-1-afd@ti.com> <20190719210619.18583-2-afd@ti.com> MIME-Version: 1.0 In-Reply-To: <20190719210619.18583-2-afd@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: meta-ti@yoctoproject.org Subject: Re: [thud/master][RFC PATCH 2/3] ti-sgx-ddk-um: Add expat as runtime dependency X-BeenThere: meta-ti@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-ti layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jul 2019 19:24:31 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Fri, Jul 19, 2019 at 05:06:18PM -0400, Andrew F. Davis wrote: > Although not needed for the IMG default EGL implementation libexpat > is needed when using the Mesa EGL version. Yes, and Rogue has it in RDEPENDS, as it uses Mesa. Why would SGX need it? > While here s/libudev/udev as 'libudev' is package shipped as part of the > eudev project, but we use systemd, so we actually depend on 'udev'. And systemd also provides libudev. From run-time dependency, we really require libudev, not udev. As udev is just a daemon and bunch of config files - there is nothing to run-time depend on in there... > Move the PACKAGE_ARCH and PR defines to a more natural spot that also > lines up with the RGX version of recipe for easier diffs. > > One thing we could have done is remove the DEPENDS line. We do not have > any build dependencies as these are pre-made library binaries, but I use > the package rootfs generated by bitbake to build the binaries locally, > so leave it for now. Is this detail really necessary for the commit message? > Signed-off-by: Andrew F. Davis > --- > recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb > index 3c0242e2..a1e35b52 100644 > --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb > +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb > @@ -3,9 +3,10 @@ HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux" > LICENSE = "TI-TSPA" > LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=b17390502bc89535c86cfbbae961a2a8" > > +PACKAGE_ARCH = "${MACHINE_ARCH}" > COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15|k3" > > -PACKAGE_ARCH = "${MACHINE_ARCH}" > +PR = "r33" > > BRANCH = "ti-img-sgx/thud/${PV}" > > @@ -22,11 +23,10 @@ INITSCRIPT_PARAMS = "defaults 8" > > inherit update-rc.d > > -PR = "r33" > PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm omap5-sgx-ddk-um-linux" > > -DEPENDS += "libdrm udev wayland libffi" > -RDEPENDS_${PN} += "libdrm libudev wayland libffi libdrm-omap" > +DEPENDS += "libdrm udev wayland libffi expat" > +RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland libffi expat" > > RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux" > RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev" > -- > 2.17.1 >