From: Sasha Levin <sashal@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Alessio Balsini <balsini@android.com>,
astrachan@google.com, maennich@google.com,
kernel-team@android.com, stable@vger.kernel.org
Subject: Re: [PATCH 4.9 1/2] um: Allow building and running on older hosts
Date: Wed, 24 Jul 2019 23:40:32 -0400 [thread overview]
Message-ID: <20190725034032.GA4099@sasha-vm> (raw)
In-Reply-To: <20190724120753.GH3244@kroah.com>
On Wed, Jul 24, 2019 at 02:07:53PM +0200, Greg KH wrote:
>On Mon, Jul 22, 2019 at 11:33:37AM +0100, Alessio Balsini wrote:
>> commit 0a987645672ebde7844a9c0732a5a25f3d4bb6c6 upstream.
>>
>> Commit a78ff1112263 ("um: add extended processor state save/restore
>> support") and b6024b21fec8 ("um: extend fpstate to _xstate to support
>> YMM registers") forced the use of the x86 FP _xstate and
>> PTRACE_GETREGSET/SETREGSET. On older hosts, we would neither be able to
>> build UML nor run it anymore with these two commits applied because we
>> don't have definitions for struct _xstate nor these two ptrace requests.
>>
>> We can determine at build time which fp context structure to check
>> against, just like we can keep using the old i387 fp save/restore if
>> PTRACE_GETRESET/SETREGSET are not defined.
>>
>> Fixes: a78ff1112263 ("um: add extended processor state save/restore support")
>> Fixes: b6024b21fec8 ("um: extend fpstate to _xstate to support YMM registers")
>> Change-Id: I2cda034c8a6637de392c2740a993982ad132bda5
>
>No need for change-id in upstream patches :)
>
>let me see if I can just take what is already in 4.13 directly...
Alessio,
Do we also need 2fb44600fe784 ("um: Fix check for _xstate for older
hosts")?
--
Thanks,
Sasha
prev parent reply other threads:[~2019-07-25 3:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 10:33 [PATCH 4.9 1/2] um: Allow building and running on older hosts Alessio Balsini
2019-07-22 10:33 ` [PATCH 4.9 2/2] um: Fix FP register size for XSTATE/XSAVE Alessio Balsini
2019-07-24 12:07 ` [PATCH 4.9 1/2] um: Allow building and running on older hosts Greg KH
2019-07-25 3:40 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725034032.GA4099@sasha-vm \
--to=sashal@kernel.org \
--cc=astrachan@google.com \
--cc=balsini@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=maennich@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.