From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Thu, 25 Jul 2019 07:16:35 +0000 Subject: Re: [RFC] Staging: fbtft: Typo in Message-Id: <20190725071635.GA17271@kroah.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: linux-fbdev@vger.kernel.org, Kernel Janitors , dri-devel@lists.freedesktop.org, nishadkamdar@gmail.com On Sun, Jul 21, 2019 at 08:54:39PM +0200, Christophe JAILLET wrote: > Hi, > > looking at the code in 'drivers/staging/fbtft/fb_pcd8544.c', there seems to > be some typos. > > At the end of the file, we can find: > > FBTFT_REGISTER_DRIVER(DRVNAME, "philips,pdc8544", &display); > ... > MODULE_ALIAS("spi:pdc8544"); > > > It is likely that the 2 pdc8544 should be pcd8544. (d and c switched) > > As I don't know the implication of such a change, I prefer to first report > the potential issue, before proposing a patch for it. Submit a patch, that's the best way to discuss it! thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [RFC] Staging: fbtft: Typo in Date: Thu, 25 Jul 2019 09:16:35 +0200 Message-ID: <20190725071635.GA17271@kroah.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F9E66E632 for ; Thu, 25 Jul 2019 07:16:39 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christophe JAILLET Cc: linux-fbdev@vger.kernel.org, Kernel Janitors , dri-devel@lists.freedesktop.org, nishadkamdar@gmail.com List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBKdWwgMjEsIDIwMTkgYXQgMDg6NTQ6MzlQTSArMDIwMCwgQ2hyaXN0b3BoZSBKQUlM TEVUIHdyb3RlOgo+IEhpLAo+IAo+IGxvb2tpbmcgYXQgdGhlIGNvZGUgaW4gJ2RyaXZlcnMvc3Rh Z2luZy9mYnRmdC9mYl9wY2Q4NTQ0LmMnLCB0aGVyZSBzZWVtcyB0bwo+IGJlIHNvbWUgdHlwb3Mu Cj4gCj4gQXQgdGhlIGVuZCBvZiB0aGUgZmlsZSwgd2UgY2FuIGZpbmQ6Cj4gCj4gRkJURlRfUkVH SVNURVJfRFJJVkVSKERSVk5BTUUsICJwaGlsaXBzLHBkYzg1NDQiLCAmZGlzcGxheSk7Cj4gLi4u Cj4gTU9EVUxFX0FMSUFTKCJzcGk6cGRjODU0NCIpOwo+IAo+IAo+IEl0IGlzIGxpa2VseSB0aGF0 IHRoZSAyIHBkYzg1NDQgc2hvdWxkIGJlIHBjZDg1NDQuIChkIGFuZCBjIHN3aXRjaGVkKQo+IAo+ IEFzIEkgZG9uJ3Qga25vdyB0aGUgaW1wbGljYXRpb24gb2Ygc3VjaCBhIGNoYW5nZSwgSSBwcmVm ZXIgdG8gZmlyc3QgcmVwb3J0Cj4gdGhlIHBvdGVudGlhbCBpc3N1ZSwgYmVmb3JlIHByb3Bvc2lu ZyBhIHBhdGNoIGZvciBpdC4KClN1Ym1pdCBhIHBhdGNoLCB0aGF0J3MgdGhlIGJlc3Qgd2F5IHRv IGRpc2N1c3MgaXQhCgp0aGFua3MsCgpncmVnIGstaApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWw=