From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilias Apalodimas Subject: Re: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool Date: Thu, 25 Jul 2019 14:39:22 +0300 Message-ID: <20190725113922.GA1703@apalos> References: <20190723.115112.1824255524103179323.davem@davemloft.net> <20190724085427.GA10736@apalos> <20190724095310.GA12991@apalos> <33de62bf-2f8a-bf00-9260-418b12bed24c@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jon Hunter Cc: Jose Abreu , David Miller , "robin.murphy@arm.com" , "lists@bofh.nu" , "Joao.Pinto@synopsys.com" , "alexandre.torgue@st.com" , "maxime.ripard@bootlin.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "wens@csie.org" , "mcoquelin.stm32@gmail.com" , "linux-tegra@vger.kernel.org" , "peppe.cavallaro@st.com" "linux-arm-kernel@lists.infradead.org" List-Id: linux-tegra@vger.kernel.org Hi Jon, Jose, On Thu, Jul 25, 2019 at 10:45:46AM +0100, Jon Hunter wrote: > > On 25/07/2019 08:44, Jose Abreu wrote: > > ... > > > OK. Can you please test what Ilias mentioned ? > > > > Basically you can hard-code the order to 0 in > > alloc_dma_rx_desc_resources(): > > - pp_params.order = DIV_ROUND_UP(priv->dma_buf_sz, PAGE_SIZE); > > + pp_params.order = 0; > > > > Unless you use a MTU > PAGE_SIZE. > > I made the change but unfortunately the issue persists. Yea tbh i didn't expect this to fix it, since i think the mappings are fine, but it never hurts to verify. @Jose: Can we add some debugging prints on the driver? Ideally the pages the api allocates (on init), the page that the driver is trying to use before the crash and the size of the packet (right from the device descriptor). Maybe this will tell us where the erroneous access is Thanks /Ilias From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A7AAC76191 for ; Thu, 25 Jul 2019 11:39:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53953229F9 for ; Thu, 25 Jul 2019 11:39:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IYaqR5PC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MAEDyrQN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53953229F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bFu7/5Wtml9N5HLe7wvqMYkHSgfZwZDUHCwL7ZgUCIs=; b=IYaqR5PCnz4G5C uD7wHQFZvtJEJHE3hH85D3K/rqYNSGTgVeEmRsICb7RoU8SPJTTszTmvTXSX18i6ZHnvrhokpu1Ck EeIHPKw+fX3EcEGHDgFinA5cm6riWAyM7UJLiAw1wslGpgI5p7w1yJJfm7lIUUpHGbTI4ebZ4ENtR uUEPZf60blWVth5jxeolAr0naPwwdI8ecagUaLocc1Eq9arLPinLOQQ9Haxh/RSqbEfLsH850fJH3 XooaJibTwf+ZvnVdA0SjTzUkAgrcco6dKx2aSWdkE9bzk3mXzolL6XSrl7q6bituLTm4mpJkdpyQo S0IOU4KKrhQmZ2XnDvrA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqc5r-0006gt-Nw; Thu, 25 Jul 2019 11:39:31 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqc5o-0006g2-V2 for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2019 11:39:30 +0000 Received: by mail-wm1-x342.google.com with SMTP id a15so44675453wmj.5 for ; Thu, 25 Jul 2019 04:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/KNocy2+ZfOQXTjSVoKpw5gYwyEUDk8UgKcJTP4ngYE=; b=MAEDyrQNT8xSuX9iSr/7BWAuVtiFFg0r91vvdxT2++HHJS9g3J0YPwvOtkJtKUq8Jv 5iKmWqJK52t0LH1sXJk3PO+C21INeHi4V/ZYW7YuPXVIBflnQMtUHe6awRTT5dvD1DaE WpfQIVfVij+bSGThMlicGuVLRiLpF6rqQwZpgSsW3OX9UHyDapWCYIrbuJner3poxc++ G0Bn8vzCLpCMRU3GuO3rYDre/AQ/pQH9pBaRn/BU0lkFmSiIGNMktCQBPARjaQkabMe+ GuF14I1ZfrdG7ZX9sunB4JjQ9JvX8MVHFeTldfj+sF04kvwCNlmOmMZTYqLm/phbk5K8 qnTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/KNocy2+ZfOQXTjSVoKpw5gYwyEUDk8UgKcJTP4ngYE=; b=HE1HnZN1BwhKpvRUt4qJNZlQjvIqYCQYmjVwA02i51MdAZtOA88QW2bI1t9waLkhXQ YXPMgCOKMQVyuserHn2GY+H33Ir+YqbpDK3BFugDGZtAQcJRdRB+Alr7ZhSMU/4gP5ua h1I0vWx1fHE1zQZ3JPlBVrU4fMMDMIkk4gf+5DOqj5tuJWXGcb1T9Tl6Z7pVdQKo1q8c yLkkacjmVY6V0dG7X1MOxoh24+dQJj2Mmqj7UTEC9VCB6abxJC37YZArOUtq/qB5bxHe An031nSnQ3JKXnZTW2HmqqjsWHSs6mOzdJXs4n1V/TA93c7uQPcyWH3HwEludz1/gCr5 hwkg== X-Gm-Message-State: APjAAAV93zA8RLtz0AWWTIDt28US36OKdb+bQXwCmsr57jbS8mW3O1PV Cci3Or03vnfo492ad7fjwyPaAg== X-Google-Smtp-Source: APXvYqxKToM60L7WegP6mEG3X3RaqPtSEAUsT9RXfSRetFr+Hk/NVm3V8WF2BD26TvV4TjAbT9vnuA== X-Received: by 2002:a7b:c5c2:: with SMTP id n2mr77541522wmk.92.1564054766915; Thu, 25 Jul 2019 04:39:26 -0700 (PDT) Received: from apalos (athedsl-373703.home.otenet.gr. [79.131.11.197]) by smtp.gmail.com with ESMTPSA id p6sm53195376wrq.97.2019.07.25.04.39.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 04:39:26 -0700 (PDT) Date: Thu, 25 Jul 2019 14:39:22 +0300 From: Ilias Apalodimas To: Jon Hunter Subject: Re: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool Message-ID: <20190725113922.GA1703@apalos> References: <20190723.115112.1824255524103179323.davem@davemloft.net> <20190724085427.GA10736@apalos> <20190724095310.GA12991@apalos> <33de62bf-2f8a-bf00-9260-418b12bed24c@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190725_043929_008098_CBEE5272 X-CRM114-Status: GOOD ( 14.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jose Abreu , "Joao.Pinto@synopsys.com" , "alexandre.torgue@st.com" , "maxime.ripard@bootlin.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "wens@csie.org" , "linux-arm-kernel@lists.infradead.org" , "mcoquelin.stm32@gmail.com" , "linux-tegra@vger.kernel.org" , "peppe.cavallaro@st.com" , "robin.murphy@arm.com" , David Miller , "lists@bofh.nu" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jon, Jose, On Thu, Jul 25, 2019 at 10:45:46AM +0100, Jon Hunter wrote: > > On 25/07/2019 08:44, Jose Abreu wrote: > > ... > > > OK. Can you please test what Ilias mentioned ? > > > > Basically you can hard-code the order to 0 in > > alloc_dma_rx_desc_resources(): > > - pp_params.order = DIV_ROUND_UP(priv->dma_buf_sz, PAGE_SIZE); > > + pp_params.order = 0; > > > > Unless you use a MTU > PAGE_SIZE. > > I made the change but unfortunately the issue persists. Yea tbh i didn't expect this to fix it, since i think the mappings are fine, but it never hurts to verify. @Jose: Can we add some debugging prints on the driver? Ideally the pages the api allocates (on init), the page that the driver is trying to use before the crash and the size of the packet (right from the device descriptor). Maybe this will tell us where the erroneous access is Thanks /Ilias _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F29A4C7618B for ; Thu, 25 Jul 2019 11:39:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4D2C229F9 for ; Thu, 25 Jul 2019 11:39:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MAEDyrQN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404122AbfGYLj3 (ORCPT ); Thu, 25 Jul 2019 07:39:29 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:35226 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389593AbfGYLj3 (ORCPT ); Thu, 25 Jul 2019 07:39:29 -0400 Received: by mail-wm1-f66.google.com with SMTP id l2so44424059wmg.0 for ; Thu, 25 Jul 2019 04:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/KNocy2+ZfOQXTjSVoKpw5gYwyEUDk8UgKcJTP4ngYE=; b=MAEDyrQNT8xSuX9iSr/7BWAuVtiFFg0r91vvdxT2++HHJS9g3J0YPwvOtkJtKUq8Jv 5iKmWqJK52t0LH1sXJk3PO+C21INeHi4V/ZYW7YuPXVIBflnQMtUHe6awRTT5dvD1DaE WpfQIVfVij+bSGThMlicGuVLRiLpF6rqQwZpgSsW3OX9UHyDapWCYIrbuJner3poxc++ G0Bn8vzCLpCMRU3GuO3rYDre/AQ/pQH9pBaRn/BU0lkFmSiIGNMktCQBPARjaQkabMe+ GuF14I1ZfrdG7ZX9sunB4JjQ9JvX8MVHFeTldfj+sF04kvwCNlmOmMZTYqLm/phbk5K8 qnTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/KNocy2+ZfOQXTjSVoKpw5gYwyEUDk8UgKcJTP4ngYE=; b=Kq8KajqyW7XTP8nrhGG3UT706FGX2E6AouLhtWogBBlBL4gP5JX145taREElR+C8W5 xBAosRxd0y5XV1dnj+jDXCxINztd01NDwQCf0xQ7Dz1Ij0B5qJcER2gY++MHqXKpVwrr N26Pgx1rzXD3EjPpSpSz8/jd/fRCM7ZqWK3qJefR/qnprqG3caE8igDmVJGMQtiYthY+ ffwxVRfIW8izLVdLEJOeY+lwFbICqFBQye+ZDNd3lWVEvJbweYjQ7JI++ICHTBd7ZQU/ MvrPKUgVtSVvd0Q80Pmqct7bpQ+GgOkdIeQ0IX0D+WcB8ozuj/2/66yuvGI1FnJVHZts K5bQ== X-Gm-Message-State: APjAAAUEe4GK4duVRL2hxn3+7Ec4dEpVkiZOv/CGJPyjqE+g9oUj1wMp nqk4fUD77m/10UbFLpZGLy29xbeIta8= X-Google-Smtp-Source: APXvYqxKToM60L7WegP6mEG3X3RaqPtSEAUsT9RXfSRetFr+Hk/NVm3V8WF2BD26TvV4TjAbT9vnuA== X-Received: by 2002:a7b:c5c2:: with SMTP id n2mr77541522wmk.92.1564054766915; Thu, 25 Jul 2019 04:39:26 -0700 (PDT) Received: from apalos (athedsl-373703.home.otenet.gr. [79.131.11.197]) by smtp.gmail.com with ESMTPSA id p6sm53195376wrq.97.2019.07.25.04.39.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 04:39:26 -0700 (PDT) Date: Thu, 25 Jul 2019 14:39:22 +0300 From: Ilias Apalodimas To: Jon Hunter Cc: Jose Abreu , David Miller , "robin.murphy@arm.com" , "lists@bofh.nu" , "Joao.Pinto@synopsys.com" , "alexandre.torgue@st.com" , "maxime.ripard@bootlin.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "wens@csie.org" , "mcoquelin.stm32@gmail.com" , "linux-tegra@vger.kernel.org" , "peppe.cavallaro@st.com" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool Message-ID: <20190725113922.GA1703@apalos> References: <20190723.115112.1824255524103179323.davem@davemloft.net> <20190724085427.GA10736@apalos> <20190724095310.GA12991@apalos> <33de62bf-2f8a-bf00-9260-418b12bed24c@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jon, Jose, On Thu, Jul 25, 2019 at 10:45:46AM +0100, Jon Hunter wrote: > > On 25/07/2019 08:44, Jose Abreu wrote: > > ... > > > OK. Can you please test what Ilias mentioned ? > > > > Basically you can hard-code the order to 0 in > > alloc_dma_rx_desc_resources(): > > - pp_params.order = DIV_ROUND_UP(priv->dma_buf_sz, PAGE_SIZE); > > + pp_params.order = 0; > > > > Unless you use a MTU > PAGE_SIZE. > > I made the change but unfortunately the issue persists. Yea tbh i didn't expect this to fix it, since i think the mappings are fine, but it never hurts to verify. @Jose: Can we add some debugging prints on the driver? Ideally the pages the api allocates (on init), the page that the driver is trying to use before the crash and the size of the packet (right from the device descriptor). Maybe this will tell us where the erroneous access is Thanks /Ilias