From: Christoph Hellwig <hch@infradead.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Christoph Hellwig <hch@infradead.org>,
John Stultz <john.stultz@linaro.org>,
lkml <linux-kernel@vger.kernel.org>,
Laura Abbott <labbott@redhat.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Liam Mark <lmark@codeaurora.org>,
Pratik Patel <pratikp@codeaurora.org>,
Brian Starkey <Brian.Starkey@arm.com>,
Vincent Donnefort <Vincent.Donnefort@arm.com>,
Sudipto Paul <Sudipto.Paul@arm.com>,
Xu YiPing <xuyiping@hisilicon.com>,
"Chenfeng (puck)" <puck.chen@hisilicon.com>,
butao <butao@hisilicon.com>,
"Xiaqing (A)" <saberlily.xia@hisilicon.com>,
Yudongbin <yudongbin@hisilicon.com>,
Chenbo Feng <fengc@google.com>,
Alistair Strachan <astrachan@google.com>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps
Date: Thu, 25 Jul 2019 05:50:14 -0700 [thread overview]
Message-ID: <20190725125014.GD20286@infradead.org> (raw)
In-Reply-To: <8e6f8e4f-20fc-1f1f-2228-f4fd7c7c5c1f@ti.com>
On Wed, Jul 24, 2019 at 11:46:01AM -0400, Andrew F. Davis wrote:
> https://patchwork.kernel.org/patch/10863957/
>
> It's actually a more simple heap type IMHO, but the logic inside is
> incompatible with the system/CMA heaps, if you move any of their code
> into the core framework then this heap stops working. Leading to out of
> tree hacks on the core to get it back functional. I see the same for the
> "complex" heaps with ION.
Well, this mostly is just another allocator (gen_pool). And given that
the whole dma-buf infrastucture assumes things are backed by pages we
really shouldn't need much more than an alloc and a free callback (and
maybe the pgprot to map it) and handle the rest in common code.
next prev parent reply other threads:[~2019-07-25 12:50 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 19:49 [PATCH v6 0/5] DMA-BUF Heaps (destaging ION) John Stultz
2019-06-24 19:49 ` [PATCH v6 1/5] dma-buf: Add dma-buf heaps framework John Stultz
2019-06-24 19:49 ` [PATCH v6 2/5] dma-buf: heaps: Add heap helpers John Stultz
2019-06-24 19:49 ` John Stultz
2019-07-18 10:06 ` Christoph Hellwig
2019-07-23 4:09 ` John Stultz
2019-07-23 4:09 ` John Stultz
2019-07-23 20:09 ` Rob Clark
2019-07-23 20:09 ` Rob Clark
2019-07-24 6:55 ` Christoph Hellwig
2019-07-24 6:55 ` Christoph Hellwig
2019-07-24 15:20 ` Andrew F. Davis
2019-07-24 15:20 ` Andrew F. Davis
2019-07-25 12:41 ` Christoph Hellwig
2019-07-25 12:41 ` Christoph Hellwig
2019-07-25 15:23 ` Rob Clark
2019-07-25 15:23 ` Rob Clark
2019-07-24 6:58 ` Christoph Hellwig
2019-07-24 6:58 ` Christoph Hellwig
2019-06-24 19:49 ` [PATCH v6 3/5] dma-buf: heaps: Add system heap to dmabuf heaps John Stultz
2019-06-24 19:49 ` [PATCH v6 4/5] dma-buf: heaps: Add CMA " John Stultz
2019-07-18 10:08 ` Christoph Hellwig
2019-07-23 5:04 ` John Stultz
2019-07-23 5:04 ` John Stultz
2019-07-24 6:59 ` Christoph Hellwig
2019-07-24 8:08 ` Benjamin Gaignard
2019-07-25 12:45 ` Christoph Hellwig
2019-07-24 11:38 ` Laura Abbott
2019-07-25 12:48 ` Christoph Hellwig
2019-07-25 13:47 ` Andrew F. Davis
2019-07-25 13:47 ` Andrew F. Davis
2019-07-25 14:05 ` Christoph Hellwig
2019-07-24 15:46 ` Andrew F. Davis
2019-07-25 12:50 ` Christoph Hellwig [this message]
2019-07-25 13:31 ` Andrew F. Davis
2019-07-25 13:31 ` Andrew F. Davis
2019-07-25 14:04 ` Christoph Hellwig
2019-07-25 14:10 ` Andrew F. Davis
2019-07-25 14:11 ` Christoph Hellwig
2019-07-25 14:25 ` Andrew F. Davis
2019-07-25 14:30 ` Christoph Hellwig
2019-07-25 14:51 ` Andrew F. Davis
2019-07-25 14:51 ` Andrew F. Davis
2019-07-24 18:46 ` John Stultz
2019-07-24 18:46 ` John Stultz
2019-07-25 12:52 ` Christoph Hellwig
2019-07-25 13:20 ` Benjamin Gaignard
2019-07-25 14:33 ` Christoph Hellwig
2019-07-25 14:46 ` Benjamin Gaignard
2019-06-24 19:49 ` [PATCH v6 5/5] kselftests: Add dma-heap test John Stultz
2019-06-24 19:49 ` John Stultz
2019-07-01 21:45 ` [PATCH v6 0/5] DMA-BUF Heaps (destaging ION) Laura Abbott
2019-07-01 21:55 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725125014.GD20286@infradead.org \
--to=hch@infradead.org \
--cc=Brian.Starkey@arm.com \
--cc=Sudipto.Paul@arm.com \
--cc=Vincent.Donnefort@arm.com \
--cc=afd@ti.com \
--cc=astrachan@google.com \
--cc=benjamin.gaignard@linaro.org \
--cc=butao@hisilicon.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fengc@google.com \
--cc=john.stultz@linaro.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lmark@codeaurora.org \
--cc=pratikp@codeaurora.org \
--cc=puck.chen@hisilicon.com \
--cc=saberlily.xia@hisilicon.com \
--cc=sumit.semwal@linaro.org \
--cc=xuyiping@hisilicon.com \
--cc=yudongbin@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.