From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
kernel@collabora.com, linux-media@vger.kernel.org
Subject: Re: [PATCH 2/6] media: v4l2-core: Module re-organization
Date: Thu, 25 Jul 2019 13:31:37 -0300 [thread overview]
Message-ID: <20190725133137.4a99dc05@coco.lan> (raw)
In-Reply-To: <20190715210649.31681-3-ezequiel@collabora.com>
Em Mon, 15 Jul 2019 18:06:43 -0300
Ezequiel Garcia <ezequiel@collabora.com> escreveu:
> videodev.ko and v4l2-common.ko driver are built under
> the same conditions. Therefore, it doesn't make much sense
> to split them in two different modules.
>
> Splitting v4l2-common to its own driver has done many
> years ago:
>
> commit a9254475bbfbed5f0596d952c6a3c9806e19dd0b
> Author: Mauro Carvalho Chehab <mchehab@infradead.org>
> Date: Tue Jan 29 18:32:35 2008 -0300
>
> V4L/DVB (7115): Fix bug #9833: regression when compiling V4L without I2C
>
> Back then, the subsystem organization was different.
> However, With the current organization, there is no issue
> compiling V4L2 with I2C as y/m/n.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
> drivers/media/v4l2-core/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/Makefile b/drivers/media/v4l2-core/Makefile
> index 4d42418e603e..8e2f52f7800b 100644
> --- a/drivers/media/v4l2-core/Makefile
> +++ b/drivers/media/v4l2-core/Makefile
> @@ -7,14 +7,13 @@ tuner-objs := tuner-core.o
>
> videodev-objs := v4l2-dev.o v4l2-ioctl.o v4l2-device.o v4l2-fh.o \
> v4l2-event.o v4l2-ctrls.o v4l2-subdev.o v4l2-clk.o \
> - v4l2-async.o
> + v4l2-async.o v4l2-common.o
> videodev-$(CONFIG_COMPAT) += v4l2-compat-ioctl32.o
> videodev-$(CONFIG_TRACEPOINTS) += v4l2-trace.o
> videodev-$(CONFIG_MEDIA_CONTROLLER) += v4l2-mc.o
>
> obj-$(CONFIG_V4L2_FWNODE) += v4l2-fwnode.o
> obj-$(CONFIG_VIDEO_V4L2) += videodev.o
> -obj-$(CONFIG_VIDEO_V4L2) += v4l2-common.o
> obj-$(CONFIG_VIDEO_V4L2) += v4l2-dv-timings.o
>
> obj-$(CONFIG_VIDEO_TUNER) += tuner.o
Huh? This patch sounds incomplete... Where are you removing the
MODULE_foo macros) from v4l2-common.c?
Thanks,
Mauro
next prev parent reply other threads:[~2019-07-25 16:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 21:06 [PATCH 0/6] V4L2 core I2C/SPI code cleanup Ezequiel Garcia
2019-07-15 21:06 ` [PATCH 1/6] media: v4l2-core: Cleanup Makefile Ezequiel Garcia
2019-07-15 21:06 ` [PATCH 2/6] media: v4l2-core: Module re-organization Ezequiel Garcia
2019-07-25 16:31 ` Mauro Carvalho Chehab [this message]
2019-07-25 16:41 ` Ezequiel Garcia
2019-07-25 17:03 ` Mauro Carvalho Chehab
2019-07-25 17:07 ` Ezequiel Garcia
2019-07-15 21:06 ` [PATCH 3/6] media: v4l2-core: move spi helpers out of v4l2-common.c Ezequiel Garcia
2019-07-15 21:06 ` [PATCH 4/6] media: v4l2-core: move i2c " Ezequiel Garcia
2019-07-15 21:06 ` [PATCH 5/6] media: v4l2-core: introduce a helper to unregister a SPI subdev Ezequiel Garcia
2019-07-15 21:06 ` [PATCH 5/6] media: v4l2-core: introduce an unregister spi subdev helper Ezequiel Garcia
2019-07-15 21:06 ` [PATCH 6/6] media: v4l2-core: introduce a helper to unregister a I2C subdev Ezequiel Garcia
2019-07-15 21:06 ` [PATCH 6/6] media: v4l2-core: introduce unregister subdev i2c helper Ezequiel Garcia
2019-07-25 15:06 ` [PATCH 0/6] V4L2 core I2C/SPI code cleanup Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725133137.4a99dc05@coco.lan \
--to=mchehab+samsung@kernel.org \
--cc=ezequiel@collabora.com \
--cc=hans.verkuil@cisco.com \
--cc=kernel@collabora.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.