All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>,
	jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: intel-lpss: Remove D3cold delay
Date: Thu, 25 Jul 2019 16:42:48 +0300	[thread overview]
Message-ID: <20190725134248.GC9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190725120554.GE23883@dell>

On Thu, Jul 25, 2019 at 01:05:54PM +0100, Lee Jones wrote:
> On Tue, 09 Jul 2019, Andy Shevchenko wrote:
> 
> > On Fri, Jul 05, 2019 at 12:55:03PM +0800, Kai-Heng Feng wrote:
> > > Goodix touchpad may drop its first couple input events when
> > > i2c-designware-platdrv and intel-lpss it connects to took too long to
> > > runtime resume from runtime suspended state.
> > > 
> > > This issue happens becuase the touchpad has a rather small buffer to
> > > store up to 13 input events, so if the host doesn't read those events in
> > > time (i.e. runtime resume takes too long), events are dropped from the
> > > touchpad's buffer.
> > > 
> > > The bottleneck is D3cold delay it waits when transitioning from D3cold
> > > to D0, hence remove the delay to make the resume faster. I've tested
> > > some systems with intel-lpss and haven't seen any regression.
> > 
> > Thank you for the patch. I took it to our internal testing and will tell
> > the result within couple of weeks.
> 
> Any news?

No bug reports, no negative feedback, I think we may proceed with it.
Thanks!

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2019-07-25 13:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05  4:55 [PATCH] mfd: intel-lpss: Remove D3cold delay Kai-Heng Feng
2019-07-09 11:46 ` Andy Shevchenko
2019-07-25 12:05   ` Lee Jones
2019-07-25 13:42     ` Andy Shevchenko [this message]
2019-07-25 13:43 ` Andy Shevchenko
2019-08-12  8:12 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190725134248.GC9224@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.