Re: [RFC PATCH 3/4] btrfs: use xxhash64 for checksumming

[Johannes Thumshirn <jthumshirn@suse.de>]

On Thu, Jul 25, 2019 at 08:02:12PM +0800, Qu Wenruo wrote:
> 
> 
> On 2019/7/25 下午5:33, Johannes Thumshirn wrote:
> > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> > ---
> >  fs/btrfs/Kconfig                | 1 +
> >  fs/btrfs/ctree.h                | 1 +
> >  fs/btrfs/disk-io.c              | 1 +
> >  fs/btrfs/super.c                | 1 +
> >  include/uapi/linux/btrfs_tree.h | 1 +
> >  5 files changed, 5 insertions(+)
> > 
> > diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
> > index 38651fae7f21..6d5a01c57da3 100644
> > --- a/fs/btrfs/Kconfig
> > +++ b/fs/btrfs/Kconfig
> > @@ -5,6 +5,7 @@ config BTRFS_FS
> >  	select CRYPTO
> >  	select CRYPTO_CRC32C
> >  	select LIBCRC32C
> > +	select CRYPTO_XXHASH
> 
> Just an off topic idea, can we make such CRYPTO_* support configurable?
> E.g. make something like CONFIG_BTRFS_CRYPTO_XXHASH.
> 
> Not sure if everyone would like to pull all hash algorithm.
 
This is something I thought about as well, but I was afraid of people shooting
themselves in the foot if they forget to switch them on and mkfs with the
wrong option.

Not sure what's the better way here? Dave?

-- 
Johannes Thumshirn                            SUSE Labs Filesystems
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850