From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Thu, 25 Jul 2019 15:06:29 +0000 Subject: Re: [PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support Message-Id: <20190725150629.GN23883@dell> List-Id: References: <20190725143224.GB31803@ravnborg.org> <20190725143934.GH15868@phenom.ffwll.local> In-Reply-To: <20190725143934.GH15868@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Daniel Vetter Cc: Daniel Thompson , Bartlomiej Zolnierkiewicz , Daniel Vetter , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Gerd Hoffmann , Jingoo Han , Sam Ravnborg , Peter Rosin On Thu, 25 Jul 2019, Daniel Vetter wrote: > On Thu, Jul 25, 2019 at 04:32:24PM +0200, Sam Ravnborg wrote: > > There was no users left - so drop the code to support EARLY_FB_BLANK. > > This patch removes the support in backlight, > > and drop the notifier in fbmem. > > > > That EARLY_FB_BLANK is not used can be verified that no driver set any of: > > > > lcd_ops.early_set_power() > > lcd_ops.r_early_set_power() > > > > Noticed while browsing backlight code for other reasons. > > Ah I didn't grep hard enough, I didn't realize that no one sets the > lcd_ops->(r_)early_set_power hooks. Nice find! > > Reviewed-by: Daniel Vetter > > > Signed-off-by: Sam Ravnborg > > Cc: Lee Jones > > Cc: Daniel Thompson > > Cc: Jingoo Han > > Cc: Bartlomiej Zolnierkiewicz > > Cc: Daniel Vetter > > Cc: Sam Ravnborg > > Cc: Maarten Lankhorst > > Cc: "Michał Mirosław" > > Cc: Peter Rosin > > Cc: Gerd Hoffmann > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-fbdev@vger.kernel.org > > --- > > > > Build tested with various architectures, configs. > > > > Lee, Daniel - OK to commit to drm-misc-next where fbdev stuff is > > maintained today? > > backlight is separate from fbdev in Lee's own tree, not in drm-misc. I > think at least. That's correct. We'll sort that once we have all the Acks. > > drivers/video/backlight/lcd.c | 8 -------- > > drivers/video/fbdev/core/fbmem.c | 12 +----------- > > include/linux/fb.h | 4 ---- > > include/linux/lcd.h | 10 ---------- > > 4 files changed, 1 insertion(+), 33 deletions(-) -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support Date: Thu, 25 Jul 2019 16:06:29 +0100 Message-ID: <20190725150629.GN23883@dell> References: <20190725143224.GB31803@ravnborg.org> <20190725143934.GH15868@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 146486E65E for ; Thu, 25 Jul 2019 15:06:44 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id a15so45325051wmj.5 for ; Thu, 25 Jul 2019 08:06:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190725143934.GH15868@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Thompson , Bartlomiej Zolnierkiewicz , Daniel Vetter , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Gerd Hoffmann , Jingoo Han , Sam Ravnborg , Peter Rosin List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyNSBKdWwgMjAxOSwgRGFuaWVsIFZldHRlciB3cm90ZToKCj4gT24gVGh1LCBKdWwg MjUsIDIwMTkgYXQgMDQ6MzI6MjRQTSArMDIwMCwgU2FtIFJhdm5ib3JnIHdyb3RlOgo+ID4gVGhl cmUgd2FzIG5vIHVzZXJzIGxlZnQgLSBzbyBkcm9wIHRoZSBjb2RlIHRvIHN1cHBvcnQgRUFSTFlf RkJfQkxBTksuCj4gPiBUaGlzIHBhdGNoIHJlbW92ZXMgdGhlIHN1cHBvcnQgaW4gYmFja2xpZ2h0 LAo+ID4gYW5kIGRyb3AgdGhlIG5vdGlmaWVyIGluIGZibWVtLgo+ID4gCj4gPiBUaGF0IEVBUkxZ X0ZCX0JMQU5LIGlzIG5vdCB1c2VkIGNhbiBiZSB2ZXJpZmllZCB0aGF0IG5vIGRyaXZlciBzZXQg YW55IG9mOgo+ID4gCj4gPiAgICAgbGNkX29wcy5lYXJseV9zZXRfcG93ZXIoKQo+ID4gICAgIGxj ZF9vcHMucl9lYXJseV9zZXRfcG93ZXIoKQo+ID4gCj4gPiBOb3RpY2VkIHdoaWxlIGJyb3dzaW5n IGJhY2tsaWdodCBjb2RlIGZvciBvdGhlciByZWFzb25zLgo+IAo+IEFoIEkgZGlkbid0IGdyZXAg aGFyZCBlbm91Z2gsIEkgZGlkbid0IHJlYWxpemUgdGhhdCBubyBvbmUgc2V0cyB0aGUKPiBsY2Rf b3BzLT4ocl8pZWFybHlfc2V0X3Bvd2VyIGhvb2tzLiBOaWNlIGZpbmQhCj4gCj4gUmV2aWV3ZWQt Ynk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gCj4gPiBTaWduZWQt b2ZmLWJ5OiBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+Cj4gPiBDYzogTGVlIEpvbmVz IDxsZWUuam9uZXNAbGluYXJvLm9yZz4KPiA+IENjOiBEYW5pZWwgVGhvbXBzb24gPGRhbmllbC50 aG9tcHNvbkBsaW5hcm8ub3JnPgo+ID4gQ2M6IEppbmdvbyBIYW4gPGppbmdvb2hhbjFAZ21haWwu Y29tPgo+ID4gQ2M6IEJhcnRsb21pZWogWm9sbmllcmtpZXdpY3ogPGIuem9sbmllcmtpZUBzYW1z dW5nLmNvbT4KPiA+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ ID4gQ2M6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4KPiA+IENjOiBNYWFydGVuIExh bmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ID4gQ2M6ICJNaWNo YcWCIE1pcm9zxYJhdyIgPG1pcnEtbGludXhAcmVyZS5xbXFtLnBsPgo+ID4gQ2M6IFBldGVyIFJv c2luIDxwZWRhQGF4ZW50aWEuc2U+Cj4gPiBDYzogR2VyZCBIb2ZmbWFubiA8a3JheGVsQHJlZGhh dC5jb20+Cj4gPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gQ2M6IGxp bnV4LWZiZGV2QHZnZXIua2VybmVsLm9yZwo+ID4gLS0tCj4gPiAKPiA+IEJ1aWxkIHRlc3RlZCB3 aXRoIHZhcmlvdXMgYXJjaGl0ZWN0dXJlcywgY29uZmlncy4KPiA+IAo+ID4gTGVlLCBEYW5pZWwg LSBPSyB0byBjb21taXQgdG8gZHJtLW1pc2MtbmV4dCB3aGVyZSBmYmRldiBzdHVmZiBpcwo+ID4g bWFpbnRhaW5lZCB0b2RheT8KPiAKPiBiYWNrbGlnaHQgaXMgc2VwYXJhdGUgZnJvbSBmYmRldiBp biBMZWUncyBvd24gdHJlZSwgbm90IGluIGRybS1taXNjLiBJCj4gdGhpbmsgYXQgbGVhc3QuCgpU aGF0J3MgY29ycmVjdC4gIFdlJ2xsIHNvcnQgdGhhdCBvbmNlIHdlIGhhdmUgYWxsIHRoZSBBY2tz LgoKPiA+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9sY2QuYyAgICB8ICA4IC0tLS0tLS0tCj4g PiAgZHJpdmVycy92aWRlby9mYmRldi9jb3JlL2ZibWVtLmMgfCAxMiArLS0tLS0tLS0tLS0KPiA+ ICBpbmNsdWRlL2xpbnV4L2ZiLmggICAgICAgICAgICAgICB8ICA0IC0tLS0KPiA+ICBpbmNsdWRl L2xpbnV4L2xjZC5oICAgICAgICAgICAgICB8IDEwIC0tLS0tLS0tLS0KPiA+ICA0IGZpbGVzIGNo YW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAzMyBkZWxldGlvbnMoLSkKCi0tIApMZWUgSm9uZXMgW+ad jueQvOaWr10KTGluYXJvIFNlcnZpY2VzIFRlY2huaWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9w ZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8 IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbA==