From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 655A6C7618B for ; Fri, 26 Jul 2019 12:38:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 42BB921951 for ; Fri, 26 Jul 2019 12:38:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726808AbfGZMiZ (ORCPT ); Fri, 26 Jul 2019 08:38:25 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:42302 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726391AbfGZMiY (ORCPT ); Fri, 26 Jul 2019 08:38:24 -0400 Received: by mail-qt1-f196.google.com with SMTP id h18so52397160qtm.9 for ; Fri, 26 Jul 2019 05:38:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=7AAahzA3S5OmAp3WHwhPen11x5qmdYBmT/Y66i6DKGs=; b=g8la0kkoe2wucU899VOj2VUVQPkNch4G1/sI0CoPKDHpgRCtjHB/6o8YgeyzSUFgNg 5N74RmCJJ764sx/3NbJrtea8bqopJJQNxh1Bdu7s10MbFDkUWYrBV2MZmuj6Z3XUvsA+ VwQ902CsEJX9jL/bE7Ly5OVpq0bidqKr5mydckY4kRCh6rFUD/hpgHf2ykVssjL5rE1H I1FW+xrJzWaHVk6z33Ior94D4LpdPrB1JNVlIltVVdr2nSBqkvRXqO5M6iZcS51r9u/c sLW9NcjvqQjMM8pip3w4lMbrU2IRSlNulPFhXev0XADS2x91TG3iGv+qPuDVkl9atC9l sFcw== X-Gm-Message-State: APjAAAVI7r8ypC7CogcuUZ1apEcKcqcfv5eVTR0yXoMyVcp3UtrtZV3C dhEXBH+IRjUpauRIqped0siSMg== X-Google-Smtp-Source: APXvYqzmq5+4vWxaDwMY+05UXlQp7huBRpq3YhuBZEQ2PajFPNo/CMYsaRV1rBY4ljt21ew7Zf/M7w== X-Received: by 2002:ac8:37b8:: with SMTP id d53mr65290476qtc.227.1564144703827; Fri, 26 Jul 2019 05:38:23 -0700 (PDT) Received: from redhat.com ([212.92.104.165]) by smtp.gmail.com with ESMTPSA id v7sm25082729qte.86.2019.07.26.05.38.16 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 05:38:23 -0700 (PDT) Date: Fri, 26 Jul 2019 08:38:13 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: syzbot , aarcange@redhat.com, akpm@linux-foundation.org, christian@brauner.io, davem@davemloft.net, ebiederm@xmission.com, elena.reshetova@intel.com, guro@fb.com, hch@infradead.org, james.bottomley@hansenpartnership.com, jglisse@redhat.com, keescook@chromium.org, ldv@altlinux.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, luto@amacapital.net, mhocko@suse.com, mingo@kernel.org, namit@vmware.com, peterz@infradead.org, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk, wad@chromium.org Subject: Re: WARNING in __mmdrop Message-ID: <20190726082837-mutt-send-email-mst@kernel.org> References: <20190723051828-mutt-send-email-mst@kernel.org> <20190725012149-mutt-send-email-mst@kernel.org> <55e8930c-2695-365f-a07b-3ad169654d28@redhat.com> <20190725042651-mutt-send-email-mst@kernel.org> <84bb2e31-0606-adff-cf2a-e1878225a847@redhat.com> <20190725092332-mutt-send-email-mst@kernel.org> <11802a8a-ce41-f427-63d5-b6a4cf96bb3f@redhat.com> <20190726074644-mutt-send-email-mst@kernel.org> <5cc94f15-b229-a290-55f3-8295266edb2b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5cc94f15-b229-a290-55f3-8295266edb2b@redhat.com> Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Fri, Jul 26, 2019 at 08:00:58PM +0800, Jason Wang wrote: > > On 2019/7/26 下午7:49, Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2019 at 10:25:25PM +0800, Jason Wang wrote: > > > On 2019/7/25 下午9:26, Michael S. Tsirkin wrote: > > > > > Exactly, and that's the reason actually I use synchronize_rcu() there. > > > > > > > > > > So the concern is still the possible synchronize_expedited()? > > > > I think synchronize_srcu_expedited. > > > > > > > > synchronize_expedited sends lots of IPI and is bad for realtime VMs. > > > > > > > > > Can I do this > > > > > on through another series on top of the incoming V2? > > > > > > > > > > Thanks > > > > > > > > > The question is this: is this still a gain if we switch to the > > > > more expensive srcu? If yes then we can keep the feature on, > > > > > > I think we only care about the cost on srcu_read_lock() which looks pretty > > > tiny form my point of view. Which is basically a READ_ONCE() + WRITE_ONCE(). > > > > > > Of course I can benchmark to see the difference. > > > > > > > > > > if not we'll put it off until next release and think > > > > of better solutions. rcu->srcu is just a find and replace, > > > > don't see why we need to defer that. can be a separate patch > > > > for sure, but we need to know how well it works. > > > > > > I think I get here, let me try to do that in V2 and let's see the numbers. > > > > > > Thanks > > > It looks to me for tree rcu, its srcu_read_lock() have a mb() which is too > expensive for us. I will try to ponder using vq lock in some way. Maybe with trylock somehow ... > If we just worry about the IPI, With synchronize_rcu what I would worry about is that guest is stalled because system is busy because of other guests. With expedited it's the IPIs... > can we do something like in > vhost_invalidate_vq_start()? > >         if (map) { >                 /* In order to avoid possible IPIs with >                  * synchronize_rcu_expedited() we use call_rcu() + >                  * completion. > */ > init_completion(&c.completion); >                 call_rcu(&c.rcu_head, vhost_finish_vq_invalidation); > wait_for_completion(&c.completion); >                 vhost_set_map_dirty(vq, map, index); > vhost_map_unprefetch(map); >         } > > ? Why would that be faster than synchronize_rcu? > > > There's one other thing that bothers me, and that is that > > for large rings which are not physically contiguous > > we don't implement the optimization. > > > > For sure, that can wait, but I think eventually we should > > vmap large rings. > > > Yes, worth to try. But using direct map has its own advantage: it can use > hugepage that vmap can't > > Thanks Sure, so we can do that for small rings. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E86C7618B for ; Fri, 26 Jul 2019 12:38:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5711C22BEF for ; Fri, 26 Jul 2019 12:38:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bjoS2TPX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5711C22BEF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0qnva7Je+v7mK5Sxm2TT/3I2MBYE3wtaARJqK50pphs=; b=bjoS2TPXc83JZ2 097tGxNX4YqCUHbVoA/X6Blfcg0VWjqM1lrqk8rerfYrGtmWbeUxsENTWEmFuDquTOhQjKD9ZHt1o KCT0srKBvAopdYb7KcPY9C5qk5kFMHAC4twEYTH81yiwLJCBTW4SoAl2CrMiSXH+JYFlA63Tlm4+7 k7VhuaNOb80QlI/vXRwU7tnIqpISoaTKU10MsRa4NLU1FFbpxetxxnOvR/LTi9nK5tk2G+D5hj7IR CkmU7eDrVenzvyA5Alv4u1akwJmGvT8kaH+9Pdor2NVGvMM0hO2a447TF+gnm4IHtsY5ouw7REjCv j1FVuyZoWEXqZj8GhN6g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqzUR-00005p-Mw; Fri, 26 Jul 2019 12:38:27 +0000 Received: from mail-qt1-f194.google.com ([209.85.160.194]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqzUO-00005A-Uf for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2019 12:38:26 +0000 Received: by mail-qt1-f194.google.com with SMTP id w17so8076042qto.10 for ; Fri, 26 Jul 2019 05:38:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=7AAahzA3S5OmAp3WHwhPen11x5qmdYBmT/Y66i6DKGs=; b=iVMIhhnMb+AKZHvGD/VeiktvQmZmhASxRBKlMqg/qV5wGM8JfpAMGfoPnP9R7RJyCj cGrJQldbDbsUPmFsiPwbrDLgA3QcKObxQrqlqRlb3IZHbA+anyTffIJgWPgxvLnD9omV S8A36S2wn4p6/2QR3f+iUdly6yHKRGC24ZsB6u8JKKN91u87RohsSJg/iqYWmVMrOVmT xUsRTqNd6MC8yC2yWpVmfwSs8MtRWCqGu2Yt8D7zCzwnkEkZPLb+ocDqflwwniIFmyBy 6aMJBPmFIVyiJdTzrkV0Sv6II11YJGHx4+o5+4kudfE/u+LGzZswfQB+r5G5O6WKNWVQ 78HA== X-Gm-Message-State: APjAAAXFdzFLqjXrLvpdgVBeyyYM5KJlYHvgKmCE0LHdSAKjBmHkY+mg Mx4fiSglTDaHYo//r/Xbi5hDVA== X-Google-Smtp-Source: APXvYqzmq5+4vWxaDwMY+05UXlQp7huBRpq3YhuBZEQ2PajFPNo/CMYsaRV1rBY4ljt21ew7Zf/M7w== X-Received: by 2002:ac8:37b8:: with SMTP id d53mr65290476qtc.227.1564144703827; Fri, 26 Jul 2019 05:38:23 -0700 (PDT) Received: from redhat.com ([212.92.104.165]) by smtp.gmail.com with ESMTPSA id v7sm25082729qte.86.2019.07.26.05.38.16 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 05:38:23 -0700 (PDT) Date: Fri, 26 Jul 2019 08:38:13 -0400 From: "Michael S. Tsirkin" To: Jason Wang Subject: Re: WARNING in __mmdrop Message-ID: <20190726082837-mutt-send-email-mst@kernel.org> References: <20190723051828-mutt-send-email-mst@kernel.org> <20190725012149-mutt-send-email-mst@kernel.org> <55e8930c-2695-365f-a07b-3ad169654d28@redhat.com> <20190725042651-mutt-send-email-mst@kernel.org> <84bb2e31-0606-adff-cf2a-e1878225a847@redhat.com> <20190725092332-mutt-send-email-mst@kernel.org> <11802a8a-ce41-f427-63d5-b6a4cf96bb3f@redhat.com> <20190726074644-mutt-send-email-mst@kernel.org> <5cc94f15-b229-a290-55f3-8295266edb2b@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5cc94f15-b229-a290-55f3-8295266edb2b@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190726_053824_991154_9E88C5D4 X-CRM114-Status: GOOD ( 23.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mhocko@suse.com, peterz@infradead.org, ldv@altlinux.org, james.bottomley@hansenpartnership.com, linux-mm@kvack.org, namit@vmware.com, mingo@kernel.org, elena.reshetova@intel.com, keescook@chromium.org, aarcange@redhat.com, davem@davemloft.net, hch@infradead.org, christian@brauner.io, syzbot , syzkaller-bugs@googlegroups.com, jglisse@redhat.com, viro@zeniv.linux.org.uk, linux-arm-kernel@lists.infradead.org, wad@chromium.org, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, ebiederm@xmission.com, akpm@linux-foundation.org, guro@fb.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdWwgMjYsIDIwMTkgYXQgMDg6MDA6NThQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiBPbiAyMDE5LzcvMjYg5LiL5Y2INzo0OSwgTWljaGFlbCBTLiBUc2lya2luIHdyb3Rl Ogo+ID4gT24gVGh1LCBKdWwgMjUsIDIwMTkgYXQgMTA6MjU6MjVQTSArMDgwMCwgSmFzb24gV2Fu ZyB3cm90ZToKPiA+ID4gT24gMjAxOS83LzI1IOS4i+WNiDk6MjYsIE1pY2hhZWwgUy4gVHNpcmtp biB3cm90ZToKPiA+ID4gPiA+IEV4YWN0bHksIGFuZCB0aGF0J3MgdGhlIHJlYXNvbiBhY3R1YWxs eSBJIHVzZSBzeW5jaHJvbml6ZV9yY3UoKSB0aGVyZS4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gU28g dGhlIGNvbmNlcm4gaXMgc3RpbGwgdGhlIHBvc3NpYmxlIHN5bmNocm9uaXplX2V4cGVkaXRlZCgp Pwo+ID4gPiA+IEkgdGhpbmsgc3luY2hyb25pemVfc3JjdV9leHBlZGl0ZWQuCj4gPiA+ID4gCj4g PiA+ID4gc3luY2hyb25pemVfZXhwZWRpdGVkIHNlbmRzIGxvdHMgb2YgSVBJIGFuZCBpcyBiYWQg Zm9yIHJlYWx0aW1lIFZNcy4KPiA+ID4gPiAKPiA+ID4gPiA+IENhbiBJIGRvIHRoaXMKPiA+ID4g PiA+IG9uIHRocm91Z2ggYW5vdGhlciBzZXJpZXMgb24gdG9wIG9mIHRoZSBpbmNvbWluZyBWMj8K PiA+ID4gPiA+IAo+ID4gPiA+ID4gVGhhbmtzCj4gPiA+ID4gPiAKPiA+ID4gPiBUaGUgcXVlc3Rp b24gaXMgdGhpczogaXMgdGhpcyBzdGlsbCBhIGdhaW4gaWYgd2Ugc3dpdGNoIHRvIHRoZQo+ID4g PiA+IG1vcmUgZXhwZW5zaXZlIHNyY3U/IElmIHllcyB0aGVuIHdlIGNhbiBrZWVwIHRoZSBmZWF0 dXJlIG9uLAo+ID4gPiAKPiA+ID4gSSB0aGluayB3ZSBvbmx5IGNhcmUgYWJvdXQgdGhlIGNvc3Qg b24gc3JjdV9yZWFkX2xvY2soKSB3aGljaCBsb29rcyBwcmV0dHkKPiA+ID4gdGlueSBmb3JtIG15 IHBvaW50IG9mIHZpZXcuIFdoaWNoIGlzIGJhc2ljYWxseSBhIFJFQURfT05DRSgpICsgV1JJVEVf T05DRSgpLgo+ID4gPiAKPiA+ID4gT2YgY291cnNlIEkgY2FuIGJlbmNobWFyayB0byBzZWUgdGhl IGRpZmZlcmVuY2UuCj4gPiA+IAo+ID4gPiAKPiA+ID4gPiBpZiBub3Qgd2UnbGwgcHV0IGl0IG9m ZiB1bnRpbCBuZXh0IHJlbGVhc2UgYW5kIHRoaW5rCj4gPiA+ID4gb2YgYmV0dGVyIHNvbHV0aW9u cy4gcmN1LT5zcmN1IGlzIGp1c3QgYSBmaW5kIGFuZCByZXBsYWNlLAo+ID4gPiA+IGRvbid0IHNl ZSB3aHkgd2UgbmVlZCB0byBkZWZlciB0aGF0LiBjYW4gYmUgYSBzZXBhcmF0ZSBwYXRjaAo+ID4g PiA+IGZvciBzdXJlLCBidXQgd2UgbmVlZCB0byBrbm93IGhvdyB3ZWxsIGl0IHdvcmtzLgo+ID4g PiAKPiA+ID4gSSB0aGluayBJIGdldCBoZXJlLCBsZXQgbWUgdHJ5IHRvIGRvIHRoYXQgaW4gVjIg YW5kIGxldCdzIHNlZSB0aGUgbnVtYmVycy4KPiA+ID4gCj4gPiA+IFRoYW5rcwo+IAo+IAo+IEl0 IGxvb2tzIHRvIG1lIGZvciB0cmVlIHJjdSwgaXRzIHNyY3VfcmVhZF9sb2NrKCkgaGF2ZSBhIG1i KCkgd2hpY2ggaXMgdG9vCj4gZXhwZW5zaXZlIGZvciB1cy4KCkkgd2lsbCB0cnkgdG8gcG9uZGVy IHVzaW5nIHZxIGxvY2sgaW4gc29tZSB3YXkuCk1heWJlIHdpdGggdHJ5bG9jayBzb21laG93IC4u LgoKCj4gSWYgd2UganVzdCB3b3JyeSBhYm91dCB0aGUgSVBJLAoKV2l0aCBzeW5jaHJvbml6ZV9y Y3Ugd2hhdCBJIHdvdWxkIHdvcnJ5IGFib3V0IGlzIHRoYXQgZ3Vlc3QgaXMgc3RhbGxlZApiZWNh dXNlIHN5c3RlbSBpcyBidXN5IGJlY2F1c2Ugb2Ygb3RoZXIgZ3Vlc3RzLgpXaXRoIGV4cGVkaXRl ZCBpdCdzIHRoZSBJUElzLi4uCgoKPiBjYW4gd2UgZG8gc29tZXRoaW5nIGxpa2UgaW4KPiB2aG9z dF9pbnZhbGlkYXRlX3ZxX3N0YXJ0KCk/Cj4gCj4gwqDCoMKgwqDCoMKgwqAgaWYgKG1hcCkgewo+ IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAvKiBJbiBvcmRlciB0byBhdm9pZCBwb3Nz aWJsZSBJUElzIHdpdGgKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAqIHN5bmNo cm9uaXplX3JjdV9leHBlZGl0ZWQoKSB3ZSB1c2UgY2FsbF9yY3UoKSArCj4gwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgKiBjb21wbGV0aW9uLgo+ICovCj4gaW5pdF9jb21wbGV0aW9u KCZjLmNvbXBsZXRpb24pOwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjYWxsX3Jj dSgmYy5yY3VfaGVhZCwgdmhvc3RfZmluaXNoX3ZxX2ludmFsaWRhdGlvbik7Cj4gd2FpdF9mb3Jf Y29tcGxldGlvbigmYy5jb21wbGV0aW9uKTsKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgdmhvc3Rfc2V0X21hcF9kaXJ0eSh2cSwgbWFwLCBpbmRleCk7Cj4gdmhvc3RfbWFwX3VucHJl ZmV0Y2gobWFwKTsKPiDCoMKgwqDCoMKgwqDCoCB9Cj4gCj4gPwoKV2h5IHdvdWxkIHRoYXQgYmUg ZmFzdGVyIHRoYW4gc3luY2hyb25pemVfcmN1PwoKCgo+IAo+ID4gVGhlcmUncyBvbmUgb3RoZXIg dGhpbmcgdGhhdCBib3RoZXJzIG1lLCBhbmQgdGhhdCBpcyB0aGF0Cj4gPiBmb3IgbGFyZ2Ugcmlu Z3Mgd2hpY2ggYXJlIG5vdCBwaHlzaWNhbGx5IGNvbnRpZ3VvdXMKPiA+IHdlIGRvbid0IGltcGxl bWVudCB0aGUgb3B0aW1pemF0aW9uLgo+ID4gCj4gPiBGb3Igc3VyZSwgdGhhdCBjYW4gd2FpdCwg YnV0IEkgdGhpbmsgZXZlbnR1YWxseSB3ZSBzaG91bGQKPiA+IHZtYXAgbGFyZ2UgcmluZ3MuCj4g Cj4gCj4gWWVzLCB3b3J0aCB0byB0cnkuIEJ1dCB1c2luZyBkaXJlY3QgbWFwIGhhcyBpdHMgb3du IGFkdmFudGFnZTogaXQgY2FuIHVzZQo+IGh1Z2VwYWdlIHRoYXQgdm1hcCBjYW4ndAo+IAo+IFRo YW5rcwoKU3VyZSwgc28gd2UgY2FuIGRvIHRoYXQgZm9yIHNtYWxsIHJpbmdzLgoKLS0gCk1TVAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=