From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Fri, 26 Jul 2019 11:36:25 +0000 Subject: Re: [PATCH] video: Demote panel timing not found error message Message-Id: <20190726113625.GC20065@ravnborg.org> List-Id: References: <20190726101849.27322-1-thierry.reding@gmail.com> In-Reply-To: <20190726101849.27322-1-thierry.reding@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thierry Reding Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz Hi Thierry. On Fri, Jul 26, 2019 at 12:18:49PM +0200, Thierry Reding wrote: > From: Thierry Reding > > Failing to find a panel-timing node is not an error in all cases, so do > not output an error message in that case. Instead turn it into a debug > message and make the drivers that care about it output an error message > of their own. This is more or less the same as already implmented by Douglas here: https://patchwork.kernel.org/cover/11053243/ Doug's has an extra bug-fix that we shall not miss. I am waiting for feedback from Bartlomiej before proceeding. I guess he is on holiday somewhere and will return soon. Sam > > Signed-off-by: Thierry Reding > --- > drivers/gpu/drm/panel/panel-lvds.c | 4 +++- > drivers/video/fbdev/amba-clcd.c | 4 +++- > drivers/video/of_display_timing.c | 2 +- > 3 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c > index 1ec57d0806a8..7fcb3527c788 100644 > --- a/drivers/gpu/drm/panel/panel-lvds.c > +++ b/drivers/gpu/drm/panel/panel-lvds.c > @@ -147,8 +147,10 @@ static int panel_lvds_parse_dt(struct panel_lvds *lvds) > int ret; > > ret = of_get_display_timing(np, "panel-timing", &timing); > - if (ret < 0) > + if (ret < 0) { > + dev_err(lvds->dev, "%pOF: could not find panel timing\n", np); > return ret; > + } > > videomode_from_timing(&timing, &lvds->video_mode); > > diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c > index 89324e42a033..13df898a3481 100644 > --- a/drivers/video/fbdev/amba-clcd.c > +++ b/drivers/video/fbdev/amba-clcd.c > @@ -561,8 +561,10 @@ static int clcdfb_of_get_dpi_panel_mode(struct device_node *node, > struct videomode video; > > err = of_get_display_timing(node, "panel-timing", &timing); > - if (err) > + if (err) { > + pr_err("%pOF: could not find panel timing\n", node); > return err; > + } > > videomode_from_timing(&timing, &video); > > diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c > index f5c1c469c0af..9385b518349f 100644 > --- a/drivers/video/of_display_timing.c > +++ b/drivers/video/of_display_timing.c > @@ -125,7 +125,7 @@ int of_get_display_timing(const struct device_node *np, const char *name, > > timing_np = of_get_child_by_name(np, name); > if (!timing_np) { > - pr_err("%pOF: could not find node '%s'\n", np, name); > + pr_debug("%pOF: could not find node '%s'\n", np, name); > return -ENOENT; > } > > -- > 2.22.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] video: Demote panel timing not found error message Date: Fri, 26 Jul 2019 13:36:25 +0200 Message-ID: <20190726113625.GC20065@ravnborg.org> References: <20190726101849.27322-1-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBEA76ED22 for ; Fri, 26 Jul 2019 11:36:28 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190726101849.27322-1-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz List-Id: dri-devel@lists.freedesktop.org SGkgVGhpZXJyeS4KCk9uIEZyaSwgSnVsIDI2LCAyMDE5IGF0IDEyOjE4OjQ5UE0gKzAyMDAsIFRo aWVycnkgUmVkaW5nIHdyb3RlOgo+IEZyb206IFRoaWVycnkgUmVkaW5nIDx0cmVkaW5nQG52aWRp YS5jb20+Cj4gCj4gRmFpbGluZyB0byBmaW5kIGEgcGFuZWwtdGltaW5nIG5vZGUgaXMgbm90IGFu IGVycm9yIGluIGFsbCBjYXNlcywgc28gZG8KPiBub3Qgb3V0cHV0IGFuIGVycm9yIG1lc3NhZ2Ug aW4gdGhhdCBjYXNlLiBJbnN0ZWFkIHR1cm4gaXQgaW50byBhIGRlYnVnCj4gbWVzc2FnZSBhbmQg bWFrZSB0aGUgZHJpdmVycyB0aGF0IGNhcmUgYWJvdXQgaXQgb3V0cHV0IGFuIGVycm9yIG1lc3Nh Z2UKPiBvZiB0aGVpciBvd24uCgpUaGlzIGlzIG1vcmUgb3IgbGVzcyB0aGUgc2FtZSBhcyBhbHJl YWR5IGltcGxtZW50ZWQgYnkgRG91Z2xhcyBoZXJlOgpodHRwczovL3BhdGNod29yay5rZXJuZWwu b3JnL2NvdmVyLzExMDUzMjQzLwoKRG91ZydzIGhhcyBhbiBleHRyYSBidWctZml4IHRoYXQgd2Ug c2hhbGwgbm90IG1pc3MuCgpJIGFtIHdhaXRpbmcgZm9yIGZlZWRiYWNrIGZyb20gQmFydGxvbWll aiBiZWZvcmUgcHJvY2VlZGluZy4KSSBndWVzcyBoZSBpcyBvbiBob2xpZGF5IHNvbWV3aGVyZSBh bmQgd2lsbCByZXR1cm4gc29vbi4KCglTYW0KCj4gCj4gU2lnbmVkLW9mZi1ieTogVGhpZXJyeSBS ZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3BhbmVs L3BhbmVsLWx2ZHMuYyB8IDQgKysrLQo+ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L2FtYmEtY2xjZC5j ICAgIHwgNCArKystCj4gIGRyaXZlcnMvdmlkZW8vb2ZfZGlzcGxheV90aW1pbmcuYyAgfCAyICst Cj4gIDMgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtbHZkcy5jIGIvZHJpdmVy cy9ncHUvZHJtL3BhbmVsL3BhbmVsLWx2ZHMuYwo+IGluZGV4IDFlYzU3ZDA4MDZhOC4uN2ZjYjM1 MjdjNzg4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1sdmRzLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtbHZkcy5jCj4gQEAgLTE0Nyw4ICsx NDcsMTAgQEAgc3RhdGljIGludCBwYW5lbF9sdmRzX3BhcnNlX2R0KHN0cnVjdCBwYW5lbF9sdmRz ICpsdmRzKQo+ICAJaW50IHJldDsKPiAgCj4gIAlyZXQgPSBvZl9nZXRfZGlzcGxheV90aW1pbmco bnAsICJwYW5lbC10aW1pbmciLCAmdGltaW5nKTsKPiAtCWlmIChyZXQgPCAwKQo+ICsJaWYgKHJl dCA8IDApIHsKPiArCQlkZXZfZXJyKGx2ZHMtPmRldiwgIiVwT0Y6IGNvdWxkIG5vdCBmaW5kIHBh bmVsIHRpbWluZ1xuIiwgbnApOwo+ICAJCXJldHVybiByZXQ7Cj4gKwl9Cj4gIAo+ICAJdmlkZW9t b2RlX2Zyb21fdGltaW5nKCZ0aW1pbmcsICZsdmRzLT52aWRlb19tb2RlKTsKPiAgCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvdmlkZW8vZmJkZXYvYW1iYS1jbGNkLmMgYi9kcml2ZXJzL3ZpZGVvL2Zi ZGV2L2FtYmEtY2xjZC5jCj4gaW5kZXggODkzMjRlNDJhMDMzLi4xM2RmODk4YTM0ODEgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy92aWRlby9mYmRldi9hbWJhLWNsY2QuYwo+ICsrKyBiL2RyaXZlcnMv dmlkZW8vZmJkZXYvYW1iYS1jbGNkLmMKPiBAQCAtNTYxLDggKzU2MSwxMCBAQCBzdGF0aWMgaW50 IGNsY2RmYl9vZl9nZXRfZHBpX3BhbmVsX21vZGUoc3RydWN0IGRldmljZV9ub2RlICpub2RlLAo+ ICAJc3RydWN0IHZpZGVvbW9kZSB2aWRlbzsKPiAgCj4gIAllcnIgPSBvZl9nZXRfZGlzcGxheV90 aW1pbmcobm9kZSwgInBhbmVsLXRpbWluZyIsICZ0aW1pbmcpOwo+IC0JaWYgKGVycikKPiArCWlm IChlcnIpIHsKPiArCQlwcl9lcnIoIiVwT0Y6IGNvdWxkIG5vdCBmaW5kIHBhbmVsIHRpbWluZ1xu Iiwgbm9kZSk7Cj4gIAkJcmV0dXJuIGVycjsKPiArCX0KPiAgCj4gIAl2aWRlb21vZGVfZnJvbV90 aW1pbmcoJnRpbWluZywgJnZpZGVvKTsKPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8v b2ZfZGlzcGxheV90aW1pbmcuYyBiL2RyaXZlcnMvdmlkZW8vb2ZfZGlzcGxheV90aW1pbmcuYwo+ IGluZGV4IGY1YzFjNDY5YzBhZi4uOTM4NWI1MTgzNDlmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv dmlkZW8vb2ZfZGlzcGxheV90aW1pbmcuYwo+ICsrKyBiL2RyaXZlcnMvdmlkZW8vb2ZfZGlzcGxh eV90aW1pbmcuYwo+IEBAIC0xMjUsNyArMTI1LDcgQEAgaW50IG9mX2dldF9kaXNwbGF5X3RpbWlu Zyhjb25zdCBzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wLCBjb25zdCBjaGFyICpuYW1lLAo+ICAKPiAg CXRpbWluZ19ucCA9IG9mX2dldF9jaGlsZF9ieV9uYW1lKG5wLCBuYW1lKTsKPiAgCWlmICghdGlt aW5nX25wKSB7Cj4gLQkJcHJfZXJyKCIlcE9GOiBjb3VsZCBub3QgZmluZCBub2RlICclcydcbiIs IG5wLCBuYW1lKTsKPiArCQlwcl9kZWJ1ZygiJXBPRjogY291bGQgbm90IGZpbmQgbm9kZSAnJXMn XG4iLCBucCwgbmFtZSk7Cj4gIAkJcmV0dXJuIC1FTk9FTlQ7Cj4gIAl9Cj4gIAo+IC0tIAo+IDIu MjIuMAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=