From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA0DBC7618B for ; Fri, 26 Jul 2019 15:38:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9258B2054F for ; Fri, 26 Jul 2019 15:38:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564155482; bh=SLkY0kzv+7zTX5Msvvotv5x3ROGVMcKp6MdENo7d3Ts=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WRnpp3RhUBE7nhPiQeaawT3FTlDLIQhOvvKz5sEnA14CLxS9hQijOhXtyDwVBHtvM n7pPCfeAizc0LIvlBtU/hnWMOmor+lV1eWgT1cQr4y71v52H26CGZCVFMFhQoAfVI0 Wbg3pQ8hmpZBSLNHWN+6WaKI+BTrLSgFetGrsuhQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388315AbfGZPiB (ORCPT ); Fri, 26 Jul 2019 11:38:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:43718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388672AbfGZP3G (ORCPT ); Fri, 26 Jul 2019 11:29:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 13AB322C7E; Fri, 26 Jul 2019 15:29:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564154946; bh=SLkY0kzv+7zTX5Msvvotv5x3ROGVMcKp6MdENo7d3Ts=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RxJc0G88rKvkIpm+O4u1ggkdHDQmXpvR/UvtevqPfSpyDDX3Emv38vytGU2RsEBML WA9AbHZQ5gAg/BlA22hsjDfpzS/E+XpyR4tMUh17t5QHJKKjVc6r+dL/Fr7r7a+i2G mSNjmYPNn0TUYWJ7wWJiuZ560e4ECVNXAGYn2s5E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Haiyang Zhang , "David S. Miller" Subject: [PATCH 5.1 03/62] hv_netvsc: Fix extra rcu_read_unlock in netvsc_recv_callback() Date: Fri, 26 Jul 2019 17:24:15 +0200 Message-Id: <20190726152302.069212417@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190726152301.720139286@linuxfoundation.org> References: <20190726152301.720139286@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haiyang Zhang [ Upstream commit be4363bdf0ce9530f15aa0a03d1060304d116b15 ] There is an extra rcu_read_unlock left in netvsc_recv_callback(), after a previous patch that removes RCU from this function. This patch removes the extra RCU unlock. Fixes: 345ac08990b8 ("hv_netvsc: pass netvsc_device to receive callback") Signed-off-by: Haiyang Zhang Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/hyperv/netvsc_drv.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -849,7 +849,6 @@ int netvsc_recv_callback(struct net_devi if (unlikely(!skb)) { ++net_device_ctx->eth_stats.rx_no_memory; - rcu_read_unlock(); return NVSP_STAT_FAIL; }