From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CFBDC7618B for ; Fri, 26 Jul 2019 15:30:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12ED9218D4 for ; Fri, 26 Jul 2019 15:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564155021; bh=GH0024jItE3M+mrjJFsl1zzLd5bi+P+GwkHqwepwIG8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WoEXvX9mVssU1DGd82DyGw+wvEta0M/edSpE4EL/uXyfgN4vK6j5IgIsbPfvetiyg /I0VvpGF7y57JszOe46uiWjMj7GEuWla0m7el4F1zXMwahlz51UwuqIiK6DGQRUHOp gDgJlyylGMTDDu0rT993nCYEgrOgQLRFFrYaStsU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388429AbfGZPaT (ORCPT ); Fri, 26 Jul 2019 11:30:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:45156 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388404AbfGZPaP (ORCPT ); Fri, 26 Jul 2019 11:30:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB6A2218D4; Fri, 26 Jul 2019 15:30:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564155015; bh=GH0024jItE3M+mrjJFsl1zzLd5bi+P+GwkHqwepwIG8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LQRBymhiAzI3hiwc+dsnuxcccRPA8llsu2xVGCKHPubhIymPnQwWPiaz0oY+Y/mAW 4+HzemNKtkjVgymcL+FR3p24NzNLtH5crJuTvXEazGC5FmqcvRFxBDeW65fz0d4+QM 8GH7myfMp6FZg5KAwPZO9nd9lb1EfCO+xyT2zcrc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Frank de Brabander , Willem de Bruijn , "David S. Miller" Subject: [PATCH 5.1 36/62] selftests: txring_overwrite: fix incorrect test of mmap() return value Date: Fri, 26 Jul 2019 17:24:48 +0200 Message-Id: <20190726152305.730113051@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190726152301.720139286@linuxfoundation.org> References: <20190726152301.720139286@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank de Brabander [ Upstream commit cecaa76b2919aac2aa584ce476e9fcd5b084add5 ] If mmap() fails it returns MAP_FAILED, which is defined as ((void *) -1). The current if-statement incorrectly tests if *ring is NULL. Fixes: 358be656406d ("selftests/net: add txring_overwrite") Signed-off-by: Frank de Brabander Acked-by: Willem de Bruijn Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- tools/testing/selftests/net/txring_overwrite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/tools/testing/selftests/net/txring_overwrite.c +++ b/tools/testing/selftests/net/txring_overwrite.c @@ -113,7 +113,7 @@ static int setup_tx(char **ring) *ring = mmap(0, req.tp_block_size * req.tp_block_nr, PROT_READ | PROT_WRITE, MAP_SHARED, fdt, 0); - if (!*ring) + if (*ring == MAP_FAILED) error(1, errno, "mmap"); return fdt;