From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Review required [Was: Associate ddc adapters with connectors] Date: Fri, 26 Jul 2019 20:55:38 +0200 Message-ID: <20190726185538.GD14981@ravnborg.org> References: <20190726183520.GA22572@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190726183520.GA22572@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Andrzej Pietrasiewicz Cc: Neil Armstrong , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Matthias Brugger , Laurent Pinchart , Shawn Guo , kernel@collabora.com, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Jonathan Hunter , linux-rockchip@lists.infradead.org, Chen-Yu Tsai , Kukjin Kim , NXP Linux Team , Dave Airlie , Thomas Zimmermann , Jonas Karlman , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, Jyri Sarha , Mamta Shukla , linux-mediatek@lists.infradead.org, Maxime Ripard , linux-tegra@vger.kernel.orgThom List-Id: amd-gfx.lists.freedesktop.org SGkgYWxsLgoKQW5kcnplaiBoYXZlIGRvbmUgYSBnb29kIGpvYiBmb2xsb3dpbmcgdXAgb24gZmVl ZGJhY2sgYW5kIHRoaXMgc2VyaWVzIGlzCm5vdyByZWFkeS4KCldlIG5lZWQgYWNrIG9uIHRoZSBw YXRjaGVzIHRvdWNoaW5nIHRoZSBpbmRpdmlkdWFsIGRyaXZlcnMgYmVmb3JlIHdlIGNhbgpwcm9j ZWVkLgpQbGVhc2UgY2hlY2sgeW91ciBkcml2ZXJzIGFuZCBnZXQgYmFjay4KCglTYW0KCj4gSGkg QW5kZXplai4KPiAKPiBPbiBGcmksIEp1bCAyNiwgMjAxOSBhdCAwNzoyMjo1NFBNICswMjAwLCBB bmRyemVqIFBpZXRyYXNpZXdpY3ogd3JvdGU6Cj4gPiBJdCBpcyBkaWZmaWN1bHQgZm9yIGEgdXNl ciB0byBrbm93IHdoaWNoIG9mIHRoZSBpMmMgYWRhcHRlcnMgaXMgZm9yIHdoaWNoCj4gPiBkcm0g Y29ubmVjdG9yLiBUaGlzIHNlcmllcyBhZGRyZXNzZXMgdGhpcyBwcm9ibGVtLgo+ID4gCj4gPiBU aGUgaWRlYSBpcyB0byBoYXZlIGEgc3ltYm9saWMgbGluayBpbiBjb25uZWN0b3IncyBzeXNmcyBk aXJlY3RvcnksIGUuZy46Cj4gPiAKPiA+IGxzIC1sIC9zeXMvY2xhc3MvZHJtL2NhcmQwLUhETUkt QS0xL2RkYwo+ID4gbHJ3eHJ3eHJ3eCAxIHJvb3Qgcm9vdCAwIEp1biAyNCAxMDo0MiAvc3lzL2Ns YXNzL2RybS9jYXJkMC1IRE1JLUEtMS9kZGMgXAo+ID4gCS0+IC4uLy4uLy4uLy4uL3NvYy8xMzg4 MDAwMC5pMmMvaTJjLTIKPiA+IAo+ID4gVGhlIHVzZXIgdGhlbiBrbm93cyB0aGF0IHRoZWlyIGNh cmQwLUhETUktQS0xIHVzZXMgaTJjLTIgYW5kIGNhbiBlLmcuIHJ1bgo+ID4gZGRjdXRpbDoKPiA+ IAo+ID4gZGRjdXRpbCAtYiAyIGdldHZjcCAweDEwCj4gPiBWQ1AgY29kZSAweDEwIChCcmlnaHRu ZXNzKTogY3VycmVudCB2YWx1ZSA9ICAgIDkwLCBtYXggdmFsdWUgPSAgIDEwMAo+ID4gCj4gPiBU aGUgZmlyc3QgcGF0Y2ggaW4gdGhlIHNlcmllcyBhZGRzIHN0cnVjdCBpMmNfYWRhcHRlciBwb2lu dGVyIHRvIHN0cnVjdAo+ID4gZHJtX2Nvbm5lY3Rvci4gSWYgdGhlIGZpZWxkIGlzIHVzZWQgYnkg YSBwYXJ0aWN1bGFyIGRyaXZlciwgdGhlbiBhbgo+ID4gYXBwcm9wcmlhdGUgc3ltYm9saWMgbGlu ayBpcyBjcmVhdGVkIGJ5IHRoZSBnZW5lcmljIGNvZGUsIHdoaWNoIGlzIGFsc28gYWRkZWQKPiA+ IGJ5IHRoaXMgcGF0Y2guCj4gPiAKPiA+IFBhdGNoIDIgYWRkcyBhIG5ldyB2YXJpYW50IG9mIGRy bV9jb25uZWN0b3JfaW5pdCgpLCBzZWUgdGhlIGNoYW5nZWxvZwo+ID4gYmVsb3cuCj4gPiAKPiA+ IFBhdGNoZXMgMy4uMjQgYXJlIGV4YW1wbGVzIG9mIGhvdyB0byBjb252ZXJ0IGEgZHJpdmVyIHRv IHRoaXMgbmV3IHNjaGVtZS4KPiA+IAo+IC4uLgo+ID4gCj4gPiB2NS4udjY6Cj4gPiAKPiA+IC0g aW1wcm92ZWQgc3ViamVjdCBsaW5lIG9mIHBhdGNoIDEKPiA+IC0gYWRkZWQga2VybmVsLWRvYyBm b3IgZHJtX2Nvbm5lY3Rvcl9pbml0X3dpdGhfZGRjKCkKPiA+IC0gaW1wcm92ZWQga2VybmVsLWRv YyBmb3IgdGhlIGRkYyBmaWVsZCBvZiBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcgo+ID4gLSBhZGRlZCBS ZXZpZXdlZC1ieSBpbiBwYXRjaGVzIDE3IGFuZCAxOAo+ID4gLSBhZGRlZCBBY2tlZC1ieSBpbiBw YXRjaCAyCj4gPiAtIG1hZGUgdGhlIG93bmVyc2hpcCBvZiBkZGMgaTJjX2FkYXB0ZXIgZXhwbGlj aXQgaW4gYWxsIHBhdGNoZXMsCj4gPiB0aGlzIG1hZGUgdGhlIGFmZmVjdGVkIHBhdGNoZXMgbXVj aCBzaW1wbGVyCj4gCj4gTG9va3MgZ29vZCBub3cuCj4gUGF0Y2ggMSBhbmQgMiBhcmU6Cj4gUmV2 aWV3ZWQtYnk6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4KPiAKPiBUaGUgcmVtYWlu aW5nIHBhdGNoZXMgYXJlOgo+IEFja2VkLWJ5OiBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9yZy5v cmc+Cj4gCj4gCVNhbQo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66705C7618F for ; Fri, 26 Jul 2019 18:55:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43F8F216F4 for ; Fri, 26 Jul 2019 18:55:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388052AbfGZSzr (ORCPT ); Fri, 26 Jul 2019 14:55:47 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:44222 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387743AbfGZSzr (ORCPT ); Fri, 26 Jul 2019 14:55:47 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id CB69020127; Fri, 26 Jul 2019 20:55:39 +0200 (CEST) Date: Fri, 26 Jul 2019 20:55:38 +0200 From: Sam Ravnborg To: Andrzej Pietrasiewicz Cc: Neil Armstrong , David Airlie , Liviu Dudau , dri-devel@lists.freedesktop.org, Douglas Anderson , Thierry Reding , Laurent Pinchart , kernel@collabora.com, linux-samsung-soc@vger.kernel.org, Jyri Sarha , Vincent Abriou , Krzysztof Kozlowski , Jonathan Hunter , linux-rockchip@lists.infradead.org, Chen-Yu Tsai , Kukjin Kim , NXP Linux Team , Dave Airlie , intel-gfx@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, Jonas Karlman , linux-arm-msm@vger.kernel.org, Maxime Ripard , Mamta Shukla , linux-mediatek@lists.infradead.org, Rodrigo Vivi , Matthias Brugger , Thomas Gleixner , Sean Paul , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , amd-gfx@lists.freedesktop.org, Tomi Valkeinen , Thomas Zimmermann , Seung-Woo Kim , linux-kernel@vger.kernel.org, Todor Tomov , Kyungmin Park , Huang Rui , Greg Kroah-Hartman , Alex Deucher , Shawn Guo , Christian =?iso-8859-1?Q?K=F6nig?= , Gerd Hoffmann Subject: Review required [Was: Associate ddc adapters with connectors] Message-ID: <20190726185538.GD14981@ravnborg.org> References: <20190726183520.GA22572@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190726183520.GA22572@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=nTBMXhx45H-Va90dJ2EA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi all. Andrzej have done a good job following up on feedback and this series is now ready. We need ack on the patches touching the individual drivers before we can proceed. Please check your drivers and get back. Sam > Hi Andezej. > > On Fri, Jul 26, 2019 at 07:22:54PM +0200, Andrzej Pietrasiewicz wrote: > > It is difficult for a user to know which of the i2c adapters is for which > > drm connector. This series addresses this problem. > > > > The idea is to have a symbolic link in connector's sysfs directory, e.g.: > > > > ls -l /sys/class/drm/card0-HDMI-A-1/ddc > > lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \ > > -> ../../../../soc/13880000.i2c/i2c-2 > > > > The user then knows that their card0-HDMI-A-1 uses i2c-2 and can e.g. run > > ddcutil: > > > > ddcutil -b 2 getvcp 0x10 > > VCP code 0x10 (Brightness): current value = 90, max value = 100 > > > > The first patch in the series adds struct i2c_adapter pointer to struct > > drm_connector. If the field is used by a particular driver, then an > > appropriate symbolic link is created by the generic code, which is also added > > by this patch. > > > > Patch 2 adds a new variant of drm_connector_init(), see the changelog > > below. > > > > Patches 3..24 are examples of how to convert a driver to this new scheme. > > > ... > > > > v5..v6: > > > > - improved subject line of patch 1 > > - added kernel-doc for drm_connector_init_with_ddc() > > - improved kernel-doc for the ddc field of struct drm_connector > > - added Reviewed-by in patches 17 and 18 > > - added Acked-by in patch 2 > > - made the ownership of ddc i2c_adapter explicit in all patches, > > this made the affected patches much simpler > > Looks good now. > Patch 1 and 2 are: > Reviewed-by: Sam Ravnborg > > The remaining patches are: > Acked-by: Sam Ravnborg > > Sam > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel