From: Jonathan Cameron <jic23@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: light: veml6070: convert to i2c_new_dummy_device
Date: Sat, 27 Jul 2019 20:58:11 +0100 [thread overview]
Message-ID: <20190727205811.7beba748@archlinux> (raw)
In-Reply-To: <20190722172613.3890-3-wsa+renesas@sang-engineering.com>
On Mon, 22 Jul 2019 19:26:12 +0200
Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to do something random with it.
Thanks,
Jonathan
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/iio/light/veml6070.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/light/veml6070.c b/drivers/iio/light/veml6070.c
> index a3138e1b5803..0be553ad5989 100644
> --- a/drivers/iio/light/veml6070.c
> +++ b/drivers/iio/light/veml6070.c
> @@ -158,10 +158,10 @@ static int veml6070_probe(struct i2c_client *client,
> indio_dev->name = VEML6070_DRV_NAME;
> indio_dev->modes = INDIO_DIRECT_MODE;
>
> - data->client2 = i2c_new_dummy(client->adapter, VEML6070_ADDR_DATA_LSB);
> - if (!data->client2) {
> + data->client2 = i2c_new_dummy_device(client->adapter, VEML6070_ADDR_DATA_LSB);
> + if (IS_ERR(data->client2)) {
> dev_err(&client->dev, "i2c device for second chip address failed\n");
> - return -ENODEV;
> + return PTR_ERR(data->client2);
> }
>
> data->config = VEML6070_IT_10 | VEML6070_COMMAND_RSRVD |
next prev parent reply other threads:[~2019-07-27 19:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 17:26 [PATCH 0/3] iio: convert subsystem to i2c_new_dummy_device() Wolfram Sang
2019-07-22 17:26 ` [PATCH 1/3] iio: light: cm36651: convert to i2c_new_dummy_device Wolfram Sang
2019-07-27 19:56 ` Jonathan Cameron
2019-07-22 17:26 ` [PATCH 2/3] iio: light: veml6070: " Wolfram Sang
2019-07-27 19:58 ` Jonathan Cameron [this message]
2019-07-22 17:26 ` [PATCH 3/3] iio: pressure: hp03: " Wolfram Sang
2019-07-27 19:59 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190727205811.7beba748@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.