From: Guenter Roeck <linux@roeck-us.net>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Makefile: Globally enable fall-through warning
Date: Sun, 28 Jul 2019 06:58:26 -0700 [thread overview]
Message-ID: <20190728135826.GA10262@roeck-us.net> (raw)
On Thu, Jun 06, 2019 at 07:46:17PM -0500, Gustavo A. R. Silva wrote:
> Now that all the fall-through warnings have been addressed in the
> kernel, enable the fall-through warning globally.
>
Not really "all".
powerpc:85xx/sbc8548_defconfig:
arch/powerpc/kernel/align.c: In function ‘emulate_spe’:
arch/powerpc/kernel/align.c:178:8: error: this statement may fall through
Plus many more similar errors in the same file.
All sh builds:
arch/sh/kernel/disassemble.c: In function 'print_sh_insn':
arch/sh/kernel/disassemble.c:478:8: error: this statement may fall through
Again, this is seen in several places.
mips:cavium_octeon_defconfig:
arch/mips/cavium-octeon/octeon-usb.c: In function 'dwc3_octeon_clocks_start':
include/linux/device.h:1499:2: error: this statement may fall through
None of those are from recent changes. And this is just from my small
subset of test builds.
Guenter
next reply other threads:[~2019-07-28 13:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 13:58 Guenter Roeck [this message]
2019-07-28 16:42 ` [PATCH] Makefile: Globally enable fall-through warning Gustavo A. R. Silva
2019-07-28 17:14 ` Guenter Roeck
2019-07-28 17:31 ` Gustavo A. R. Silva
2019-07-28 18:12 ` Guenter Roeck
2019-07-29 8:22 ` Geert Uytterhoeven
2019-07-29 14:42 ` Gustavo A. R. Silva
-- strict thread matches above, loose matches on Subject: below --
2022-05-17 17:35 ALOK JHA
2022-05-17 18:42 ` Andrew Morton
2022-05-17 18:46 ` Andrew Morton
2022-05-17 19:40 ` Jeff Johnson
2022-05-17 19:59 ` Gustavo A. R. Silva
2025-05-05 17:14 Omar el Azouny
2025-05-05 17:53 ` Miguel Ojeda
2026-01-10 1:34 MIshraMohit21-LE
2026-01-10 3:12 ` Gustavo A. R. Silva
[not found] ` <CAP5HdgoFya1NfeJH0wT7KtzqaFmupn5C-kSwXNEtEdbq5bQSEw@mail.gmail.com>
2026-01-10 4:04 ` Gustavo A. R. Silva
2026-01-22 15:53 Simone Rea
2026-01-22 18:19 ` Randy Dunlap
2026-01-22 18:44 ` Andrew Morton
2026-01-22 18:46 ` Randy Dunlap
2026-01-22 22:35 ` Miguel Ojeda
[not found] ` <CAEfWggNK7DgsRHXTE8BhWCTuDKyt6pMR_9UEHEs1NKPfPPyopw@mail.gmail.com>
2026-01-23 1:51 ` Gustavo A. R. Silva
[not found] <20260131054051.6938-1-david@stennet.com>
2026-01-31 5:40 ` david
2026-01-31 5:33 ` Gustavo A. R. Silva
2026-02-14 9:19 Rishabh
2026-05-03 8:44 Damika-Anupama
[not found] <my-first-patch>
2026-05-30 8:43 ` Manish-Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190728135826.GA10262@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.