From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jochen Sprickerhof Subject: Re: [PATCH v2 1/2] usb: core: phy: add support for PHY calibration Date: Sun, 28 Jul 2019 17:57:57 +0200 Message-ID: <20190728155757.GE10770@vis> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dVWk8uzOCD9exnpL" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Marek Szyprowski Cc: Anand Moon , Linux USB Mailing List , linux-samsung-soc@vger.kernel.org, Linux Kernel , Greg Kroah-Hartman , Mathias Nyman , Felipe Balbi , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski List-Id: linux-samsung-soc@vger.kernel.org --dVWk8uzOCD9exnpL Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Hi Marek, thanks for working on this! Tested on my XU4 Tested-by: Jochen Sprickerhof * Anand Moon [2019-07-23 00:30]: >Hi Marek, > >On Fri, 19 Jul 2019 at 13:43, Marek Szyprowski wrote: >> >> Some PHYs (for example Exynos5 USB3.0 DRD PHY) require calibration to be >> done after every USB HCD reset. Generic PHY framework has been already >> extended with phy_calibrate() function in commit 36914111e682 ("drivers: >> phy: add calibrate method"). This patch adds support for it to generic >> PHY handling code in USB HCD core. >> > >Tested on my XU3 / XU4 / HC1 >Tested-by: Anand Moon > > >> Signed-off-by: Marek Szyprowski >> --- >> drivers/usb/core/hcd.c | 7 +++++++ >> drivers/usb/core/phy.c | 21 +++++++++++++++++++++ >> drivers/usb/core/phy.h | 1 + >> 3 files changed, 29 insertions(+) >> >> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c >> index 88533938ce19..b89936c1df23 100644 >> --- a/drivers/usb/core/hcd.c >> +++ b/drivers/usb/core/hcd.c >> @@ -2291,6 +2291,9 @@ int hcd_bus_resume(struct usb_device *rhdev, pm_message_t msg) >> hcd->state = HC_STATE_RESUMING; >> status = hcd->driver->bus_resume(hcd); >> clear_bit(HCD_FLAG_WAKEUP_PENDING, &hcd->flags); >> + if (status == 0) >> + status = usb_phy_roothub_calibrate(hcd->phy_roothub); >> + >> if (status == 0) { >> struct usb_device *udev; >> int port1; >> @@ -2864,6 +2867,10 @@ int usb_add_hcd(struct usb_hcd *hcd, >> } >> hcd->rh_pollable = 1; >> >> + retval = usb_phy_roothub_calibrate(hcd->phy_roothub); >> + if (retval) >> + goto err_hcd_driver_setup; >> + >> /* NOTE: root hub and controller capabilities may not be the same */ >> if (device_can_wakeup(hcd->self.controller) >> && device_can_wakeup(&hcd->self.root_hub->dev)) >> diff --git a/drivers/usb/core/phy.c b/drivers/usb/core/phy.c >> index 7580493b867a..fb1588e7c282 100644 >> --- a/drivers/usb/core/phy.c >> +++ b/drivers/usb/core/phy.c >> @@ -151,6 +151,27 @@ int usb_phy_roothub_set_mode(struct usb_phy_roothub *phy_roothub, >> } >> EXPORT_SYMBOL_GPL(usb_phy_roothub_set_mode); >> >> +int usb_phy_roothub_calibrate(struct usb_phy_roothub *phy_roothub) >> +{ >> + struct usb_phy_roothub *roothub_entry; >> + struct list_head *head; >> + int err; >> + >> + if (!phy_roothub) >> + return 0; >> + >> + head = &phy_roothub->list; >> + >> + list_for_each_entry(roothub_entry, head, list) { >> + err = phy_calibrate(roothub_entry->phy); >> + if (err) >> + return err; >> + } >> + >> + return 0; >> +} >> +EXPORT_SYMBOL_GPL(usb_phy_roothub_calibrate); >> + >> int usb_phy_roothub_power_on(struct usb_phy_roothub *phy_roothub) >> { >> struct usb_phy_roothub *roothub_entry; >> diff --git a/drivers/usb/core/phy.h b/drivers/usb/core/phy.h >> index dad564e2d2d4..20a267cd986b 100644 >> --- a/drivers/usb/core/phy.h >> +++ b/drivers/usb/core/phy.h >> @@ -18,6 +18,7 @@ int usb_phy_roothub_exit(struct usb_phy_roothub *phy_roothub); >> >> int usb_phy_roothub_set_mode(struct usb_phy_roothub *phy_roothub, >> enum phy_mode mode); >> +int usb_phy_roothub_calibrate(struct usb_phy_roothub *phy_roothub); >> int usb_phy_roothub_power_on(struct usb_phy_roothub *phy_roothub); >> void usb_phy_roothub_power_off(struct usb_phy_roothub *phy_roothub); >> >> -- >> 2.17.1 >> > --dVWk8uzOCD9exnpL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEc7KZy9TurdzAF+h6W//cwljmlDMFAl09xgEACgkQW//cwljm lDPASA//a0c4bN2fqhttPuRzcuHRM5hwLmqcyyGi8X3juGKvrV9/AqocZI5dV4/q yBORuACD84j2cqCkHjZ3Oy8FYPg0c64I6qcb973EEM9xfpCwL1xWNDnXeFu8+L7A ig2yq4qKk4krmKAhFFd8x+O/Caqm16hiRQQqibGa5mW8jhfMyglOWA5WxPDpNt/x HpeBsv7UXoBJrhZoMOAL+ycs+MDFXmybP7xGCMrN5cJqTTCHV+f184HMnGCnVXld +r7E5SF0k4QsbV4jrfdH8cmiaVGPZhEHLrhbHlk5LAuJeTjquYxEeJTag9ZMV5/B geDZF1RlDdIJppwWv2ChyskMmfzDHC8z7XeA5xRjKFspnJhba7iuZir3G3MO4c+G Eehn/QLniT+kETjIvEDiUh0UOVm2ph//v3o3CVNs/ILWbEFQtVdfjgMBcoazeQXR GfNi5z0+5s/q/d/sDZq6BQ0hGSOpxHd/54cdwbOUWoFd1H+sPC+MT2ubFHhnCKUC Xm7p3GAND0bEqwbpaPr8zSvDQWySh5/XS7QF3+Rvutvn6MVq5jT8Dtn5OjfBCG+b KOZ+ibf2JTPZ1EDKabfvWRzy9EmVVQ7Ep1iAz2esWmiYglCj/f18+4KRL7u9VSVa CxoN1+3BT8wC+kRv2eCaRi73Yke5bZ0itcOoY5zkHZKj2PuUTN8= =Hue+ -----END PGP SIGNATURE----- --dVWk8uzOCD9exnpL--