diff for duplicates of <20190728211730.GK6088@mit.edu> diff --git a/a/1.txt b/N1/1.txt index ac77516..827b271 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -5,7 +5,7 @@ On Fri, Jul 26, 2019 at 03:41:35PM -0700, Eric Biggers wrote: > > + if (arg.key_spec.type != FSCRYPT_KEY_SPEC_TYPE_DESCRIPTOR) { -This should be "= FSCRYPT_KEY_SPEC_TYPE_INDENTIFIER" instead. That's +This should be "== FSCRYPT_KEY_SPEC_TYPE_INDENTIFIER" instead. That's because you use the identifier part of the union: > + /* Calculate the key identifier and return it to userspace. */ @@ -16,7 +16,7 @@ because you use the identifier part of the union: If we ever add a new key specifier type, and alternative in the union, this is going to come back to bite us. -> + if (policy->version = FSCRYPT_POLICY_V1) { +> + if (policy->version == FSCRYPT_POLICY_V1) { > + /* > + * The original encryption policy version provided no way of > + * verifying that the correct master key was supplied, which was @@ -37,3 +37,7 @@ But we don't allow keys usable by V1 policies to be used in the filesystem-specific keyring, do we? - Ted + +______________________________________________________ +Linux MTD discussion mailing list +http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/a/content_digest b/N1/content_digest index 871a10f..0e5d4c7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020190726224141.14044-11-ebiggers@kernel.org\0" "From\0Theodore Y. Ts'o <tytso@mit.edu>\0" "Subject\0Re: [PATCH v7 10/16] fscrypt: v2 encryption policy support\0" - "Date\0Sun, 28 Jul 2019 21:17:30 +0000\0" + "Date\0Sun, 28 Jul 2019 17:17:30 -0400\0" "To\0Eric Biggers <ebiggers@kernel.org>\0" "Cc\0Satya Tangirala <satyat@google.com>" linux-api@vger.kernel.org @@ -23,7 +23,7 @@ "> \n" "> +\tif (arg.key_spec.type != FSCRYPT_KEY_SPEC_TYPE_DESCRIPTOR) {\n" "\n" - "This should be \"= FSCRYPT_KEY_SPEC_TYPE_INDENTIFIER\" instead. That's\n" + "This should be \"== FSCRYPT_KEY_SPEC_TYPE_INDENTIFIER\" instead. That's\n" "because you use the identifier part of the union:\n" "\n" "> +\t\t/* Calculate the key identifier and return it to userspace. */\n" @@ -34,7 +34,7 @@ "If we ever add a new key specifier type, and alternative in the union,\n" "this is going to come back to bite us.\n" "\n" - "> +\tif (policy->version = FSCRYPT_POLICY_V1) {\n" + "> +\tif (policy->version == FSCRYPT_POLICY_V1) {\n" "> +\t\t/*\n" "> +\t\t * The original encryption policy version provided no way of\n" "> +\t\t * verifying that the correct master key was supplied, which was\n" @@ -54,6 +54,10 @@ "But we don't allow keys usable by V1 policies to be used in the\n" "filesystem-specific keyring, do we?\n" "\n" - "\t\t\t\t\t\t- Ted" + "\t\t\t\t\t\t- Ted\n" + "\n" + "______________________________________________________\n" + "Linux MTD discussion mailing list\n" + http://lists.infradead.org/mailman/listinfo/linux-mtd/ -94ebc27a685ef97f6e266d501c8d3a7e8831a5211fd1d55965ab1e5c06d1f56c +6d75f0b3bd571d72fc8c0afcc06ddcf7f69665ded01d25e624fbf1c2de0ea6a5
diff --git a/a/1.txt b/N2/1.txt index ac77516..09730a4 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -5,7 +5,7 @@ On Fri, Jul 26, 2019 at 03:41:35PM -0700, Eric Biggers wrote: > > + if (arg.key_spec.type != FSCRYPT_KEY_SPEC_TYPE_DESCRIPTOR) { -This should be "= FSCRYPT_KEY_SPEC_TYPE_INDENTIFIER" instead. That's +This should be "== FSCRYPT_KEY_SPEC_TYPE_INDENTIFIER" instead. That's because you use the identifier part of the union: > + /* Calculate the key identifier and return it to userspace. */ @@ -16,7 +16,7 @@ because you use the identifier part of the union: If we ever add a new key specifier type, and alternative in the union, this is going to come back to bite us. -> + if (policy->version = FSCRYPT_POLICY_V1) { +> + if (policy->version == FSCRYPT_POLICY_V1) { > + /* > + * The original encryption policy version provided no way of > + * verifying that the correct master key was supplied, which was diff --git a/a/content_digest b/N2/content_digest index 871a10f..9c463a2 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,18 +2,18 @@ "ref\020190726224141.14044-11-ebiggers@kernel.org\0" "From\0Theodore Y. Ts'o <tytso@mit.edu>\0" "Subject\0Re: [PATCH v7 10/16] fscrypt: v2 encryption policy support\0" - "Date\0Sun, 28 Jul 2019 21:17:30 +0000\0" + "Date\0Sun, 28 Jul 2019 17:17:30 -0400\0" "To\0Eric Biggers <ebiggers@kernel.org>\0" - "Cc\0Satya Tangirala <satyat@google.com>" - linux-api@vger.kernel.org + "Cc\0linux-fscrypt@vger.kernel.org" + linux-fsdevel@vger.kernel.org + linux-ext4@vger.kernel.org linux-f2fs-devel@lists.sourceforge.net - linux-fscrypt@vger.kernel.org - keyrings@vger.kernel.org linux-mtd@lists.infradead.org + linux-api@vger.kernel.org linux-crypto@vger.kernel.org - linux-fsdevel@vger.kernel.org - linux-ext4@vger.kernel.org - " Paul Crowley <paulcrowley@google.com>\0" + keyrings@vger.kernel.org + Paul Crowley <paulcrowley@google.com> + " Satya Tangirala <satyat@google.com>\0" "\00:1\0" "b\0" "On Fri, Jul 26, 2019 at 03:41:35PM -0700, Eric Biggers wrote:\n" @@ -23,7 +23,7 @@ "> \n" "> +\tif (arg.key_spec.type != FSCRYPT_KEY_SPEC_TYPE_DESCRIPTOR) {\n" "\n" - "This should be \"= FSCRYPT_KEY_SPEC_TYPE_INDENTIFIER\" instead. That's\n" + "This should be \"== FSCRYPT_KEY_SPEC_TYPE_INDENTIFIER\" instead. That's\n" "because you use the identifier part of the union:\n" "\n" "> +\t\t/* Calculate the key identifier and return it to userspace. */\n" @@ -34,7 +34,7 @@ "If we ever add a new key specifier type, and alternative in the union,\n" "this is going to come back to bite us.\n" "\n" - "> +\tif (policy->version = FSCRYPT_POLICY_V1) {\n" + "> +\tif (policy->version == FSCRYPT_POLICY_V1) {\n" "> +\t\t/*\n" "> +\t\t * The original encryption policy version provided no way of\n" "> +\t\t * verifying that the correct master key was supplied, which was\n" @@ -56,4 +56,4 @@ "\n" "\t\t\t\t\t\t- Ted" -94ebc27a685ef97f6e266d501c8d3a7e8831a5211fd1d55965ab1e5c06d1f56c +13f848977023f7f3b04271045a02028ce9ba0f330b8477733177a9751c76e8ba
diff --git a/a/1.txt b/N3/1.txt index ac77516..00f731c 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -5,7 +5,7 @@ On Fri, Jul 26, 2019 at 03:41:35PM -0700, Eric Biggers wrote: > > + if (arg.key_spec.type != FSCRYPT_KEY_SPEC_TYPE_DESCRIPTOR) { -This should be "= FSCRYPT_KEY_SPEC_TYPE_INDENTIFIER" instead. That's +This should be "== FSCRYPT_KEY_SPEC_TYPE_INDENTIFIER" instead. That's because you use the identifier part of the union: > + /* Calculate the key identifier and return it to userspace. */ @@ -16,7 +16,7 @@ because you use the identifier part of the union: If we ever add a new key specifier type, and alternative in the union, this is going to come back to bite us. -> + if (policy->version = FSCRYPT_POLICY_V1) { +> + if (policy->version == FSCRYPT_POLICY_V1) { > + /* > + * The original encryption policy version provided no way of > + * verifying that the correct master key was supplied, which was @@ -37,3 +37,9 @@ But we don't allow keys usable by V1 policies to be used in the filesystem-specific keyring, do we? - Ted + + +_______________________________________________ +Linux-f2fs-devel mailing list +Linux-f2fs-devel@lists.sourceforge.net +https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel diff --git a/a/content_digest b/N3/content_digest index 871a10f..613e108 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -1,8 +1,8 @@ "ref\020190726224141.14044-1-ebiggers@kernel.org\0" "ref\020190726224141.14044-11-ebiggers@kernel.org\0" "From\0Theodore Y. Ts'o <tytso@mit.edu>\0" - "Subject\0Re: [PATCH v7 10/16] fscrypt: v2 encryption policy support\0" - "Date\0Sun, 28 Jul 2019 21:17:30 +0000\0" + "Subject\0Re: [f2fs-dev] [PATCH v7 10/16] fscrypt: v2 encryption policy support\0" + "Date\0Sun, 28 Jul 2019 17:17:30 -0400\0" "To\0Eric Biggers <ebiggers@kernel.org>\0" "Cc\0Satya Tangirala <satyat@google.com>" linux-api@vger.kernel.org @@ -23,7 +23,7 @@ "> \n" "> +\tif (arg.key_spec.type != FSCRYPT_KEY_SPEC_TYPE_DESCRIPTOR) {\n" "\n" - "This should be \"= FSCRYPT_KEY_SPEC_TYPE_INDENTIFIER\" instead. That's\n" + "This should be \"== FSCRYPT_KEY_SPEC_TYPE_INDENTIFIER\" instead. That's\n" "because you use the identifier part of the union:\n" "\n" "> +\t\t/* Calculate the key identifier and return it to userspace. */\n" @@ -34,7 +34,7 @@ "If we ever add a new key specifier type, and alternative in the union,\n" "this is going to come back to bite us.\n" "\n" - "> +\tif (policy->version = FSCRYPT_POLICY_V1) {\n" + "> +\tif (policy->version == FSCRYPT_POLICY_V1) {\n" "> +\t\t/*\n" "> +\t\t * The original encryption policy version provided no way of\n" "> +\t\t * verifying that the correct master key was supplied, which was\n" @@ -54,6 +54,12 @@ "But we don't allow keys usable by V1 policies to be used in the\n" "filesystem-specific keyring, do we?\n" "\n" - "\t\t\t\t\t\t- Ted" + "\t\t\t\t\t\t- Ted\n" + "\n" + "\n" + "_______________________________________________\n" + "Linux-f2fs-devel mailing list\n" + "Linux-f2fs-devel@lists.sourceforge.net\n" + https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel -94ebc27a685ef97f6e266d501c8d3a7e8831a5211fd1d55965ab1e5c06d1f56c +283e8a2a0a2bdb9aee35e59577edb61a0b596966a0e5c47242b2479647ba3889
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.