From: Christoph Hellwig <hch@lst.de>
To: Bharath Vedartham <linux.bhar@gmail.com>
Cc: sivanich@sgi.com, arnd@arndb.de, ira.weiny@intel.com,
jhubbard@nvidia.com, jglisse@redhat.com,
gregkh@linuxfoundation.org, william.kucharski@oracle.com,
hch@lst.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 1/1] sgi-gru: Remove *pte_lookup functions
Date: Mon, 29 Jul 2019 08:48:42 +0200 [thread overview]
Message-ID: <20190729064842.GA3853@lst.de> (raw)
In-Reply-To: <1564170120-11882-2-git-send-email-linux.bhar@gmail.com>
On Sat, Jul 27, 2019 at 01:12:00AM +0530, Bharath Vedartham wrote:
> + ret = get_user_pages_fast(vaddr, 1, write, &page);
I think you want to pass "write ? FOLL_WRITE : 0" here, as
get_user_pages_fast takes a gup_flags argument, not a boolean
write flag.
next prev parent reply other threads:[~2019-07-29 6:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 19:41 [PATCH v3 0/1] get_user_pages changes Bharath Vedartham
2019-07-26 19:42 ` [PATCH v3 1/1] sgi-gru: Remove *pte_lookup functions Bharath Vedartham
2019-07-27 9:22 ` Hillf Danton
2019-07-28 17:56 ` Bharath Vedartham
2019-07-29 6:48 ` Christoph Hellwig [this message]
2019-07-30 10:26 ` Bharath Vedartham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729064842.GA3853@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux.bhar@gmail.com \
--cc=sivanich@sgi.com \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.