From: Kees Cook <keescook@chromium.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] usb: phy: ab8500-usb: Mark expected switch fall-throughs
Date: Mon, 29 Jul 2019 09:36:40 -0700 [thread overview]
Message-ID: <201907290936.F5F486A6F@keescook> (raw)
In-Reply-To: <20190729000631.GA24165@embeddedor>
On Sun, Jul 28, 2019 at 07:06:31PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/usb/phy/phy-ab8500-usb.c: In function 'ab8500_usb_link_status_update':
> drivers/usb/phy/phy-ab8500-usb.c:424:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
> event = UX500_MUSB_RIDB;
> ~~~~~~^~~~~~~~~~~~~~~~~
> drivers/usb/phy/phy-ab8500-usb.c:425:2: note: here
> case USB_LINK_NOT_CONFIGURED_8500:
> ^~~~
> drivers/usb/phy/phy-ab8500-usb.c:440:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
> event = UX500_MUSB_RIDC;
> ~~~~~~^~~~~~~~~~~~~~~~~
> drivers/usb/phy/phy-ab8500-usb.c:441:2: note: here
> case USB_LINK_STD_HOST_NC_8500:
> ^~~~
> drivers/usb/phy/phy-ab8500-usb.c:459:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
> event = UX500_MUSB_RIDA;
> ~~~~~~^~~~~~~~~~~~~~~~~
> drivers/usb/phy/phy-ab8500-usb.c:460:2: note: here
> case USB_LINK_HM_IDGND_8500:
> ^~~~
> drivers/usb/phy/phy-ab8500-usb.c: In function 'ab8505_usb_link_status_update':
> drivers/usb/phy/phy-ab8500-usb.c:332:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
> event = UX500_MUSB_RIDB;
> ~~~~~~^~~~~~~~~~~~~~~~~
> drivers/usb/phy/phy-ab8500-usb.c:333:2: note: here
> case USB_LINK_NOT_CONFIGURED_8505:
> ^~~~
> drivers/usb/phy/phy-ab8500-usb.c:352:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
> event = UX500_MUSB_RIDC;
> ~~~~~~^~~~~~~~~~~~~~~~~
> drivers/usb/phy/phy-ab8500-usb.c:353:2: note: here
> case USB_LINK_STD_HOST_NC_8505:
> ^~~~
> drivers/usb/phy/phy-ab8500-usb.c:370:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
> event = UX500_MUSB_RIDA;
> ~~~~~~^~~~~~~~~~~~~~~~~
> drivers/usb/phy/phy-ab8500-usb.c:371:2: note: here
> case USB_LINK_HM_IDGND_8505:
> ^~~~
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> drivers/usb/phy/phy-ab8500-usb.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/usb/phy/phy-ab8500-usb.c b/drivers/usb/phy/phy-ab8500-usb.c
> index aaf363f19714..14b432982fd3 100644
> --- a/drivers/usb/phy/phy-ab8500-usb.c
> +++ b/drivers/usb/phy/phy-ab8500-usb.c
> @@ -330,6 +330,7 @@ static int ab8505_usb_link_status_update(struct ab8500_usb *ab,
> switch (lsts) {
> case USB_LINK_ACA_RID_B_8505:
> event = UX500_MUSB_RIDB;
> + /* Fall through */
> case USB_LINK_NOT_CONFIGURED_8505:
> case USB_LINK_RESERVED0_8505:
> case USB_LINK_RESERVED1_8505:
> @@ -350,6 +351,7 @@ static int ab8505_usb_link_status_update(struct ab8500_usb *ab,
>
> case USB_LINK_ACA_RID_C_NM_8505:
> event = UX500_MUSB_RIDC;
> + /* Fall through */
> case USB_LINK_STD_HOST_NC_8505:
> case USB_LINK_STD_HOST_C_NS_8505:
> case USB_LINK_STD_HOST_C_S_8505:
> @@ -368,6 +370,7 @@ static int ab8505_usb_link_status_update(struct ab8500_usb *ab,
> case USB_LINK_ACA_RID_A_8505:
> case USB_LINK_ACA_DOCK_CHGR_8505:
> event = UX500_MUSB_RIDA;
> + /* Fall through */
> case USB_LINK_HM_IDGND_8505:
> if (ab->mode == USB_IDLE) {
> ab->mode = USB_HOST;
> @@ -422,6 +425,7 @@ static int ab8500_usb_link_status_update(struct ab8500_usb *ab,
> switch (lsts) {
> case USB_LINK_ACA_RID_B_8500:
> event = UX500_MUSB_RIDB;
> + /* Fall through */
> case USB_LINK_NOT_CONFIGURED_8500:
> case USB_LINK_NOT_VALID_LINK_8500:
> ab->mode = USB_IDLE;
> @@ -438,6 +442,7 @@ static int ab8500_usb_link_status_update(struct ab8500_usb *ab,
> case USB_LINK_ACA_RID_C_HS_8500:
> case USB_LINK_ACA_RID_C_HS_CHIRP_8500:
> event = UX500_MUSB_RIDC;
> + /* Fall through */
> case USB_LINK_STD_HOST_NC_8500:
> case USB_LINK_STD_HOST_C_NS_8500:
> case USB_LINK_STD_HOST_C_S_8500:
> @@ -457,6 +462,7 @@ static int ab8500_usb_link_status_update(struct ab8500_usb *ab,
>
> case USB_LINK_ACA_RID_A_8500:
> event = UX500_MUSB_RIDA;
> + /* Fall through */
> case USB_LINK_HM_IDGND_8500:
> if (ab->mode == USB_IDLE) {
> ab->mode = USB_HOST;
> --
> 2.22.0
>
--
Kees Cook
next prev parent reply other threads:[~2019-07-29 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 0:06 [PATCH] usb: phy: ab8500-usb: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-29 16:36 ` Kees Cook [this message]
2019-09-13 18:00 ` Olof Johansson
2019-09-13 18:01 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201907290936.F5F486A6F@keescook \
--to=keescook@chromium.org \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.