From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: cohuck@redhat.com, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/2] Revert "hw: report invalid disable-legacy|modern usage for virtio-1-only devs"
Date: Mon, 29 Jul 2019 17:31:24 +0100 [thread overview]
Message-ID: <20190729163124.GU32718@redhat.com> (raw)
In-Reply-To: <20190729162903.4489-3-dgilbert@redhat.com>
On Mon, Jul 29, 2019 at 05:29:03PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> This reverts commit f2784eed306449c3d04a71a05ed6463b8289aedf
> since that accidentally removes the PCIe capabilities from virtio
> devices because virtio_pci_dc_realize is called before the new 'mode'
> flag is set.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/core/machine.c | 23 +++--------------------
> hw/display/virtio-gpu-pci.c | 4 +---
> hw/display/virtio-vga.c | 4 +---
> hw/virtio/virtio-crypto-pci.c | 4 +---
> hw/virtio/virtio-input-pci.c | 4 +---
> hw/virtio/virtio-pci.c | 26 ++++++++++----------------
> hw/virtio/virtio-pci.h | 31 ++++++-------------------------
> 7 files changed, 23 insertions(+), 73 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-07-29 16:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 16:29 [Qemu-devel] [For 4.1 PATCH v2 0/2] Reversions to fix PCIe in virtio Dr. David Alan Gilbert (git)
2019-07-29 16:29 ` [Qemu-devel] [PATCH v2 1/2] Revert "Revert "globals: Allow global properties to be optional"" Dr. David Alan Gilbert (git)
2019-07-29 21:16 ` [Qemu-devel] [PULL 1/3] " Michael S. Tsirkin
2019-07-29 16:30 ` [Qemu-devel] [PATCH v2 1/2] " Daniel P. Berrangé
2019-07-29 16:46 ` Cornelia Huck
2019-07-29 16:29 ` [Qemu-devel] [PATCH v2 2/2] Revert "hw: report invalid disable-legacy|modern usage for virtio-1-only devs" Dr. David Alan Gilbert (git)
2019-07-29 21:16 ` [Qemu-devel] [PULL 2/3] " Michael S. Tsirkin
2019-07-29 16:31 ` Daniel P. Berrangé [this message]
2019-07-29 16:46 ` [Qemu-devel] [PATCH v2 2/2] " Cornelia Huck
2019-07-29 16:32 ` [Qemu-devel] [For 4.1 PATCH v2 0/2] Reversions to fix PCIe in virtio Cornelia Huck
2019-07-29 16:35 ` Dr. David Alan Gilbert
2019-07-29 16:43 ` Peter Maydell
2019-07-29 16:45 ` Daniel P. Berrangé
-- strict thread matches above, loose matches on Subject: below --
2019-07-29 21:15 [Qemu-devel] [PULL 0/3] virtio, pc: fixes Michael S. Tsirkin
2019-07-23 16:08 ` [Qemu-devel] [PATCH] pc-dimm: fix crash when invalid slot number is used Igor Mammedov
2019-07-29 21:16 ` [Qemu-devel] [PULL 3/3] " Michael S. Tsirkin
2019-07-24 3:18 ` [Qemu-devel] [PATCH] " David Gibson
2019-07-24 6:13 ` Li Qiang
2019-07-24 6:39 ` Pankaj Gupta
2019-07-30 12:36 ` [Qemu-devel] [PULL 3/3] " Igor Mammedov
2019-07-30 15:50 ` Michael S. Tsirkin
2019-07-30 9:44 ` [Qemu-devel] [PULL 0/3] virtio, pc: fixes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729163124.GU32718@redhat.com \
--to=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.