From: Cornelia Huck <cohuck@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: berrange@redhat.com, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [for 4.1 PATCH] Revert "hw: report invalid disable-legacy|modern usage for virtio-1-only devs"
Date: Mon, 29 Jul 2019 18:18:22 +0200 [thread overview]
Message-ID: <20190729181822.55995f92.cohuck@redhat.com> (raw)
In-Reply-To: <20190729155909.22804-1-dgilbert@redhat.com>
On Mon, 29 Jul 2019 16:59:09 +0100
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> This reverts commit f2784eed306449c3d04a71a05ed6463b8289aedf
> since that accidentally removes the PCIe capabilities from virtio
> devices because virtio_pci_dc_realize is called before the new 'mode'
> flag is set.
Yes, this is probably too hairy to fix for 4.1; but the change might be
worthwhile to revisit for 4.2.
> I keep the expanded hw_compat entry because we've lost the ability to
> do 'optional'.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/display/virtio-gpu-pci.c | 4 +---
> hw/display/virtio-vga.c | 4 +---
> hw/virtio/virtio-crypto-pci.c | 4 +---
> hw/virtio/virtio-input-pci.c | 4 +---
> hw/virtio/virtio-pci.c | 26 ++++++++++----------------
> hw/virtio/virtio-pci.h | 31 ++++++-------------------------
> 6 files changed, 20 insertions(+), 53 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
prev parent reply other threads:[~2019-07-29 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 15:59 [Qemu-devel] [for 4.1 PATCH] Revert "hw: report invalid disable-legacy|modern usage for virtio-1-only devs" Dr. David Alan Gilbert (git)
2019-07-29 16:03 ` Daniel P. Berrangé
2019-07-29 16:24 ` Dr. David Alan Gilbert
2019-07-29 16:18 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729181822.55995f92.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.