Re: [meta-oe][PATCH v4] usbguard: Initial recipe

[Adrian Bunk <bunk@stusta.de>]

On Mon, Jul 29, 2019 at 07:40:43AM -0700, Khem Raj wrote:
> there are build failures still
> 
> https://errors.yoctoproject.org/Errors/Details/255457/

+DEPENDS = "protobuf-native libxml2-native libxslt-native xmlto-native glib-2.0-native \
+       dbus dbus-glib libqb libcap-ng libgcrypt libsodium protobuf pegtl"
...
+PACKAGECONFIG ??= "libsodium \
+       ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+       ${@bb.utils.filter('DISTRO_FEATURES', 'polkit', d)}"
+
+PACKAGECONFIG[systemd]   = "--enable-systemd,--disable-systemd"
+PACKAGECONFIG[libsodium] = "--with-crypto-library=sodium"
+PACKAGECONFIG[libgcrypt] = "--with-crypto-library=gcrypt"
+PACKAGECONFIG[polkit]    = "--with-polkit,--without-polkit"
+PACKAGECONFIG[dbus]      = "--with-dbus,--without-dbus"

The problem is that dependencies should be added as third parameter to 
PACKAGECONFIG, which is missing here for polkit.

Note that there is also the (less harmful) opposite problem here:
The libsodium, libgcrypt and dbus/dbus-glib dependencies are likely only 
required when the corresponding functionality is enabled via PACKAGECONFIG.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed