All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: uclinux-h8-devel@lists.sourceforge.jp, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] h8300: Add missing symbol "BOOT_LINK_OFFSET"
Date: Tue, 30 Jul 2019 08:49:06 -0700	[thread overview]
Message-ID: <20190730154906.GA18870@roeck-us.net> (raw)

On Wed, Jul 17, 2019 at 10:55:00PM +0900, Yoshinori Sato wrote:
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
>  arch/h8300/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/h8300/Kconfig b/arch/h8300/Kconfig
> index ecfc4b4b6373..6974513b1ae9 100644
> --- a/arch/h8300/Kconfig
> +++ b/arch/h8300/Kconfig
> @@ -45,4 +45,7 @@ config NR_CPUS
>  	int
>  	default 1
>  
> +config BOOT_LINK_OFFSET
> +	hex	"zImage link offset"
> +

"hex" requires a default value. The above declaration generates
"CONFIG_BOOT_LINK_OFFSET=" in the configuration file, which is invalid
and can not be fixed with "make ARCH=h8300 olddefconfig". This in turn
results in "make" requesting a value when it encounters the symbol,
meaning that automated builds of h8300 images are no longer possible,
at least not without workarounds.

Guenter

             reply	other threads:[~2019-07-30 15:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 15:49 Guenter Roeck [this message]
2019-08-13 10:21 ` [PATCH] h8300: Add missing symbol "BOOT_LINK_OFFSET" Yoshinori Sato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730154906.GA18870@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uclinux-h8-devel@lists.sourceforge.jp \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.