All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: Ankur Tyagi <ankur.tyagi85@gmail.com>
Cc: meta-arago@arago-project.org
Subject: Re: [oe-layersetup][PATCH] oe-layersetup.sh: Fix printf error if repo uri has space
Date: Tue, 30 Jul 2019 14:05:27 -0400	[thread overview]
Message-ID: <20190730180527.GE459@beryl> (raw)
In-Reply-To: <CADySD0F3WVdq=uu9tWLeBTT=0Vc=WMgYLSETJaFbd0Mh79-wjg@mail.gmail.com>

Merged, thanks!

On Sun, Jul 28, 2019 at 10:21:46PM +1200, Ankur Tyagi wrote:
> ping
> 
> regards
> Ankur
> 
> On Thu, Jul 25, 2019 at 5:27 PM Ankur Tyagi <ankur.tyagi85@gmail.com> wrote:
> >
> > If repo uri has space, then url will have '%20'
> > and script gives follwoing error
> > bash: printf: 'M': invalid format character
> >
> > Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
> > ---
> >  oe-layertool-setup.sh | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/oe-layertool-setup.sh b/oe-layertool-setup.sh
> > index 5a0175d..d14ed4f 100755
> > --- a/oe-layertool-setup.sh
> > +++ b/oe-layertool-setup.sh
> > @@ -276,12 +276,12 @@ configure_repo() {
> >
> >      # Check if the repo with $name was already seen.  Use the , at the end
> >      # of the grep to avoid matching similar named repos.
> > -    temp=`printf "$output\n" | grep -e "^$name,"`
> > +    temp=`printf '%s\n' $output | grep -e "^$name,"`
> >
> >      if [ "x$temp" != "x" ]
> >      then
> >          echo "This repository ($name) has already been configured with the following values:"
> > -        printf "\t$temp\n"
> > +        printf '\t%s\n' $temp
> >          echo "Skipping configuring duplicate repository"
> >          return 1
> >      fi
> > @@ -928,7 +928,7 @@ then
> >      then
> >          mkdir -p $dir
> >      fi
> > -    printf "$output\n" > $outputfile
> > +    printf '%s\n' $output > $outputfile
> >      echo "Output file is $outputfile"
> >  fi
> >
> > --
> > 2.17.1
> >
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


      reply	other threads:[~2019-07-30 18:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-25  5:27 [oe-layersetup][PATCH] oe-layersetup.sh: Fix printf error if repo uri has space Ankur Tyagi
2019-07-28 10:21 ` Ankur Tyagi
2019-07-30 18:05   ` Denys Dmytriyenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730180527.GE459@beryl \
    --to=denys@ti.com \
    --cc=ankur.tyagi85@gmail.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.