From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Dmitry Safonov <dima@arista.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Dmitry Safonov" <0x7f454c46@gmail.com>,
"Andrei Vagin" <avagin@openvz.org>
Subject: Re: [PATCHv2] send-email: Ask if a patch should be sent twice
Date: Tue, 30 Jul 2019 21:19:07 +0200 [thread overview]
Message-ID: <20190730191907.GQ20404@szeder.dev> (raw)
In-Reply-To: <20190730162624.9226-1-dima@arista.com>
On Tue, Jul 30, 2019 at 05:26:24PM +0100, Dmitry Safonov wrote:
> + if (@dupes) {
> + printf(__("Patches specified several times: \n"));
Is this message translated? (I don't know what __("<str>") does in
Perl.) If it is, then ...
> @@ -589,6 +591,19 @@ test_expect_success $PREREQ 'In-Reply-To with --chain-reply-to' '
> test_cmp expect actual
> '
>
> +test_expect_success $PREREQ 'ask confirmation for double-send' '
> + clean_fake_sendmail &&
> + echo y | \
> + GIT_SEND_EMAIL_NOTTY=1 \
> + git send-email --from=author@example.com \
> + --to=nobody@example.com \
> + --smtp-server="$(pwd)/fake.sendmail" \
> + --validate \
> + $patches $patches $patches \
> + >stdout &&
> + ! grep "Patches specified several times: " stdout
... this here should be 'test_i18ngrep' instead of plain old 'grep'.
next prev parent reply other threads:[~2019-07-30 19:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 16:26 [PATCHv2] send-email: Ask if a patch should be sent twice Dmitry Safonov
2019-07-30 19:19 ` SZEDER Gábor [this message]
2019-07-30 19:35 ` Junio C Hamano
2019-07-30 20:26 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730191907.GQ20404@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=0x7f454c46@gmail.com \
--cc=avagin@openvz.org \
--cc=avarab@gmail.com \
--cc=dima@arista.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.