From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lunn.ch (client-ip=185.16.172.187; helo=vps0.lunn.ch; envelope-from=andrew@lunn.ch; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=lunn.ch header.i=@lunn.ch header.b="uKiCIlvC"; dkim-atps=neutral Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45ywyG11mZzDqYt for ; Wed, 31 Jul 2019 11:36:53 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MbVNcIqleGWDajEIzwbSrkr9UJ2vlKBIQWs7BCgs3Qk=; b=uKiCIlvCjadlgle851de+bSidr L+ClxfKg5jnk5yCPW2X8DH+7FvSUHNPBsCxjts2ILx7hHkhovl3GiFk58BHdK1l1oJ5cuFmLEZfQg JX3N8fTjHfLsWIp1rnCUuB5PKECKrVr+zPJMigo2OjJ40dP2TVA+g7EHsXk5BY80CT24=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hsdXg-0003Cz-DV; Wed, 31 Jul 2019 03:36:36 +0200 Date: Wed, 31 Jul 2019 03:36:36 +0200 From: Andrew Lunn To: Tao Ren Cc: Vladimir Oltean , Florian Fainelli , Heiner Kallweit , "David S . Miller" , Arun Parameswaran , Justin Chen , netdev , lkml , Andrew Jeffery , "openbmc@lists.ozlabs.org" Subject: Re: [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S Message-ID: <20190731013636.GC25700@lunn.ch> References: <20190730002549.86824-1-taoren@fb.com> <3987251b-9679-dfbe-6e15-f991c2893bac@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jul 2019 01:36:58 -0000 > The INTF_SEL pins report correct mode (RGMII-Fiber) on my machine, > but there are 2 "sub-modes" (1000Base-X and 100Base-FX) and I > couldn't find a proper/safe way to auto-detect which "sub-mode" is > active. The datasheet just describes instructions to enable a > specific mode, but it doesn't say 1000Base-X/100Base-FX mode will be > auto-selected. And that's why I came up with the patch to specify > 1000Base-X mode. Fibre does not perform any sort of auto-negotiation. I assume you have an SFP connected? When using PHYLINK, the sfp driver will get the supported baud rate from SFP EEPROM to determine what speed could be used. However, there is currently no mainline support for having a chain MAC-PHY-SFP. For that you need Russells out of tree patches. Andrew