All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Tejun Heo <tj@kernel.org>, Hannes Reinecke <hare@suse.com>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	Alexandru Moise <00moses.alexander00@gmail.com>,
	Joseph Qi <joseph.qi@linux.alibaba.com>
Subject: Re: [PATCH 1/2] block: Verify whether blk_queue_enter() is used when necessary
Date: Wed, 31 Jul 2019 09:46:44 +0800	[thread overview]
Message-ID: <20190731014643.GA4822@ming.t460p> (raw)
In-Reply-To: <20190730181757.248832-2-bvanassche@acm.org>

On Tue, Jul 30, 2019 at 11:17:56AM -0700, Bart Van Assche wrote:
> It is required to protect blkg_lookup() calls with a blk_queue_enter() /
> blk_queue_exit() pair. Since it is nontrivial to verify whether this is

Could you explain the reason why the blk_queue_enter()/blk_queue_exit()
pair is required for blkg_lookup()? And comment on blkg_lookup() only
mentioned RCU read lock is needed.

The request queue reference counter is supposed to be held for any
caller of submit_bio(), why isn't that ref count enough?

Thanks,
Ming

  reply	other threads:[~2019-07-31  1:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 18:17 [PATCH 0/2] Fix a race condition triggered by submit_bio() Bart Van Assche
2019-07-30 18:17 ` [PATCH 1/2] block: Verify whether blk_queue_enter() is used when necessary Bart Van Assche
2019-07-31  1:46   ` Ming Lei [this message]
2019-07-31 18:26     ` Bart Van Assche
2019-07-30 18:17 ` [PATCH 2/2] block: Fix a race condition in submit_bio() Bart Van Assche
2019-07-30 18:18   ` syzbot
2019-07-31  1:53   ` Ming Lei
2019-07-31  1:53     ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190731014643.GA4822@ming.t460p \
    --to=ming.lei@redhat.com \
    --cc=00moses.alexander00@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=hare@suse.com \
    --cc=hch@lst.de \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.