From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Song Liu <songliubraving@fb.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, matthew.wilcox@oracle.com,
kirill.shutemov@linux.intel.com, oleg@redhat.com,
kernel-team@fb.com, william.kucharski@oracle.com
Subject: Re: [PATCH v11 2/4] uprobe: use original page when all uprobes are removed
Date: Wed, 31 Jul 2019 12:10:12 +0530 [thread overview]
Message-ID: <20190731064012.GA11365@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190730193100.2295258-1-songliubraving@fb.com>
* Song Liu <songliubraving@fb.com> [2019-07-30 12:30:59]:
> Currently, uprobe swaps the target page with a anonymous page in both
> install_breakpoint() and remove_breakpoint(). When all uprobes on a page
> are removed, the given mm is still using an anonymous page (not the
> original page).
>
> This patch allows uprobe to use original page when possible (all uprobes
> on the page are already removed, and the original page is in page cache
> and uptodate).
>
> As suggested by Oleg, we unmap the old_page and let the original page
> fault in.
>
> Suggested-by: Oleg Nesterov <oleg@redhat.com>
> Signed-off-by: Song Liu <songliubraving@fb.com>
Looks good to me.
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
--
Thanks and Regards
Srikar Dronamraju
prev parent reply other threads:[~2019-07-31 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 19:30 [PATCH v11 2/4] uprobe: use original page when all uprobes are removed Song Liu
2019-07-30 19:31 ` [PATCH v11 3/4] mm, thp: introduce FOLL_SPLIT_PMD Song Liu
2019-07-31 6:40 ` Srikar Dronamraju [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731064012.GA11365@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-team@fb.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.wilcox@oracle.com \
--cc=oleg@redhat.com \
--cc=songliubraving@fb.com \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.