From: Clark Williams <williams@redhat.com>
To: Juri Lelli <juri.lelli@redhat.com>
Cc: tglx@linutronix.de, bigeasy@linutronix.de, rostedt@goodmis.org,
linux-rt-users@vger.kernel.org, peterz@infradead.org,
linux-kernel@vger.kernel.org, bristot@redhat.com
Subject: Re: [RT PATCH] sched/deadline: Make inactive timer run in hardirq context
Date: Wed, 31 Jul 2019 09:25:07 -0500 [thread overview]
Message-ID: <20190731092507.3c57d4db@torg.hsv.redhat.com> (raw)
In-Reply-To: <20190731103715.4047-1-juri.lelli@redhat.com>
On Wed, 31 Jul 2019 12:37:15 +0200
Juri Lelli <juri.lelli@redhat.com> wrote:
> SCHED_DEADLINE inactive timer needs to run in hardirq context (as
> dl_task_timer already does).
>
> Make it HRTIMER_MODE_REL_HARD.
>
> Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
> ---
> Hi,
>
> Both v4.19-rt and v5.2-rt need this.
>
> Mainline "sched: Mark hrtimers to expire in hard interrupt context"
> series needs this as well (20190726185753.077004842@linutronix.de in
> particular). Do I need to send out a separate patch for it?
>
> Best,
>
> Juri
> ---
> kernel/sched/deadline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 1794e152d888..0889674b8915 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1292,7 +1292,7 @@ void init_dl_inactive_task_timer(struct sched_dl_entity *dl_se)
> {
> struct hrtimer *timer = &dl_se->inactive_timer;
>
> - hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> + hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_HARD);
> timer->function = inactive_task_timer;
> }
>
> --
> 2.17.2
>
Acked-by: Clark Williams <williams@redhat.com>
--
The United States Coast Guard
Ruining Natural Selection since 1790
next prev parent reply other threads:[~2019-07-31 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 10:37 [RT PATCH] sched/deadline: Make inactive timer run in hardirq context Juri Lelli
2019-07-31 11:07 ` [tip:timers/core] sched/deadline: Ensure inactive_timer runs " tip-bot for Juri Lelli
2019-07-31 11:56 ` [RT PATCH] sched/deadline: Make inactive timer run " Daniel Bristot de Oliveira
2019-07-31 14:25 ` Clark Williams [this message]
2019-08-01 16:00 ` [tip:timers/core] sched/deadline: Ensure inactive_timer runs " tip-bot for Juri Lelli
2019-08-01 19:05 ` tip-bot for Juri Lelli
2019-08-13 13:09 ` [RT PATCH] sched/deadline: Make inactive timer run " Sebastian Andrzej Siewior
2019-08-13 13:19 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731092507.3c57d4db@torg.hsv.redhat.com \
--to=williams@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=bristot@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.