All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Todd Kjos <tkjos@android.com>
Cc: tkjos@google.com, arve@android.com, maco@google.com,
	stable@vger.kernel.org, joel@joelfernandes.org,
	kernel-team@android.com
Subject: Re: [PATCH 4.14,4.19] binder: fix possible UAF when freeing buffer
Date: Wed, 31 Jul 2019 11:47:59 +0200	[thread overview]
Message-ID: <20190731094759.GI18269@kroah.com> (raw)
In-Reply-To: <20190729221606.243098-1-tkjos@google.com>

On Mon, Jul 29, 2019 at 03:16:06PM -0700, Todd Kjos wrote:
> From: Todd Kjos <tkjos@android.com>
> 
> commit a370003cc301d4361bae20c9ef615f89bf8d1e8a upstream
> 
> There is a race between the binder driver cleaning
> up a completed transaction via binder_free_transaction()
> and a user calling binder_ioctl(BC_FREE_BUFFER) to
> release a buffer. It doesn't matter which is first but
> they need to be protected against running concurrently
> which can result in a UAF.
> 
> Signed-off-by: Todd Kjos <tkjos@google.com>
> Cc: stable <stable@vger.kernel.org> # 4.14 4.19
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/android/binder.c | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)

Thanks for the backport, now queued up.

greg k-h

      reply	other threads:[~2019-07-31  9:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 22:16 [PATCH 4.14,4.19] binder: fix possible UAF when freeing buffer Todd Kjos
2019-07-31  9:47 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190731094759.GI18269@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=joel@joelfernandes.org \
    --cc=kernel-team@android.com \
    --cc=maco@google.com \
    --cc=stable@vger.kernel.org \
    --cc=tkjos@android.com \
    --cc=tkjos@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.