From: Petr Vorel <pvorel@suse.cz>
To: YueHaibing <yuehaibing@huawei.com>
Cc: jikos@kernel.org, benjamin.tissoires@redhat.com,
hdegoede@redhat.com, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: logitech-dj: Fix check of logi_dj_recv_query_paired_devices()
Date: Wed, 31 Jul 2019 13:06:29 +0200 [thread overview]
Message-ID: <20190731110629.GB5092@dell5510> (raw)
In-Reply-To: <20190731105927.GA5092@dell5510>
Hi,
> > In delayedwork_callback(), logi_dj_recv_query_paired_devices
> > may return positive value while success now, so check it
> > correctly.
> > Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices")
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
OK, not only it didn't fix problems with logitech mouse (see below),
but removing mouses USB dongle effectively crashes kernel, so this one probably
shouldn't be applied :).
[ 330.721629] logitech-djreceiver: probe of 0003:046D:C52F.0013 failed with error 7
[ 331.462335] hid 0003:046D:C52F.0013: delayedwork_callback: logi_dj_recv_query_paired_devices error: 7
Kind regards,
Petr
next prev parent reply other threads:[~2019-07-31 11:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 14:57 [PATCH] HID: logitech-dj: Fix check of logi_dj_recv_query_paired_devices() YueHaibing
2019-07-25 14:57 ` YueHaibing
2019-07-31 10:59 ` Petr Vorel
2019-07-31 11:06 ` Petr Vorel [this message]
2019-07-31 11:29 ` Hans de Goede
2019-07-31 11:41 ` Yuehaibing
2019-07-31 11:41 ` Yuehaibing
2019-07-31 11:46 ` Petr Vorel
2019-08-05 8:51 ` Jiri Kosina
2019-08-05 8:55 ` Hans de Goede
2019-08-05 9:27 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731110629.GB5092@dell5510 \
--to=pvorel@suse.cz \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.