From: Greg KH <gregkh@linuxfoundation.org>
To: Oded Gabbay <oded.gabbay@gmail.com>
Cc: linux-kernel@vger.kernel.org, oshpigelman@habana.ai, ttayar@habana.ai
Subject: Re: [PATCH v3 7/7] habanalabs: create two char devices per ASIC
Date: Wed, 31 Jul 2019 15:02:23 +0200 [thread overview]
Message-ID: <20190731130223.GB7590@kroah.com> (raw)
In-Reply-To: <20190731125901.20709-8-oded.gabbay@gmail.com>
On Wed, Jul 31, 2019 at 03:59:01PM +0300, Oded Gabbay wrote:
> This patch changes the driver to create two char devices for each ASIC
> it discovers. This is done to allow system/monitoring applications to
> query the device for stats, information, idle state and more, while also
> allowing the deep-learning application to send work to the ASIC.
>
> One char device is the original device, hlX. IOCTL calls through this
> device file can perform any task on the device (compute, memory, queries).
> The open function for this device will fail if it was called before but
> the file-descriptor it created was not completely released yet (the
> release callback function is not called from the kernel until all
> instances of that FD are closed). The driver needs to keep this behavior
> to support backward compatibility with existing userspace, which count
> that the open will fail if the device is "occupied".
>
> The second char device is called "hl_controlDx", where x is the same index
> of the main device with a minor number of the original char device + 1.
> Applications that open this device can only call the INFO IOCTL. There is
> no limitation on the number of applications opening this device.
>
> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Looks good, thanks for changing the minor allocation:
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2019-07-31 13:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 12:58 [PATCH v3 0/7] habanalabs: support info queries by multiple processes Oded Gabbay
2019-07-31 12:58 ` [PATCH v3 1/7] habanalabs: add handle field to context structure Oded Gabbay
2019-07-31 12:58 ` [PATCH v3 2/7] habanalabs: kill user process after CS rollback Oded Gabbay
2019-07-31 12:58 ` [PATCH v3 3/7] habanalabs: show the process context dram usage Oded Gabbay
2019-07-31 12:58 ` [PATCH v3 4/7] habanalabs: rename user_ctx as compute_ctx Oded Gabbay
2019-07-31 12:58 ` [PATCH v3 5/7] habanalabs: maintain a list of file private data objects Oded Gabbay
2019-07-31 12:59 ` [PATCH v3 6/7] habanalabs: change device_setup_cdev() to be more generic Oded Gabbay
2019-07-31 12:59 ` [PATCH v3 7/7] habanalabs: create two char devices per ASIC Oded Gabbay
2019-07-31 13:02 ` Greg KH [this message]
2019-07-31 13:02 ` [PATCH v3 0/7] habanalabs: support info queries by multiple processes Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731130223.GB7590@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oded.gabbay@gmail.com \
--cc=oshpigelman@habana.ai \
--cc=ttayar@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.