From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8939FC32751 for ; Wed, 31 Jul 2019 14:45:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C94020659 for ; Wed, 31 Jul 2019 14:45:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387591AbfGaOps (ORCPT ); Wed, 31 Jul 2019 10:45:48 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:39487 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387553AbfGaOps (ORCPT ); Wed, 31 Jul 2019 10:45:48 -0400 X-Originating-IP: 86.250.200.211 Received: from localhost (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: antoine.tenart@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 06F6460014; Wed, 31 Jul 2019 14:45:44 +0000 (UTC) Date: Wed, 31 Jul 2019 16:45:44 +0200 From: Antoine Tenart To: Pascal Van Leeuwen Cc: Antoine Tenart , Pascal van Leeuwen , "linux-crypto@vger.kernel.org" , "herbert@gondor.apana.org.au" , "davem@davemloft.net" Subject: Re: [PATCHv2 3/3] crypto: inside-secure - add support for using the EIP197 without vendor firmware Message-ID: <20190731144544.GE3579@kwain> References: <1564145005-26731-1-git-send-email-pvanleeuwen@verimatrix.com> <1564145005-26731-4-git-send-email-pvanleeuwen@verimatrix.com> <20190731122629.GC3579@kwain> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Jul 31, 2019 at 02:23:27PM +0000, Pascal Van Leeuwen wrote: > > From: Antoine Tenart > > > What happens if i < 2 ? > > > Ok, I did not consider that as it can't happen for any kind of legal FW. But it > wouldn't be pretty (neither would 2 itself, BTW). I could throw an error for it > but it wouldn't make that much sense as we don't do any checks on the firm- > ware *contents* either ... So either way, if your firmware file is no good, you > have a problem ... The thing is to avoid doing harm to the kernel if a single driver can't work as expected, especially when we have an user input (the firmware). The firmware being a valid one is another topic. But honestly I'm not sure if a wrong returned value would change anything here, apart from not probing the driver successfully as we know something went wrong. Thanks, Antoine -- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com