From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Tri Vo <trong@android.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Hridya Valsaraju <hridya@google.com>,
Sandeep Patil <sspatil@google.com>,
Kalesh Singh <kaleshsingh@google.com>,
Ravi Chandra Sadineni <ravisadineni@chromium.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
"Cc: Android Kernel" <kernel-team@android.com>,
kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH v5] PM / wakeup: show wakeup sources stats in sysfs
Date: Wed, 31 Jul 2019 19:17:20 +0200 [thread overview]
Message-ID: <20190731171720.GA15301@kroah.com> (raw)
In-Reply-To: <5d41cc55.1c69fb81.9480d.8a49@mx.google.com>
On Wed, Jul 31, 2019 at 10:13:57AM -0700, Stephen Boyd wrote:
> Quoting Rafael J. Wysocki (2019-07-31 04:58:36)
> > On Wednesday, July 31, 2019 10:34:11 AM CEST Rafael J. Wysocki wrote:
> > > On Wed, Jul 31, 2019 at 1:41 AM Stephen Boyd <swboyd@chromium.org> wrote:
> > > >
> > >
> > > > We can run into the same problem when two buses name their devices the
> > > > same name and then we attempt to attach a wakeup source to those two
> > > > devices. Or we can have a problem where a virtual wakeup is made with
> > > > the same name, and again we'll try to make a duplicate named device.
> > > > Using something like 'event' or 'wakeup' or 'ws' as the prefix avoids this
> > > > problem and keeps things clean.
> > >
> > > Or suffix, like "<devname-wakeup>.
> > >
> > > But if prefixes are used by an existing convention, I would prefer
> > > "ws-" as it is concise enough and should not be confusing.
>
> Another possibility is 'eventN', so it reads as /sys/class/wakeup/event0
"eventX" is a prefix already used by the input subsystem, so you might
run into conflicts here :(
"wakeupX" makes sense, no namespace colisions there at all.
thanks,
greg k-h
next prev parent reply other threads:[~2019-07-31 17:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 2:43 [PATCH v5] PM / wakeup: show wakeup sources stats in sysfs Tri Vo
2019-07-30 5:46 ` Rafael J. Wysocki
2019-07-30 18:39 ` Tri Vo
2019-07-30 18:48 ` Stephen Boyd
2019-07-30 18:51 ` Greg Kroah-Hartman
2019-07-30 22:17 ` Rafael J. Wysocki
2019-07-30 22:26 ` Stephen Boyd
2019-07-30 23:05 ` Rafael J. Wysocki
2019-07-30 23:31 ` Tri Vo
2019-07-30 23:41 ` Stephen Boyd
2019-07-31 8:34 ` Rafael J. Wysocki
2019-07-31 11:58 ` Rafael J. Wysocki
2019-07-31 17:13 ` Stephen Boyd
2019-07-31 17:17 ` Greg Kroah-Hartman [this message]
2019-07-31 21:19 ` Rafael J. Wysocki
2019-07-31 21:23 ` Tri Vo
2019-07-30 18:49 ` Greg Kroah-Hartman
2019-07-30 6:46 ` Greg KH
2019-07-30 19:20 ` Tri Vo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731171720.GA15301@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ravisadineni@chromium.org \
--cc=rjw@rjwysocki.net \
--cc=sspatil@google.com \
--cc=swboyd@chromium.org \
--cc=trong@android.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.