From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F010C32753 for ; Wed, 31 Jul 2019 17:37:12 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id DBDA3208E4 for ; Wed, 31 Jul 2019 17:37:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBDA3208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 808804A553; Wed, 31 Jul 2019 13:37:11 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b1DYcnf8dM7q; Wed, 31 Jul 2019 13:37:10 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4CBC34A55A; Wed, 31 Jul 2019 13:37:10 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 872674A511 for ; Wed, 31 Jul 2019 13:37:08 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VSfKbBZqgSFR for ; Wed, 31 Jul 2019 13:37:07 -0400 (EDT) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7F0284A558 for ; Wed, 31 Jul 2019 13:37:06 -0400 (EDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 35BDC1596; Wed, 31 Jul 2019 10:37:06 -0700 (PDT) Received: from big-swifty.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1D8E13F71F; Wed, 31 Jul 2019 10:37:02 -0700 (PDT) From: Marc Zyngier To: Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= Subject: [PATCH 2/5] arm64: KVM: regmap: Fix unexpected switch fall-through Date: Wed, 31 Jul 2019 18:36:47 +0100 Message-Id: <20190731173650.12627-3-maz@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190731173650.12627-1-maz@kernel.org> References: <20190731173650.12627-1-maz@kernel.org> MIME-Version: 1.0 Cc: Anders Roxell , kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu RnJvbTogQW5kZXJzIFJveGVsbCA8YW5kZXJzLnJveGVsbEBsaW5hcm8ub3JnPgoKV2hlbiBmYWxs LXRocm91Z2ggd2FybmluZ3Mgd2FzIGVuYWJsZWQgYnkgZGVmYXVsdCwgY29tbWl0IGQ5MzUxMmVm MGYwZQooIk1ha2VmaWxlOiBHbG9iYWxseSBlbmFibGUgZmFsbC10aHJvdWdoIHdhcm5pbmciKSwg dGhlIGZvbGxvd2luZwp3YXJuaW5ncyB3YXMgc3RhcnRpbmcgdG8gc2hvdyB1cDoKCkluIGZpbGUg aW5jbHVkZWQgZnJvbSAuLi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL2t2bV9lbXVsYXRlLmg6MTks CiAgICAgICAgICAgICAgICAgZnJvbSAuLi9hcmNoL2FybTY0L2t2bS9yZWdtYXAuYzoxMzoKLi4v YXJjaC9hcm02NC9rdm0vcmVnbWFwLmM6IEluIGZ1bmN0aW9uIOKAmHZjcHVfd3JpdGVfc3BzcjMy 4oCZOgouLi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL2t2bV9oeXAuaDozMTozOiB3YXJuaW5nOiB0 aGlzIHN0YXRlbWVudCBtYXkgZmFsbAogdGhyb3VnaCBbLVdpbXBsaWNpdC1mYWxsdGhyb3VnaD1d CiAgIGFzbSB2b2xhdGlsZShBTFRFUk5BVElWRShfX21zcl9zKHIjI252aCwgIiV4MCIpLCBcCiAg IF5+fgouLi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL2t2bV9oeXAuaDo0NjozMTogbm90ZTogaW4g ZXhwYW5zaW9uIG9mIG1hY3JvIOKAmHdyaXRlX3N5c3JlZ19lbHjigJkKICNkZWZpbmUgd3JpdGVf c3lzcmVnX2VsMSh2LHIpIHdyaXRlX3N5c3JlZ19lbHgodiwgciwgX0VMMSwgX0VMMTIpCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+Ci4uL2FyY2gvYXJtNjQv a3ZtL3JlZ21hcC5jOjE4MDozOiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCYd3JpdGVf c3lzcmVnX2VsMeKAmQogICB3cml0ZV9zeXNyZWdfZWwxKHYsIFNZU19TUFNSKTsKICAgXn5+fn5+ fn5+fn5+fn5+fgouLi9hcmNoL2FybTY0L2t2bS9yZWdtYXAuYzoxODE6Mjogbm90ZTogaGVyZQog IGNhc2UgS1ZNX1NQU1JfQUJUOgogIF5+fn4KSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4uL2FyY2gv YXJtNjQvaW5jbHVkZS9hc20vY3B1dHlwZS5oOjEzMiwKICAgICAgICAgICAgICAgICBmcm9tIC4u L2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vY2FjaGUuaDo4LAogICAgICAgICAgICAgICAgIGZyb20g Li4vaW5jbHVkZS9saW51eC9jYWNoZS5oOjYsCiAgICAgICAgICAgICAgICAgZnJvbSAuLi9pbmNs dWRlL2xpbnV4L3ByaW50ay5oOjksCiAgICAgICAgICAgICAgICAgZnJvbSAuLi9pbmNsdWRlL2xp bnV4L2tlcm5lbC5oOjE1LAogICAgICAgICAgICAgICAgIGZyb20gLi4vaW5jbHVkZS9hc20tZ2Vu ZXJpYy9idWcuaDoxOCwKICAgICAgICAgICAgICAgICBmcm9tIC4uL2FyY2gvYXJtNjQvaW5jbHVk ZS9hc20vYnVnLmg6MjYsCiAgICAgICAgICAgICAgICAgZnJvbSAuLi9pbmNsdWRlL2xpbnV4L2J1 Zy5oOjUsCiAgICAgICAgICAgICAgICAgZnJvbSAuLi9pbmNsdWRlL2xpbnV4L21tZGVidWcuaDo1 LAogICAgICAgICAgICAgICAgIGZyb20gLi4vaW5jbHVkZS9saW51eC9tbS5oOjksCiAgICAgICAg ICAgICAgICAgZnJvbSAuLi9hcmNoL2FybTY0L2t2bS9yZWdtYXAuYzoxMToKLi4vYXJjaC9hcm02 NC9pbmNsdWRlL2FzbS9zeXNyZWcuaDo4Mzc6Mjogd2FybmluZzogdGhpcyBzdGF0ZW1lbnQgbWF5 IGZhbGwKIHRocm91Z2ggWy1XaW1wbGljaXQtZmFsbHRocm91Z2g9XQogIGFzbSB2b2xhdGlsZSgi bXNyICIgX19zdHJpbmdpZnkocikgIiwgJXgwIiAgXAogIF5+fgouLi9hcmNoL2FybTY0L2t2bS9y ZWdtYXAuYzoxODI6Mzogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmHdyaXRlX3N5c3Jl Z+KAmQogICB3cml0ZV9zeXNyZWcodiwgc3Bzcl9hYnQpOwogICBefn5+fn5+fn5+fn4KLi4vYXJj aC9hcm02NC9rdm0vcmVnbWFwLmM6MTgzOjI6IG5vdGU6IGhlcmUKICBjYXNlIEtWTV9TUFNSX1VO RDoKICBefn5+CgpSZXdvcmsgdG8gYWRkIGEgJ2JyZWFrOycgaW4gdGhlIHN3aWNoLWNhc2Ugc2lu Y2UgaXQgZGlkbid0IGhhdmUgdGhhdCwKbGVhZGluZyB0byBhbiBpbnRlcnJlc3Rpbmcgc2V0IG9m IGJ1Z3MuCgpDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZyAjIHY0LjE3KwpGaXhlczogYTg5Mjgx OTU2MGM0ICgiS1ZNOiBhcm02NDogUHJlcGFyZSB0byBoYW5kbGUgZGVmZXJyZWQgc2F2ZS9yZXN0 b3JlIG9mIDMyLWJpdCByZWdpc3RlcnMiKQpTaWduZWQtb2ZmLWJ5OiBBbmRlcnMgUm94ZWxsIDxh bmRlcnMucm94ZWxsQGxpbmFyby5vcmc+ClttYXo6IHJld29ya2VkIGNvbW1pdCBtZXNzYWdlLCBm aXhlZCBzdGFibGUgcmFuZ2VdClNpZ25lZC1vZmYtYnk6IE1hcmMgWnluZ2llciA8bWF6QGtlcm5l bC5vcmc+Ci0tLQogYXJjaC9hcm02NC9rdm0vcmVnbWFwLmMgfCA1ICsrKysrCiAxIGZpbGUgY2hh bmdlZCwgNSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9rdm0vcmVnbWFw LmMgYi9hcmNoL2FybTY0L2t2bS9yZWdtYXAuYwppbmRleCAwZDYwZTRmMGFmNjYuLmE5MDAxODFl Mzg2NyAxMDA2NDQKLS0tIGEvYXJjaC9hcm02NC9rdm0vcmVnbWFwLmMKKysrIGIvYXJjaC9hcm02 NC9rdm0vcmVnbWFwLmMKQEAgLTE3OCwxMyArMTc4LDE4IEBAIHZvaWQgdmNwdV93cml0ZV9zcHNy MzIoc3RydWN0IGt2bV92Y3B1ICp2Y3B1LCB1bnNpZ25lZCBsb25nIHYpCiAJc3dpdGNoIChzcHNy X2lkeCkgewogCWNhc2UgS1ZNX1NQU1JfU1ZDOgogCQl3cml0ZV9zeXNyZWdfZWwxKHYsIFNZU19T UFNSKTsKKwkJYnJlYWs7CiAJY2FzZSBLVk1fU1BTUl9BQlQ6CiAJCXdyaXRlX3N5c3JlZyh2LCBz cHNyX2FidCk7CisJCWJyZWFrOwogCWNhc2UgS1ZNX1NQU1JfVU5EOgogCQl3cml0ZV9zeXNyZWco diwgc3Bzcl91bmQpOworCQlicmVhazsKIAljYXNlIEtWTV9TUFNSX0lSUToKIAkJd3JpdGVfc3lz cmVnKHYsIHNwc3JfaXJxKTsKKwkJYnJlYWs7CiAJY2FzZSBLVk1fU1BTUl9GSVE6CiAJCXdyaXRl X3N5c3JlZyh2LCBzcHNyX2ZpcSk7CisJCWJyZWFrOwogCX0KIH0KLS0gCjIuMjAuMQoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcg bGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1i aWEuZWR1L21haWxtYW4vbGlzdGluZm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BF50C433FF for ; Wed, 31 Jul 2019 17:37:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29C122067D for ; Wed, 31 Jul 2019 17:37:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R6Zbpkb6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29C122067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3R0CrUiRAE9eJ2XJjYbf6cZDg6S31yfwBWDx2cKE7q8=; b=R6Zbpkb6FsaDUC iHiqid7NBNVh5RB4TBleorYSeK0NpmyYZDN9gablrxcr7qL5H0PsFNc8bZSS/R+LBKE+C2zkgnAAe m0vLAJ4PZnMv7Cvq2U8RZuhkD/iWL1tvj7vKqUifuF4LHfTYqy3Qz9v0G3yL0jOozoepuU2Adve6m J0dYNydG1h4mGuEXqOafA1NetEFsYx86wZQLfSxygiyF4QxMoja80JcMa/1pF1wKlZBPpoR3lSKew Nb2vk1NgB7+GsN5ORMsoJmH4+Jakav5THwme7KusCWE+pt7Y3mIAskgNBGVGL8iMNyhHDNmf/mBaE zvOdI+0LFmO72MDjuhHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hssXR-00051Q-UG; Wed, 31 Jul 2019 17:37:21 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hssXC-0004hl-HG for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2019 17:37:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 35BDC1596; Wed, 31 Jul 2019 10:37:06 -0700 (PDT) Received: from big-swifty.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1D8E13F71F; Wed, 31 Jul 2019 10:37:02 -0700 (PDT) From: Marc Zyngier To: Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= Subject: [PATCH 2/5] arm64: KVM: regmap: Fix unexpected switch fall-through Date: Wed, 31 Jul 2019 18:36:47 +0100 Message-Id: <20190731173650.12627-3-maz@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190731173650.12627-1-maz@kernel.org> References: <20190731173650.12627-1-maz@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190731_103706_668992_FC87D966 X-CRM114-Status: UNSURE ( 9.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anders Roxell , kvm@vger.kernel.org, Suzuki K Poulose , Julien Thierry , James Morse , Zenghui Yu , Andrew Murray , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org RnJvbTogQW5kZXJzIFJveGVsbCA8YW5kZXJzLnJveGVsbEBsaW5hcm8ub3JnPgoKV2hlbiBmYWxs LXRocm91Z2ggd2FybmluZ3Mgd2FzIGVuYWJsZWQgYnkgZGVmYXVsdCwgY29tbWl0IGQ5MzUxMmVm MGYwZQooIk1ha2VmaWxlOiBHbG9iYWxseSBlbmFibGUgZmFsbC10aHJvdWdoIHdhcm5pbmciKSwg dGhlIGZvbGxvd2luZwp3YXJuaW5ncyB3YXMgc3RhcnRpbmcgdG8gc2hvdyB1cDoKCkluIGZpbGUg aW5jbHVkZWQgZnJvbSAuLi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL2t2bV9lbXVsYXRlLmg6MTks CiAgICAgICAgICAgICAgICAgZnJvbSAuLi9hcmNoL2FybTY0L2t2bS9yZWdtYXAuYzoxMzoKLi4v YXJjaC9hcm02NC9rdm0vcmVnbWFwLmM6IEluIGZ1bmN0aW9uIOKAmHZjcHVfd3JpdGVfc3BzcjMy 4oCZOgouLi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL2t2bV9oeXAuaDozMTozOiB3YXJuaW5nOiB0 aGlzIHN0YXRlbWVudCBtYXkgZmFsbAogdGhyb3VnaCBbLVdpbXBsaWNpdC1mYWxsdGhyb3VnaD1d CiAgIGFzbSB2b2xhdGlsZShBTFRFUk5BVElWRShfX21zcl9zKHIjI252aCwgIiV4MCIpLCBcCiAg IF5+fgouLi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL2t2bV9oeXAuaDo0NjozMTogbm90ZTogaW4g ZXhwYW5zaW9uIG9mIG1hY3JvIOKAmHdyaXRlX3N5c3JlZ19lbHjigJkKICNkZWZpbmUgd3JpdGVf c3lzcmVnX2VsMSh2LHIpIHdyaXRlX3N5c3JlZ19lbHgodiwgciwgX0VMMSwgX0VMMTIpCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+Ci4uL2FyY2gvYXJtNjQv a3ZtL3JlZ21hcC5jOjE4MDozOiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCYd3JpdGVf c3lzcmVnX2VsMeKAmQogICB3cml0ZV9zeXNyZWdfZWwxKHYsIFNZU19TUFNSKTsKICAgXn5+fn5+ fn5+fn5+fn5+fgouLi9hcmNoL2FybTY0L2t2bS9yZWdtYXAuYzoxODE6Mjogbm90ZTogaGVyZQog IGNhc2UgS1ZNX1NQU1JfQUJUOgogIF5+fn4KSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4uL2FyY2gv YXJtNjQvaW5jbHVkZS9hc20vY3B1dHlwZS5oOjEzMiwKICAgICAgICAgICAgICAgICBmcm9tIC4u L2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vY2FjaGUuaDo4LAogICAgICAgICAgICAgICAgIGZyb20g Li4vaW5jbHVkZS9saW51eC9jYWNoZS5oOjYsCiAgICAgICAgICAgICAgICAgZnJvbSAuLi9pbmNs dWRlL2xpbnV4L3ByaW50ay5oOjksCiAgICAgICAgICAgICAgICAgZnJvbSAuLi9pbmNsdWRlL2xp bnV4L2tlcm5lbC5oOjE1LAogICAgICAgICAgICAgICAgIGZyb20gLi4vaW5jbHVkZS9hc20tZ2Vu ZXJpYy9idWcuaDoxOCwKICAgICAgICAgICAgICAgICBmcm9tIC4uL2FyY2gvYXJtNjQvaW5jbHVk ZS9hc20vYnVnLmg6MjYsCiAgICAgICAgICAgICAgICAgZnJvbSAuLi9pbmNsdWRlL2xpbnV4L2J1 Zy5oOjUsCiAgICAgICAgICAgICAgICAgZnJvbSAuLi9pbmNsdWRlL2xpbnV4L21tZGVidWcuaDo1 LAogICAgICAgICAgICAgICAgIGZyb20gLi4vaW5jbHVkZS9saW51eC9tbS5oOjksCiAgICAgICAg ICAgICAgICAgZnJvbSAuLi9hcmNoL2FybTY0L2t2bS9yZWdtYXAuYzoxMToKLi4vYXJjaC9hcm02 NC9pbmNsdWRlL2FzbS9zeXNyZWcuaDo4Mzc6Mjogd2FybmluZzogdGhpcyBzdGF0ZW1lbnQgbWF5 IGZhbGwKIHRocm91Z2ggWy1XaW1wbGljaXQtZmFsbHRocm91Z2g9XQogIGFzbSB2b2xhdGlsZSgi bXNyICIgX19zdHJpbmdpZnkocikgIiwgJXgwIiAgXAogIF5+fgouLi9hcmNoL2FybTY0L2t2bS9y ZWdtYXAuYzoxODI6Mzogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmHdyaXRlX3N5c3Jl Z+KAmQogICB3cml0ZV9zeXNyZWcodiwgc3Bzcl9hYnQpOwogICBefn5+fn5+fn5+fn4KLi4vYXJj aC9hcm02NC9rdm0vcmVnbWFwLmM6MTgzOjI6IG5vdGU6IGhlcmUKICBjYXNlIEtWTV9TUFNSX1VO RDoKICBefn5+CgpSZXdvcmsgdG8gYWRkIGEgJ2JyZWFrOycgaW4gdGhlIHN3aWNoLWNhc2Ugc2lu Y2UgaXQgZGlkbid0IGhhdmUgdGhhdCwKbGVhZGluZyB0byBhbiBpbnRlcnJlc3Rpbmcgc2V0IG9m IGJ1Z3MuCgpDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZyAjIHY0LjE3KwpGaXhlczogYTg5Mjgx OTU2MGM0ICgiS1ZNOiBhcm02NDogUHJlcGFyZSB0byBoYW5kbGUgZGVmZXJyZWQgc2F2ZS9yZXN0 b3JlIG9mIDMyLWJpdCByZWdpc3RlcnMiKQpTaWduZWQtb2ZmLWJ5OiBBbmRlcnMgUm94ZWxsIDxh bmRlcnMucm94ZWxsQGxpbmFyby5vcmc+ClttYXo6IHJld29ya2VkIGNvbW1pdCBtZXNzYWdlLCBm aXhlZCBzdGFibGUgcmFuZ2VdClNpZ25lZC1vZmYtYnk6IE1hcmMgWnluZ2llciA8bWF6QGtlcm5l bC5vcmc+Ci0tLQogYXJjaC9hcm02NC9rdm0vcmVnbWFwLmMgfCA1ICsrKysrCiAxIGZpbGUgY2hh bmdlZCwgNSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9rdm0vcmVnbWFw LmMgYi9hcmNoL2FybTY0L2t2bS9yZWdtYXAuYwppbmRleCAwZDYwZTRmMGFmNjYuLmE5MDAxODFl Mzg2NyAxMDA2NDQKLS0tIGEvYXJjaC9hcm02NC9rdm0vcmVnbWFwLmMKKysrIGIvYXJjaC9hcm02 NC9rdm0vcmVnbWFwLmMKQEAgLTE3OCwxMyArMTc4LDE4IEBAIHZvaWQgdmNwdV93cml0ZV9zcHNy MzIoc3RydWN0IGt2bV92Y3B1ICp2Y3B1LCB1bnNpZ25lZCBsb25nIHYpCiAJc3dpdGNoIChzcHNy X2lkeCkgewogCWNhc2UgS1ZNX1NQU1JfU1ZDOgogCQl3cml0ZV9zeXNyZWdfZWwxKHYsIFNZU19T UFNSKTsKKwkJYnJlYWs7CiAJY2FzZSBLVk1fU1BTUl9BQlQ6CiAJCXdyaXRlX3N5c3JlZyh2LCBz cHNyX2FidCk7CisJCWJyZWFrOwogCWNhc2UgS1ZNX1NQU1JfVU5EOgogCQl3cml0ZV9zeXNyZWco diwgc3Bzcl91bmQpOworCQlicmVhazsKIAljYXNlIEtWTV9TUFNSX0lSUToKIAkJd3JpdGVfc3lz cmVnKHYsIHNwc3JfaXJxKTsKKwkJYnJlYWs7CiAJY2FzZSBLVk1fU1BTUl9GSVE6CiAJCXdyaXRl X3N5c3JlZyh2LCBzcHNyX2ZpcSk7CisJCWJyZWFrOwogCX0KIH0KLS0gCjIuMjAuMQoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D2A5C32751 for ; Wed, 31 Jul 2019 17:37:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25808206A2 for ; Wed, 31 Jul 2019 17:37:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564594628; bh=hF+7MgtpsH3ATVVRcKXlpFyPHbcf4k2PImaY871JOmk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RHsnzvekr9hrFUQPh6tmHYgJe/tQCBWdUdxsohVl5N/BihsQZwXE79t1Suq5ubR3m lU0bg0P5V8Icuh8AzNobP+F6GV1dXOaemtGtRVaA2xlkgAg9yPuWHA4xIbSzU0mlDO 3r9Gx0i7RrIFY5JUGW2dld/PSh16wCurbr1ue6pk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728232AbfGaRhH (ORCPT ); Wed, 31 Jul 2019 13:37:07 -0400 Received: from foss.arm.com ([217.140.110.172]:52480 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727125AbfGaRhH (ORCPT ); Wed, 31 Jul 2019 13:37:07 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 35BDC1596; Wed, 31 Jul 2019 10:37:06 -0700 (PDT) Received: from big-swifty.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1D8E13F71F; Wed, 31 Jul 2019 10:37:02 -0700 (PDT) From: Marc Zyngier To: Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= Cc: Anders Roxell , Andrew Murray , James Morse , Julien Thierry , Zenghui Yu , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Subject: [PATCH 2/5] arm64: KVM: regmap: Fix unexpected switch fall-through Date: Wed, 31 Jul 2019 18:36:47 +0100 Message-Id: <20190731173650.12627-3-maz@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190731173650.12627-1-maz@kernel.org> References: <20190731173650.12627-1-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Anders Roxell When fall-through warnings was enabled by default, commit d93512ef0f0e ("Makefile: Globally enable fall-through warning"), the following warnings was starting to show up: In file included from ../arch/arm64/include/asm/kvm_emulate.h:19, from ../arch/arm64/kvm/regmap.c:13: ../arch/arm64/kvm/regmap.c: In function ‘vcpu_write_spsr32’: ../arch/arm64/include/asm/kvm_hyp.h:31:3: warning: this statement may fall through [-Wimplicit-fallthrough=] asm volatile(ALTERNATIVE(__msr_s(r##nvh, "%x0"), \ ^~~ ../arch/arm64/include/asm/kvm_hyp.h:46:31: note: in expansion of macro ‘write_sysreg_elx’ #define write_sysreg_el1(v,r) write_sysreg_elx(v, r, _EL1, _EL12) ^~~~~~~~~~~~~~~~ ../arch/arm64/kvm/regmap.c:180:3: note: in expansion of macro ‘write_sysreg_el1’ write_sysreg_el1(v, SYS_SPSR); ^~~~~~~~~~~~~~~~ ../arch/arm64/kvm/regmap.c:181:2: note: here case KVM_SPSR_ABT: ^~~~ In file included from ../arch/arm64/include/asm/cputype.h:132, from ../arch/arm64/include/asm/cache.h:8, from ../include/linux/cache.h:6, from ../include/linux/printk.h:9, from ../include/linux/kernel.h:15, from ../include/asm-generic/bug.h:18, from ../arch/arm64/include/asm/bug.h:26, from ../include/linux/bug.h:5, from ../include/linux/mmdebug.h:5, from ../include/linux/mm.h:9, from ../arch/arm64/kvm/regmap.c:11: ../arch/arm64/include/asm/sysreg.h:837:2: warning: this statement may fall through [-Wimplicit-fallthrough=] asm volatile("msr " __stringify(r) ", %x0" \ ^~~ ../arch/arm64/kvm/regmap.c:182:3: note: in expansion of macro ‘write_sysreg’ write_sysreg(v, spsr_abt); ^~~~~~~~~~~~ ../arch/arm64/kvm/regmap.c:183:2: note: here case KVM_SPSR_UND: ^~~~ Rework to add a 'break;' in the swich-case since it didn't have that, leading to an interresting set of bugs. Cc: stable@vger.kernel.org # v4.17+ Fixes: a892819560c4 ("KVM: arm64: Prepare to handle deferred save/restore of 32-bit registers") Signed-off-by: Anders Roxell [maz: reworked commit message, fixed stable range] Signed-off-by: Marc Zyngier --- arch/arm64/kvm/regmap.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm64/kvm/regmap.c b/arch/arm64/kvm/regmap.c index 0d60e4f0af66..a900181e3867 100644 --- a/arch/arm64/kvm/regmap.c +++ b/arch/arm64/kvm/regmap.c @@ -178,13 +178,18 @@ void vcpu_write_spsr32(struct kvm_vcpu *vcpu, unsigned long v) switch (spsr_idx) { case KVM_SPSR_SVC: write_sysreg_el1(v, SYS_SPSR); + break; case KVM_SPSR_ABT: write_sysreg(v, spsr_abt); + break; case KVM_SPSR_UND: write_sysreg(v, spsr_und); + break; case KVM_SPSR_IRQ: write_sysreg(v, spsr_irq); + break; case KVM_SPSR_FIQ: write_sysreg(v, spsr_fiq); + break; } } -- 2.20.1