All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramon Fried <rfried.dev@gmail.com>
To: bgolaszewski@baylibre.com
Cc: linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
	Ramon Fried <rfried.dev@gmail.com>
Subject: [libgpiod] [PATCH v2] gpioinfo: mark kernel claimed lines as used
Date: Wed, 31 Jul 2019 20:38:14 +0300	[thread overview]
Message-ID: <20190731173814.3400-1-rfried.dev@gmail.com> (raw)

In case where the GPIOLINE_FLAG_KERNEL flag was set
and no consumer string is provided by the kernel,
the used column was still showing the pin as "unused"
Fix that by writing "kernel".

Signed-off-by: Ramon Fried <rfried.dev@gmail.com>
---
v2:
  * Restructure for clarity
  * Print "kernel" if line is used by kernel.
  * Update commit message

 tools/gpioinfo.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/gpioinfo.c b/tools/gpioinfo.c
index bb17262..ba0327b 100644
--- a/tools/gpioinfo.c
+++ b/tools/gpioinfo.c
@@ -119,8 +119,12 @@ static void list_lines(struct gpiod_chip *chip)
 		     : prinfo(&of, 12, "unnamed");
 		printf(" ");
 
-		consumer ? prinfo(&of, 12, "\"%s\"", consumer)
-			 : prinfo(&of, 12, "unused");
+		if (!gpiod_line_is_used(line))
+		      prinfo(&of, 12, "unused");
+		else
+			consumer ? prinfo(&of, 12, "\"%s\"", consumer)
+				: prinfo(&of, 12, "kernel");
+
 		printf(" ");
 
 		prinfo(&of, 8, "%s ", direction == GPIOD_LINE_DIRECTION_INPUT
-- 
2.22.0


             reply	other threads:[~2019-07-31 17:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31 17:38 Ramon Fried [this message]
2019-08-01  8:10 ` [libgpiod] [PATCH v2] gpioinfo: mark kernel claimed lines as used Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190731173814.3400-1-rfried.dev@gmail.com \
    --to=rfried.dev@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.