From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH rfc 1/2] nvme: don't remove namespace if revalidate failed because of controller reset
Date: Wed, 31 Jul 2019 14:16:34 -0600 [thread overview]
Message-ID: <20190731201634.GC15643@localhost.localdomain> (raw)
In-Reply-To: <0720636c-8706-e927-3c0b-c2687694664f@grimberg.me>
On Wed, Jul 31, 2019@01:08:05PM -0700, Sagi Grimberg wrote:
>
> > > I think I asked this but was not answered, why are we removing
> > > the namespace at all? do others do the same thing (remove the
> > > disk if revalidation fails)?
> >
> > If a namespace no longer exists,
>
> Why is it no longer exists? it failed revalidate..
One way it fails to validate is if it doesn't exist, i.e., the
controller returned an error when attempting to identify it.
The other way it may fail to revalidate is if its identify has changed
since we last discovered it, so removal is better than data corruption.
Either scenario could happen from administrative namespace management
commands to any controller in the subsystem.
> > what do you want to do with it instead of removing it?
>
> Well, I don't see anyone else even checking the return
> status of revalidate_disk.. Perhaps Hannes can share more
> on how scsi handles this?
Other drivers may have a different path to this, but I'd imagine they
handle a LUN deletion somehow.
next prev parent reply other threads:[~2019-07-31 20:16 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 23:31 [PATCH rfc 0/2] nvme controller reset and namespace scan work race conditions Sagi Grimberg
2019-07-29 23:32 ` [PATCH rfc 1/2] nvme: don't remove namespace if revalidate failed because of controller reset Sagi Grimberg
2019-07-30 0:59 ` Keith Busch
2019-07-30 1:04 ` Sagi Grimberg
2019-07-30 1:04 ` Ming Lei
2019-07-30 1:06 ` Sagi Grimberg
2019-07-30 1:10 ` Ming Lei
2019-07-30 1:19 ` Sagi Grimberg
2019-07-30 1:30 ` Ming Lei
2019-07-30 1:40 ` Sagi Grimberg
2019-07-30 2:09 ` Ming Lei
2019-07-30 17:12 ` Sagi Grimberg
2019-07-30 17:30 ` Keith Busch
2019-07-30 18:15 ` Sagi Grimberg
2019-07-31 7:13 ` Hannes Reinecke
2019-07-31 18:08 ` Sagi Grimberg
2019-07-31 7:01 ` Hannes Reinecke
2019-07-31 14:16 ` Keith Busch
2019-07-31 18:03 ` Sagi Grimberg
2019-07-31 19:32 ` Keith Busch
2019-07-31 20:08 ` Sagi Grimberg
2019-07-31 20:16 ` Keith Busch [this message]
2019-07-31 20:45 ` Sagi Grimberg
2019-07-31 20:58 ` Keith Busch
2019-07-31 21:14 ` Sagi Grimberg
2019-07-31 21:54 ` Keith Busch
2019-08-01 1:13 ` Sagi Grimberg
2019-08-01 14:33 ` Keith Busch
2019-08-01 18:52 ` Sagi Grimberg
2019-07-31 6:58 ` Hannes Reinecke
2019-07-31 18:11 ` Sagi Grimberg
2019-07-31 20:02 ` Hannes Reinecke
2019-07-31 20:16 ` Sagi Grimberg
2019-07-31 12:18 ` Hannes Reinecke
2019-07-31 18:16 ` Sagi Grimberg
2019-07-31 20:04 ` Hannes Reinecke
2019-07-31 20:37 ` Sagi Grimberg
2019-07-29 23:32 ` [PATCH rfc 2/2] nvme: fix possible use-after-free condition when controller reset is racing namespace scanning Sagi Grimberg
2019-07-31 12:23 ` Hannes Reinecke
2019-07-31 18:21 ` Sagi Grimberg
2019-08-01 7:24 ` Hannes Reinecke
2019-08-01 18:46 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731201634.GC15643@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.