From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC PATCH v4 2/2] iputils: add capability for clockdiff, ping, traceroute6
Date: Thu, 1 Aug 2019 00:13:10 +0200 [thread overview]
Message-ID: <20190801001310.644e3dc0@windsurf.home> (raw)
In-Reply-To: <20190731160059.GJ3194@scaer>
Hello,
On Wed, 31 Jul 2019 18:00:59 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > Use cap_net_raw+p (drop +e) as upstream sets that via
> > cap_set_flag(), see https://github.com/iputils/iputils/issues/194
>
> So, now we set the capabilities to those exectuables, do they still need
> to be setuid?
>
> But then, if one really does not want xattr, setuid is still required.
Ah, yes, indeed.
> So, we have no way to express that a file should have either setuid or
> xattrs, except as a big if-block like:
>
> ifeq ($(BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES),y)
> define IPUTILS_PERMISSIONS
> /usr/bin/clockdiff f 0755 0 0 - - - - -
> |xattr cap_net_raw+p
> endef
> else
> define IPUTILS_PERMISSIONS
> /usr/bin/clockdiff f 4755 0 0 - - - - -
> endef
> endif
>
> ... which is what we were trying to avoid in the firstplace...
Yes, but I believe it's the best solution for now, let's keep a
conditional like you're showing here. Which of course makes the change
to makedevs no longer relevant.
I really hope Petr is not going to hate us for all the discussion, back
and forth and change of mind/opinion about this topic :-/
> We could write something like:
>
> /usr/bin/clockdiff f $(MAYBE_SUID)755 0 0 - - - - -
> |xattr cap_net_raw+p
>
> Where MAYBE_SUID would be set as:
>
> MAYBE_SUID = $(if $(BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES),0,4)
>
> But it is starting to be a bit more complex than what you initially
> envisionned, I guess.
Meh, no, please not like this.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-07-31 22:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 21:38 [Buildroot] [RFC PATCH v4 1/2] makedevs: only warn when xattr support disabled Petr Vorel
2019-07-30 21:38 ` [Buildroot] [RFC PATCH v4 2/2] iputils: add capability for clockdiff, ping, traceroute6 Petr Vorel
2019-07-31 16:00 ` Yann E. MORIN
2019-07-31 20:11 ` Petr Vorel
2019-07-31 22:13 ` Thomas Petazzoni [this message]
2019-07-31 22:24 ` Petr Vorel
2019-08-01 7:29 ` Yann E. MORIN
2019-08-01 7:33 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801001310.644e3dc0@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.