From: Potnuri Bharat Teja <bharat@chelsio.com>
To: Kamal Heib <kamalheib1@gmail.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
Doug Ledford <dledford@redhat.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Gal Pressman <galpress@amazon.com>,
Leon Romanovsky <leon@kernel.org>,
Michal Kalderon <mkalderon@marvell.com>,
Christian Benvenuti <benve@cisco.com>,
Moni Shoua <monis@mellanox.com>,
Bernard Metzler <bmt@zurich.ibm.com>,
Shiraz Saleem <shiraz.saleem@intel.com>
Subject: Re: [PATCH for-next V2 4/4] RDMA/{cxgb3, cxgb4, i40iw}: Remove common code
Date: Thu, 1 Aug 2019 14:19:36 +0530 [thread overview]
Message-ID: <20190801084934.GA2911@chelsio.com> (raw)
In-Reply-To: <20190731202459.19570-5-kamalheib1@gmail.com>
On Thursday, August 08/01/19, 2019 at 01:54:59 +0530, Kamal Heib wrote:
> Now that we have a common iWARP query port function we can remove the
> common code from the iWARP drivers.
>
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
Thanks for the changes! Ack for cxgb4.
Acked-by: Potnuri Bharat Teja <bharat@chelsio.com>
> drivers/infiniband/hw/cxgb3/iwch_provider.c | 25 ---------------------
> drivers/infiniband/hw/cxgb4/provider.c | 24 --------------------
> drivers/infiniband/hw/i40iw/i40iw_verbs.c | 11 ---------
> 3 files changed, 60 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c b/drivers/infiniband/hw/cxgb3/iwch_provider.c
> index 5848e4727b2e..dcf02ec02810 100644
> --- a/drivers/infiniband/hw/cxgb3/iwch_provider.c
> +++ b/drivers/infiniband/hw/cxgb3/iwch_provider.c
> @@ -991,33 +991,8 @@ static int iwch_query_device(struct ib_device *ibdev, struct ib_device_attr *pro
> static int iwch_query_port(struct ib_device *ibdev,
> u8 port, struct ib_port_attr *props)
> {
> - struct iwch_dev *dev;
> - struct net_device *netdev;
> - struct in_device *inetdev;
> -
> pr_debug("%s ibdev %p\n", __func__, ibdev);
>
> - dev = to_iwch_dev(ibdev);
> - netdev = dev->rdev.port_info.lldevs[port-1];
> -
> - /* props being zeroed by the caller, avoid zeroing it here */
> - props->max_mtu = IB_MTU_4096;
> - props->active_mtu = ib_mtu_int_to_enum(netdev->mtu);
> -
> - if (!netif_carrier_ok(netdev))
> - props->state = IB_PORT_DOWN;
> - else {
> - inetdev = in_dev_get(netdev);
> - if (inetdev) {
> - if (inetdev->ifa_list)
> - props->state = IB_PORT_ACTIVE;
> - else
> - props->state = IB_PORT_INIT;
> - in_dev_put(inetdev);
> - } else
> - props->state = IB_PORT_INIT;
> - }
> -
> props->port_cap_flags =
> IB_PORT_CM_SUP |
> IB_PORT_SNMP_TUNNEL_SUP |
> diff --git a/drivers/infiniband/hw/cxgb4/provider.c b/drivers/infiniband/hw/cxgb4/provider.c
> index 5e59c5708729..d373ac0fe2cb 100644
> --- a/drivers/infiniband/hw/cxgb4/provider.c
> +++ b/drivers/infiniband/hw/cxgb4/provider.c
> @@ -305,32 +305,8 @@ static int c4iw_query_device(struct ib_device *ibdev, struct ib_device_attr *pro
> static int c4iw_query_port(struct ib_device *ibdev, u8 port,
> struct ib_port_attr *props)
> {
> - struct c4iw_dev *dev;
> - struct net_device *netdev;
> - struct in_device *inetdev;
> -
> pr_debug("ibdev %p\n", ibdev);
>
> - dev = to_c4iw_dev(ibdev);
> - netdev = dev->rdev.lldi.ports[port-1];
> - /* props being zeroed by the caller, avoid zeroing it here */
> - props->max_mtu = IB_MTU_4096;
> - props->active_mtu = ib_mtu_int_to_enum(netdev->mtu);
> -
> - if (!netif_carrier_ok(netdev))
> - props->state = IB_PORT_DOWN;
> - else {
> - inetdev = in_dev_get(netdev);
> - if (inetdev) {
> - if (inetdev->ifa_list)
> - props->state = IB_PORT_ACTIVE;
> - else
> - props->state = IB_PORT_INIT;
> - in_dev_put(inetdev);
> - } else
> - props->state = IB_PORT_INIT;
> - }
> -
> props->port_cap_flags =
> IB_PORT_CM_SUP |
> IB_PORT_SNMP_TUNNEL_SUP |
> diff --git a/drivers/infiniband/hw/i40iw/i40iw_verbs.c b/drivers/infiniband/hw/i40iw/i40iw_verbs.c
> index d169a8031375..8056930bbe2c 100644
> --- a/drivers/infiniband/hw/i40iw/i40iw_verbs.c
> +++ b/drivers/infiniband/hw/i40iw/i40iw_verbs.c
> @@ -97,18 +97,7 @@ static int i40iw_query_port(struct ib_device *ibdev,
> u8 port,
> struct ib_port_attr *props)
> {
> - struct i40iw_device *iwdev = to_iwdev(ibdev);
> - struct net_device *netdev = iwdev->netdev;
> -
> - /* props being zeroed by the caller, avoid zeroing it here */
> - props->max_mtu = IB_MTU_4096;
> - props->active_mtu = ib_mtu_int_to_enum(netdev->mtu);
> -
> props->lid = 1;
> - if (netif_carrier_ok(iwdev->netdev))
> - props->state = IB_PORT_ACTIVE;
> - else
> - props->state = IB_PORT_DOWN;
> props->port_cap_flags = IB_PORT_CM_SUP | IB_PORT_REINIT_SUP |
> IB_PORT_VENDOR_CLASS_SUP | IB_PORT_BOOT_MGMT_SUP;
> props->gid_tbl_len = 1;
> --
> 2.20.1
>
prev parent reply other threads:[~2019-08-01 8:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 20:24 [PATCH for-next V2 0/4] RDMA: Cleanups and improvements Kamal Heib
2019-07-31 20:24 ` [PATCH for-next V2 1/4] RDMA: Introduce ib_port_phys_state enum Kamal Heib
2019-07-31 20:32 ` Andrew Boyer
2019-08-01 8:35 ` Devesh Sharma
2019-07-31 20:24 ` [PATCH for-next V2 2/4] RDMA/cxgb3: Use ib_device_set_netdev() Kamal Heib
2019-07-31 20:24 ` [PATCH for-next V2 3/4] RDMA/core: Add common iWARP query port Kamal Heib
2019-08-01 11:10 ` Michal Kalderon
2019-08-01 13:22 ` Kamal Heib
2019-07-31 20:24 ` [PATCH for-next V2 4/4] RDMA/{cxgb3, cxgb4, i40iw}: Remove common code Kamal Heib
2019-08-01 8:49 ` Potnuri Bharat Teja [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801084934.GA2911@chelsio.com \
--to=bharat@chelsio.com \
--cc=benve@cisco.com \
--cc=bmt@zurich.ibm.com \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=jgg@ziepe.ca \
--cc=kamalheib1@gmail.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mkalderon@marvell.com \
--cc=monis@mellanox.com \
--cc=selvin.xavier@broadcom.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.