All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramalingam C <ramalingam.c@intel.com>
To: "Sharma, Shashank" <shashank.sharma@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v10 6/6] drm/hdcp: reference for srm file format
Date: Thu, 1 Aug 2019 16:13:49 +0530	[thread overview]
Message-ID: <20190801104349.GD16303@intel.com> (raw)
In-Reply-To: <FF3DDC77922A8A4BB08A3BC48A1EA8CB8DF8FE8F@BGSMSX101.gar.corp.intel.com>

On 2019-08-01 at 16:06:37 +0530, Sharma, Shashank wrote:
> Hi Ram, 
> Just a minor nitpick. 
> 
> Regards
> Shashank
> > -----Original Message-----
> > From: dri-devel [mailto:dri-devel-bounces@lists.freedesktop.org] On Behalf Of
> > Ramalingam C
> > Sent: Friday, July 12, 2019 12:30 PM
> > To: intel-gfx <intel-gfx@lists.freedesktop.org>; dri-devel <dri-
> > devel@lists.freedesktop.org>; Pekka Paalanen <ppaalanen@gmail.com>; Daniel
> > Vetter <daniel@ffwll.ch>
> > Subject: [PATCH v10 6/6] drm/hdcp: reference for srm file format
> > 
> > In the kernel documentation, HDCP specifications links are shared as a reference for
> > SRM table format.
> > 
> > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > ---
> >  drivers/gpu/drm/drm_hdcp.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_hdcp.c b/drivers/gpu/drm/drm_hdcp.c index
> > 77433ee3d652..803bf8283b83 100644
> > --- a/drivers/gpu/drm/drm_hdcp.c
> > +++ b/drivers/gpu/drm/drm_hdcp.c
> > @@ -271,6 +271,13 @@ static void drm_hdcp_request_srm(struct drm_device
> > *drm_dev)
> >   *
> >   * SRM should be presented in the name of "display_hdcp_srm.bin".
> >   *
> > + * Format of the SRM table that userspace needs to write into the
> > + binary file
> > + * is defined at
> I would just prefer addition of 2 ',' and a ':', something like:
> Format of the SRM table, that the userspace needs to write into the binary file, is defined at:
> 
> With this change, please feel free to use:
> Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
Thanks Shashank.

-Ram
> 
> > + * 1. Renewability chapter on 55th page of HDCP 1.4 specification
> > + *
> > + https://www.digital-cp.com/sites/default/files/specifications/HDCP%20S
> > + pecification%20Rev1_4_Secure.pdf
> > + * 2. Renewability chapter on 63rd page of HDCP 2.2 specification
> > + *
> > + https://www.digital-cp.com/sites/default/files/specifications/HDCP%20o
> > + n%20HDMI%20Specification%20Rev2_2_Final1.pdf
> > + *
> >   * Returns:
> >   * TRUE on any of the KSV is revoked, else FALSE.
> >   */
> > --
> > 2.19.1
> > 
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-08-01 10:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12  7:00 [PATCH v10 0/6] HDCP2.2 Phase II Ramalingam C
2019-07-12  7:00 ` [PATCH v10 1/6] drm: Add Content protection type property Ramalingam C
2019-07-14 11:00   ` [PATCH v11 " Ramalingam C
2019-07-29 14:20     ` Pekka Paalanen
2019-07-29  9:33       ` Ramalingam C
2019-08-01 10:05         ` Pekka Paalanen
2019-08-01 10:18           ` Ramalingam C
2019-07-12  7:00 ` [PATCH v10 2/6] drm/i915: Attach content " Ramalingam C
2019-07-12  7:00 ` [PATCH v10 3/6] drm: uevent for connector status change Ramalingam C
2019-07-12  7:00 ` [PATCH v10 4/6] drm/hdcp: update content protection property with uevent Ramalingam C
2019-07-12  7:00 ` [PATCH v10 5/6] drm/i915: update the hdcp state " Ramalingam C
2019-07-12  7:00 ` [PATCH v10 6/6] drm/hdcp: reference for srm file format Ramalingam C
2019-08-01 10:36   ` Sharma, Shashank
2019-08-01 10:43     ` Ramalingam C [this message]
2019-07-12 17:48 ` ✗ Fi.CI.CHECKPATCH: warning for HDCP2.2 Phase II (rev12) Patchwork
2019-07-12 18:07 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-14  9:25 ` ✓ Fi.CI.IGT: " Patchwork
2019-07-14 18:05 ` ✗ Fi.CI.CHECKPATCH: warning for HDCP2.2 Phase II (rev13) Patchwork
2019-07-14 18:24 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-15  3:09 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190801104349.GD16303@intel.com \
    --to=ramalingam.c@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=shashank.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.