From: Wolfram Sang <wsa@the-dreams.de>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] i2c: tegra: Compile PM functions unconditionally
Date: Thu, 1 Aug 2019 14:45:52 +0200 [thread overview]
Message-ID: <20190801124552.GF1659@ninjato> (raw)
In-Reply-To: <20190707231234.11679-1-digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
On Mon, Jul 08, 2019 at 02:12:34AM +0300, Dmitry Osipenko wrote:
> The I2C driver fails to probe if CONFIG_PM_SLEEP=n because runtime PM
> doesn't depend on the PM sleep and in this case the runtime PM ops are
> not included in the driver, resulting in I2C clock not being enabled.
> It's much cleaner to simply allow compiler to remove the dead code
> instead of messing with the #ifdefs.
>
> This patch fixes such errors when CONFIG_PM_SLEEP=n:
>
> tegra-i2c 7000c400.i2c: timeout waiting for fifo flush
> tegra-i2c 7000c400.i2c: Failed to initialize i2c controller
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-08-01 12:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-07 23:12 [PATCH v1] i2c: tegra: Compile PM functions unconditionally Dmitry Osipenko
2019-07-09 10:12 ` Jon Hunter
2019-07-09 10:12 ` Jon Hunter
2019-07-09 21:03 ` Dmitry Osipenko
2019-08-01 12:45 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801124552.GF1659@ninjato \
--to=wsa@the-dreams.de \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.